From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756748AbcANSg6 (ORCPT ); Thu, 14 Jan 2016 13:36:58 -0500 Received: from mail-bn1on0091.outbound.protection.outlook.com ([157.56.110.91]:22824 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755750AbcANSg4 convert rfc822-to-8bit (ORCPT ); Thu, 14 Jan 2016 13:36:56 -0500 From: Konstantin Shkolnyy To: Martyn Welch , Konstantin Shkolnyy , "johan@kernel.org" CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit register access functions. Thread-Topic: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit register access functions. Thread-Index: AQHRRQuDqRaRNjUTIkKdODWjekzz8577XBWAgAAKFGA= Date: Thu, 14 Jan 2016 18:22:29 +0000 Message-ID: References: <1451704323-11941-1-git-send-email-konstantin.shkolnyy@gmail.com> <5697DE45.7000204@collabora.co.uk> In-Reply-To: <5697DE45.7000204@collabora.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Konstantin.Shkolnyy@silabs.com; x-originating-ip: [64.124.198.186] x-microsoft-exchange-diagnostics: 1;BLUPR0701MB1570;5:ZJkg7pvQzGKk1C8sNxxO/3WeFMvldbzJq/oFFeJS9cIcJ8bEiZWo8EF6Qs9t12hOg2VwYBuzq9Nej+EACMLU4FvS12gk3vuKMI8xI1zm9O51DC7vnGGZa3f7BckeP4CYApGQ0WUVvIWR+1Mohosw5w==;24:/EQsRg89vnHZHdm4Q3Gh7gPH1IhQVrGyh+J52cse8yR2zv4oPl5b6AcN4VITTqHEpSLl/Cuy+3NAT9Nv+7uT+KXn/x6XY6RFFAl4o1rnWq8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1570; x-ms-office365-filtering-correlation-id: 40043860-390c-48e3-0ceb-08d31d0fa984 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:BLUPR0701MB1570;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1570; x-forefront-prvs: 08213D42D3 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(13464003)(6116002)(3846002)(586003)(19580405001)(102836003)(76576001)(2501003)(4326007)(19580395003)(77096005)(1096002)(5008740100001)(99286002)(1220700001)(5003600100002)(106116001)(106356001)(5002640100001)(11100500001)(105586002)(10400500002)(5004730100002)(2906002)(189998001)(5001960100002)(86362001)(5001770100001)(66066001)(40100003)(2900100001)(76176999)(122556002)(81156007)(2950100001)(74316001)(92566002)(50986999)(33656002)(54356999)(87936001)(101416001)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0701MB1570;H:BLUPR0701MB1572.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2016 18:22:29.3371 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1570 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- > owner@vger.kernel.org] On Behalf Of Martyn Welch > Sent: Thursday, January 14, 2016 11:44 > To: Konstantin Shkolnyy; johan@kernel.org > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit register > access functions. ... > > @@ -697,14 +685,11 @@ static unsigned int > cp210x_quantise_baudrate(unsigned int baud) > > > > static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port) > > { > > - int result; > > + int err; > > > > - result = cp210x_set_config_single(port, CP210X_IFC_ENABLE, > > - > UART_ENABLE); > > - if (result) { > > - dev_err(&port->dev, "%s - Unable to enable UART\n", > __func__); > > - return result; > > - } > > + err = cp210x_write_u16_reg(port, CP210X_IFC_ENABLE, > UART_ENABLE); > > + if (err) > > + return err; > > Any reason for dropping the error message? I already print a message if the underlying usb_control_msg fails, so it should be covered there.