From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbcFLFje (ORCPT ); Sun, 12 Jun 2016 01:39:34 -0400 Received: from mail-bl2on0071.outbound.protection.outlook.com ([65.55.169.71]:42816 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750990AbcFLFjc convert rfc822-to-8bit (ORCPT ); Sun, 12 Jun 2016 01:39:32 -0400 From: "Chintakuntla, Radha" To: Henrique de Moraes Holschuh , Scot Doyle CC: Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Greg Kroah-Hartman , Jeremy Kerr , Ming Lei , "Daney, David" , Dann Frazier , Peter Hurley , Pavel Machek , Jonathan Liu , Alistair Popple , Jean-Philippe Brucker , Jiri Slaby , David Airlie , David Daney , "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , Linux Kernel Mailing List , stable , "Chintakuntla, Radha" Subject: RE: [PATCH] fbcon: warn on invalid cursor blink intervals Thread-Topic: [PATCH] fbcon: warn on invalid cursor blink intervals Thread-Index: AQHRsh4wb0ywvIDYJUiW7578XJBIAp/BFy4AgAAClICAAAYdAIAAJhuAgAC+vICADETVAIAXIchg Date: Sun, 12 Jun 2016 05:05:27 +0000 Message-ID: References: <573DE2D0.1050402@caviumnetworks.com> <573E75CD.6050202@ozlabs.org> <573E9AE5.1020206@ozlabs.org> <20160528114846.GC13329@khazad-dum.debian.net> In-Reply-To: <20160528114846.GC13329@khazad-dum.debian.net> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Radha.Chintakuntla@cavium.com; x-originating-ip: [67.148.61.246] x-ms-office365-filtering-correlation-id: e3973a93-0454-4d60-3721-08d3927f2bb6 x-microsoft-exchange-diagnostics: 1;CY1PR07MB2134;5:4SSOqw0q2vECn8MX/dK5dYmOUtSqywM1Aeez55yJ41qylIIAdtDby8rcuUmidpzOumKvzMnx3RnTjSUN2pUML9lbUvXejZGMM5iMROG5nsASDl+M48CuQif7zgN0Baaz1B1/8GMtRxgeaSWkI5dkpw==;24:iu4UvuDL5MlOtRGVJwqWj558kFjpnEbi8Lh77eD8HeYDvmpmJPHxIsS7JLeDSaqOwI1RR6v1kSgkfRJ7d9EcVhWqDmm+qkF973scl98aiLQ=;7:oZmgSEGppvh1wz2ROgaG3aSSNaQL7fUiHa8ReH0ThX2gUj2HMNuUABM4pnk4oL9LnMzszkd0GKJD/rQ1yQlrR5fOenVLjC47qKSqKutX+nAXlecmltaDztX4FOBnKSSx8v+6/OFQ2SHGFVg+PgHhtakaMra0ORA/BvoK+nYAHPlhcoWiBCqnzVQkVyM8a6MyRf5oFQoW5H6kNXnOqlOQSzg5RwjGDnQ5fayHNZh3qWs= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2134; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(31051911155226)(9452136761055)(217544274631240)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CY1PR07MB2134;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2134; x-forefront-prvs: 0971922F40 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(199003)(13464003)(24454002)(189002)(377454003)(2906002)(3660700001)(74316001)(11100500001)(4001430100002)(66066001)(5004730100002)(77096005)(5008740100001)(33656002)(189998001)(4326007)(99286002)(2950100001)(2900100001)(15975445007)(107886002)(76576001)(92566002)(68736007)(101416001)(54356999)(76176999)(3846002)(102836003)(50986999)(3280700002)(6116002)(106116001)(5001770100001)(97736004)(10400500002)(105586002)(87936001)(8936002)(586003)(106356001)(122556002)(93886004)(5003600100002)(9686002)(19580405001)(19580395003)(81166006)(81156014)(8676002)(5002640100001)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2134;H:BLUPR0701MB1620.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2016 05:05:27.8153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Henrique de Moraes Holschuh [mailto:hmh@hmh.eng.br] > Sent: Saturday, May 28, 2016 4:49 AM > To: Scot Doyle > Cc: Tomi Valkeinen ; Jean-Christophe Plagniol- > Villard ; Greg Kroah-Hartman > ; Jeremy Kerr ; Ming Lei > ; Daney, David ; > Dann Frazier ; Peter Hurley > ; Pavel Machek ; Jonathan Liu > ; Alistair Popple ; Jean-Philippe > Brucker ; Chintakuntla, Radha > ; Jiri Slaby ; David > Airlie ; David Daney ; dri- > devel@lists.freedesktop.org; linux-fbdev@vger.kernel.org; Linux Kernel > Mailing List ; stable > > Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals > > On Fri, 20 May 2016, Scot Doyle wrote: > > On Fri, 20 May 2016, Jeremy Kerr wrote: > > > >Then looks there are two fix patches acked & tested: > > > > > > > > - the patch in this thread > > > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor > > > >blink timer." > > > > https://lkml.org/lkml/2016/5/17/455 > > > > > > > >So which one will be pushed to linus? > > > > > > Not that it's my call, but we may want both; the first as a safety > > > measure to prevent an invalid cur_blink_jiffies ever being set, and the > > > second one to actually fix the initialisation of vc_cur_blink_ms (and > > > address the warning introduced by the first). > > > > Tomi / Greg, > > > > I'd suggest > > - applying "tty: vt: Fix soft lockup in fbcon cursor blink timer." to 4.7 and > stable[4.2] > > - applying "fbcon: warn on invalid cursor blink intervals" to 4.7 > > - ignoring "fbcon: use default if cursor blink interval is not valid" > > > > Note: the patches don't depend on each other > > I applied both recommended patches on top of 4.4.11 for testing, and they > made things a lot better here. > > I suggest the second patch should be backported to stable too, might as well > fix this thing for good *and keep the door closed*. Is this patch available on some tree so that I can point to ? And hope it will make it to linux-next soon ? > > -- > "One disk to rule them all, One disk to find them. One disk to bring > them all and in the darkness grind them. In the Land of Redmond > where the shadows lie." -- The Silicon Valley Tarot > Henrique Holschuh