linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anurag Kumar Vulisha <anuragku@xilinx.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: host: xhci-plat: Iterate over parent nodes for finding quirks
Date: Mon, 6 Aug 2018 11:14:25 +0000	[thread overview]
Message-ID: <BN3PR0201MB09935DC6F4A0BA4876DF82A4A7200@BN3PR0201MB0993.namprd02.prod.outlook.com> (raw)
In-Reply-To: <51566ca4-1002-5c62-71d0-9da610bff368@linux.intel.com>

Hi Mathais,
>>
>>>>
>>>> -	if (device_property_read_bool(sysdev, "usb3-lpm-capable"))
>>>> -		xhci->quirks |= XHCI_LPM_SUPPORT;
>>>> +		if (device_property_read_bool(tmpdev, "usb2-lpm-disable"))
>>>> +			xhci->quirks |= XHCI_HW_LPM_DISABLE;
>>>>
>>>> -	if (device_property_read_bool(&pdev->dev, "quirk-broken-port-ped"))
>>>> -		xhci->quirks |= XHCI_BROKEN_PORT_PED;
>>>> +		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
>>>> +			xhci->quirks |= XHCI_LPM_SUPPORT;
>>>>
>>>> -	/* imod_interval is the interrupt moderation value in nanoseconds. */
>>>> -	xhci->imod_interval = 40000;
>>>
>>> Setting the default imod_interval could be moved before the for()
>>> loop
>>>
>>
>> I thought it would be better if everything related to imod_interval is
>> in one place, so kept it as is. I can fix this in v2 if you suggest.
>
>Default imod_interval needs to be set before the for loop to avoid overwriting a value
>got from device property
>
>So a v2 is needed
>

Thanks for correcting, will fix and send v2

Thanks,
Anurag Kumar Vulisha

>-Mathias

      reply	other threads:[~2018-08-06 11:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 15:20 [PATCH] usb: host: xhci-plat: Iterate over parent nodes for finding quirks Anurag Kumar Vulisha
2018-06-05 15:25 ` Greg Kroah-Hartman
2018-06-05 18:41   ` Anurag Kumar Vulisha
2018-06-12  7:03     ` Anurag Kumar Vulisha
2018-06-12  8:02       ` Greg Kroah-Hartman
2018-07-14 15:37         ` Anurag Kumar Vulisha
2018-07-15  8:02           ` Greg Kroah-Hartman
2018-07-15  8:11             ` Greg Kroah-Hartman
2018-07-20 14:53               ` Mathias Nyman
2018-08-06  7:58                 ` Anurag Kumar Vulisha
2018-08-06 11:11                   ` Mathias Nyman
2018-08-06 11:41                     ` Anurag Kumar Vulisha
2018-07-20 14:42 ` Mathias Nyman
2018-07-20 15:39   ` Anurag Kumar Vulisha
2018-08-06 10:50     ` Mathias Nyman
2018-08-06 11:14       ` Anurag Kumar Vulisha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN3PR0201MB09935DC6F4A0BA4876DF82A4A7200@BN3PR0201MB0993.namprd02.prod.outlook.com \
    --to=anuragku@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).