From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754830AbbGNKMa (ORCPT ); Tue, 14 Jul 2015 06:12:30 -0400 Received: from mail-bn1on0114.outbound.protection.outlook.com ([157.56.110.114]:34488 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753864AbbGNKM3 convert rfc822-to-8bit (ORCPT ); Tue, 14 Jul 2015 06:12:29 -0400 From: Huan Wang To: Mark Rutland CC: "shawnguo@kernel.org" , "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] arm: ls1021a: utilize hrtimer based broadcast mode Thread-Topic: [PATCH] arm: ls1021a: utilize hrtimer based broadcast mode Thread-Index: AQHQuvT0+gWhNMYAHE6te79rXQtu6J3UzFCAgAX0MWA= Date: Tue, 14 Jul 2015 09:57:51 +0000 Message-ID: References: <1436521145-21055-1-git-send-email-b18965@freescale.com> <20150710150009.GD6564@leverpostej> In-Reply-To: <20150710150009.GD6564@leverpostej> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none; x-originating-ip: [192.158.241.86] x-microsoft-exchange-diagnostics: 1;BN3PR0301MB0867;5:tk0rLe3PrE9Adkpb0jzC1iGw0WZMDLb1kAqbq2JiRu548llICDbWNZ31r6rMl4NDGPU3C/74RUn2v+sFouyz6loSIOTGr1VAAeEfUiIgwyPTRjXWZLgRGop9VbF0LK6novz9vRorfPqlhVRGASFSng==;24:6rYDvZqWDX/ukmC1VW7HnTkpPiBEEL6G5lGTpBef7ifSWXGbHtPijaS9lK4sGKsw57d0ymghEcChRTko2/RdnXojb8tPutCk0hYIjPkz4N0=;20:4tl+hFbUiI0R2QUNqgTDBmXv4NZgru3IXJ7UntozmFeKVD/UftCtVhcaLZfjs7Bzs6zhWotdzEV3wmFcIc2Ucg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB0867; bn3pr0301mb0867: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN3PR0301MB0867;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB0867; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(164054003)(24454002)(51704005)(1720100001)(87936001)(33656002)(40100003)(102836002)(99286002)(2950100001)(46102003)(106116001)(54356999)(50986999)(62966003)(77096005)(2656002)(76176999)(77156002)(74316001)(86362001)(15975445007)(19580405001)(5002640100001)(189998001)(110136002)(2900100001)(19580395003)(66066001)(5001960100002)(92566002)(5003600100002)(76576001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB0867;H:BN3PR0301MB0867.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2015 09:57:51.2828 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0867 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Mark, > On Fri, Jul 10, 2015 at 10:39:05AM +0100, Alison Wang wrote: > > Hrtimer based broadcast mode is used instead of periodic tick > > broadcast to provide high resolution clock in SMP. > > > > Signed-off-by: Alison Wang > > --- > > arch/arm/mach-imx/mach-ls1021a.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/mach-imx/mach-ls1021a.c > > b/arch/arm/mach-imx/mach-ls1021a.c > > index b89c858..1a1a115 100644 > > --- a/arch/arm/mach-imx/mach-ls1021a.c > > +++ b/arch/arm/mach-imx/mach-ls1021a.c > > @@ -8,9 +8,19 @@ > > */ > > > > #include > > +#include > > +#include > > +#include > > > > #include "common.h" > > > > +static void __init ls1021a_init_time(void) { > > + of_clk_init(NULL); > > + clocksource_of_init(); > > + tick_setup_hrtimer_broadcast(); > > +} > > It would be nicer to place this in the arch time_init() function, as > already happens for arm64 and powerpc. That way everyone can benefit. [Alison Wang] Yes, I think so. Thanks. > > Thanks, > Mark. > > > + > > static const char * const ls1021a_dt_compat[] __initconst = { > > "fsl,ls1021a", > > NULL, > > @@ -18,5 +28,6 @@ static const char * const ls1021a_dt_compat[] > > __initconst = { > > > > DT_MACHINE_START(LS1021A, "Freescale LS1021A") > > .smp = smp_ops(ls1021a_smp_ops), > > + .init_time = ls1021a_init_time, > > .dt_compat = ls1021a_dt_compat, > > MACHINE_END > > -- > > 2.1.0.27.g96db324 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >