From: Long Li <longli@microsoft.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Subject: RE: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart
Date: Thu, 13 Apr 2017 23:12:09 +0000 [thread overview]
Message-ID: <BN3PR03MB2227E7A0189829B68BE83DBFCE020@BN3PR03MB2227.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1491868058.4199.28.camel@sandisk.com>
> -----Original Message-----
> From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> Sent: Monday, April 10, 2017 4:48 PM
> To: linux-kernel@vger.kernel.org; linux-block@vger.kernel.org; KY Srinivasan
> <kys@microsoft.com>; Long Li <longli@microsoft.com>; axboe@kernel.dk
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH] block-mq: set both block queue and hardware queue
> restart bit for restart
>
> On Thu, 2017-04-06 at 04:21 +0000, KY Srinivasan wrote:
> > > -----Original Message-----
> > > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> > > Sent: Wednesday, April 5, 2017 8:46 PM
> > > To: linux-kernel@vger.kernel.org; linux-block@vger.kernel.org; Long
> > > Li <longli@microsoft.com>; axboe@kernel.dk
> > > Cc: Stephen Hemminger <sthemmin@microsoft.com>; KY Srinivasan
> > > <kys@microsoft.com>
> > > Subject: Re: [PATCH] block-mq: set both block queue and hardware
> > > queue restart bit for restart
> > >
> > > On Thu, 2017-04-06 at 03:38 +0000, Long Li wrote:
> > > > > -----Original Message-----
> > > > > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> > > > >
> > > > > Please drop this patch. I'm working on a better solution.
> > > >
> > > > Thank you. Looking forward to your patch.
> > >
> > > Hello Long,
> > >
> > > It would help if you could share the name of the block or SCSI
> > > driver with which you ran into that lockup and also if you could
> > > share the name of the I/O scheduler used in your test.
> >
> > The tests that indicated the issue were run Hyper-V. The driver is
> > storvsc_drv.c The I/O scheduler was I think noop.
>
> Hello Long and K.Y.,
>
> Thank you for the feedback. Can you repeat your test with kernel v4.11-rc6?
> The patches that went into the block layer for v4.11-rc6 should be sufficient
> to fix
> this:
>
> $ PAGER= git log --format=short v4.11-rc5..v4.11-rc6 block include/linux/blk*
> commit 6d8c6c0f97ad8a3517c42b179c1dc8e77397d0e2
> Author: Bart Van Assche <bart.vanassche@sandisk.com>
>
> blk-mq: Restart a single queue if tag sets are shared
>
> commit 7587a5ae7eef0439f7be31f1b5959af062bbc5ec
> Author: Bart Van Assche <bart.vanassche@sandisk.com>
>
> blk-mq: Introduce blk_mq_delay_run_hw_queue()
>
> commit ebe8bddb6e30d7a02775b9972099271fc5910f37
> Author: Omar Sandoval <osandov@fb.com>
>
> blk-mq: remap queues when adding/removing hardware queues
>
> commit 54d5329d425650fafaf90660a139c771d2d49cae
> Author: Omar Sandoval <osandov@fb.com>
>
> blk-mq-sched: fix crash in switch error path
>
> commit 93252632e828da3e90241a1c0e766556abf71598
> Author: Omar Sandoval <osandov@fb.com>
>
> blk-mq-sched: set up scheduler tags when bringing up new queues
>
> commit 6917ff0b5bd4139e08a3f3146529dcb3b95ba7a6
> Author: Omar Sandoval <osandov@fb.com>
>
> blk-mq-sched: refactor scheduler initialization
>
> commit 81380ca10778b99dce98940cfc993214712df335
> Author: Omar Sandoval <osandov@fb.com>
>
> blk-mq: use the right hctx when getting a driver tag fails
>
> commit ac77a0c463c1d7d659861f7b6d1261970dd3282a
> Author: Minchan Kim <minchan@kernel.org>
>
> block: do not put mq context in blk_mq_alloc_request_hctx
>
> Bart.
Thank you. We are doing tests. I will update on the results.
Long
next prev parent reply other threads:[~2017-04-13 23:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 0:16 [PATCH] block-mq: set both block queue and hardware queue restart bit for restart Long Li
2017-04-06 0:32 ` Bart Van Assche
2017-04-06 3:38 ` Long Li
2017-04-06 3:45 ` Bart Van Assche
2017-04-06 4:21 ` KY Srinivasan
2017-04-06 5:38 ` Long Li
2017-04-10 23:47 ` Bart Van Assche
2017-04-13 23:12 ` Long Li [this message]
2017-05-05 8:58 ` Long Li
2017-05-05 19:52 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN3PR03MB2227E7A0189829B68BE83DBFCE020@BN3PR03MB2227.namprd03.prod.outlook.com \
--to=longli@microsoft.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=kys@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).