From: "Zhang, Jerry" <Jerry.Zhang@amd.com>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>,
David Airlie <airlied@linux.ie>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Zhou, Jammy" <Jammy.Zhou@amd.com>,
Dave Airlie <airlied@redhat.com>,
"StDenis, Tom" <Tom.StDenis@amd.com>,
"Yang, Young" <Young.Yang@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable
Date: Wed, 18 May 2016 00:17:10 +0000 [thread overview]
Message-ID: <BN3PR1201MB0961B7E781D1BF1C24571E9FFF490@BN3PR1201MB0961.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1463478175-6356-5-git-send-email-falakreyaz@gmail.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
Regards,
Jerry (Junwei Zhang)
SRDC SW Development
AMD Shanghai
_____________________________________
> -----Original Message-----
> From: Muhammad Falak R Wani [mailto:falakreyaz@gmail.com]
> Sent: Tuesday, May 17, 2016 5:43 PM
> To: David Airlie
> Cc: Deucher, Alexander; Koenig, Christian; Zhou, Jammy; Dave Airlie; StDenis,
> Tom; Yang, Young; Zhang, Jerry; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable
>
> Remove unused variable 'ret', and directly return 0.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> index 55cdab8..cba951a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> @@ -99,7 +99,6 @@ static void tonga_ih_disable_interrupts(struct
> amdgpu_device *adev)
> */
> static int tonga_ih_irq_init(struct amdgpu_device *adev) {
> - int ret = 0;
> int rb_bufsz;
> u32 interrupt_cntl, ih_rb_cntl, ih_doorbell_rtpr;
> u64 wptr_off;
> @@ -165,7 +164,7 @@ static int tonga_ih_irq_init(struct amdgpu_device *adev)
> /* enable interrupts */
> tonga_ih_enable_interrupts(adev);
>
> - return ret;
> + return 0;
> }
>
> /**
> --
> 1.9.1
next prev parent reply other threads:[~2016-05-18 0:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 9:42 [PATCH 1/5] drm/amd/amdgpu : Remove unused variable Muhammad Falak R Wani
2016-05-17 9:42 ` [PATCH 2/5] drm/amd/amdgpu/cz_dpm: " Muhammad Falak R Wani
2016-05-17 9:42 ` [PATCH 3/5] drm/amd/amdgpu : " Muhammad Falak R Wani
2016-05-17 9:42 ` [PATCH 4/5] " Muhammad Falak R Wani
2016-05-17 9:42 ` [PATCH 5/5] " Muhammad Falak R Wani
2016-05-18 0:17 ` Zhang, Jerry [this message]
2016-05-17 20:37 ` [PATCH 1/5] " Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN3PR1201MB0961B7E781D1BF1C24571E9FFF490@BN3PR1201MB0961.namprd12.prod.outlook.com \
--to=jerry.zhang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Jammy.Zhou@amd.com \
--cc=Tom.StDenis@amd.com \
--cc=Young.Yang@amd.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=falakreyaz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).