From: <Woojung.Huh@microchip.com>
To: <f.fainelli@gmail.com>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <UNGLinuxDriver@microchip.com>,
<steve.glendinning@shawell.net>, <keescook@chromium.org>,
<akurz@blala.de>, <hayeswang@realtek.com>,
<kai.heng.feng@canonical.com>, <grundler@chromium.org>,
<zhongjiang@huawei.com>, <bigeasy@linutronix.de>,
<ran.wang_1@nxp.com>, <edumazet@google.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes
Date: Tue, 25 Sep 2018 22:32:24 +0000 [thread overview]
Message-ID: <BN6PR1101MB213010C5A5C888C539A9938EE7160@BN6PR1101MB2130.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8de18c23-d846-cbb4-c852-9b7d97a95c11@gmail.com>
Hi Florian,
> @@ -1401,19 +1401,10 @@ static int lan78xx_set_wol(struct net_device
...
> + if (pdata->wol & ~WAKE_ALL)
> + return -EINVAL;
If I understand correctly, it needs to check againt "wol->wolopts" than pdata->wol.
> +
> + pdata->wol = wol->wolopts;
Thanks.
Woojung
next prev parent reply other threads:[~2018-09-25 22:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 20:54 [PATCH net 0/7] net: usb: Check for Wake-on-LAN modes Florian Fainelli
2018-09-24 20:54 ` [PATCH net 1/7] asix: Check for supported " Florian Fainelli
2018-09-24 20:54 ` [PATCH net 2/7] ax88179_178a: " Florian Fainelli
2018-09-24 20:54 ` [PATCH net 3/7] lan78xx: " Florian Fainelli
2018-09-25 17:19 ` Woojung.Huh
2018-09-25 17:26 ` Florian Fainelli
2018-09-25 17:32 ` Woojung.Huh
2018-09-25 18:35 ` Florian Fainelli
2018-09-25 22:32 ` Woojung.Huh [this message]
2018-09-24 20:54 ` [PATCH net 4/7] sr9800: " Florian Fainelli
2018-09-24 20:54 ` [PATCH net 5/7] r8152: Check for supported Wake-on-LAN Modes Florian Fainelli
2018-09-24 20:54 ` [PATCH net 6/7] smsc75xx: Check for Wake-on-LAN modes Florian Fainelli
2018-09-24 20:54 ` [PATCH net 7/7] smsc95xx: " Florian Fainelli
2018-09-27 0:12 ` [PATCH net 0/7] net: usb: " David Miller
2018-09-27 0:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR1101MB213010C5A5C888C539A9938EE7160@BN6PR1101MB2130.namprd11.prod.outlook.com \
--to=woojung.huh@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=akurz@blala.de \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=kai.heng.feng@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ran.wang_1@nxp.com \
--cc=steve.glendinning@shawell.net \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).