RE: [PATCH] net: lan78xx: fix "enabled interrupts" warninig

[<RaghuramChary.Jallipalli@microchip.com>]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

> I believe this is another bug in lan78xx driver: after phy_disconnect() if
> there's intr urb coming, we will call phy_mac_interrupt, so trigger
> phy_state_machine(), but now the phydev->attached_dev is NULL, so NULL
> pointer deference. Can you please try below patch:
> 
Thanks Jisheng.
I still see the call trace even with updated patch. Log attached.

Thanks. 

[-- Attachment #2: log7800_updated_patch --]
[-- Type: application/octet-stream, Size: 18247 bytes --]

raghu@raghu:~$ sudo dmesg 
[ 1423.187994] usbcore: deregistering interface driver lan78xx
[ 1423.187998] bus: 'usb': remove driver lan78xx
[ 1423.190060] PM: Removing info for No Bus:enx00800f780000
[ 1423.238693] bus: 'mdio_bus': remove device usb-002:002:01
[ 1423.238708] PM: Removing info for mdio_bus:usb-002:002:01
[ 1423.238717] PM: Removing info for No Bus:usb-002:002
[ 1423.239009] driver: 'lan78xx': driver_release
[ 1433.729159] lan78xx: module verification failed: signature and/or required key missing - tainting kernel
[ 1433.729979] bus: 'usb': add driver lan78xx
[ 1433.729984] bus: 'usb': driver_probe_device: matched device 2-1:1.0 with driver lan78xx
[ 1433.729985] bus: 'usb': really_probe: probing driver lan78xx with device 2-1:1.0
[ 1433.729988] lan78xx 2-1:1.0: no default pinctrl state
[ 1434.013659] device: 'usb-002:002': device_add
[ 1434.013668] PM: Adding info for No Bus:usb-002:002
[ 1434.014615] device: 'usb-002:002:01': device_add
[ 1434.014619] bus: 'mdio_bus': add device usb-002:002:01
[ 1434.014625] PM: Adding info for mdio_bus:usb-002:002:01
[ 1434.014633] bus: 'mdio_bus': driver_probe_device: matched device usb-002:002:01 with driver Microchip LAN88xx
[ 1434.014634] bus: 'mdio_bus': really_probe: probing driver Microchip LAN88xx with device usb-002:002:01
[ 1434.014636] Microchip LAN88xx usb-002:002:01: no default pinctrl state
[ 1434.016151] driver: 'Microchip LAN88xx': driver_bound: bound to device 'usb-002:002:01'
[ 1434.016162] bus: 'mdio_bus': really_probe: bound device usb-002:002:01 to driver Microchip LAN88xx
[ 1434.016164] libphy: lan78xx-mdiobus: probed
[ 1434.016187] device: 'eth0': device_add
[ 1434.016211] PM: Adding info for No Bus:eth0
[ 1434.053899] driver: 'lan78xx': driver_bound: bound to device '2-1:1.0'
[ 1434.053939] bus: 'usb': really_probe: bound device 2-1:1.0 to driver lan78xx
[ 1434.053968] usbcore: registered new interface driver lan78xx
[ 1434.055060] lan78xx 2-1:1.0 enx00800f780000: renamed from eth0
[ 1434.055065] net eth0: renaming to enx00800f780000
[ 1434.105190] ####### Raghu ######## link status 
[ 1436.195450] ####### Raghu ######## link status 
[ 1436.195471] IPv6: ADDRCONF(NETDEV_CHANGE): enx00800f780000: link becomes ready
[ 1489.667838] usbcore: deregistering interface driver lan78xx
[ 1489.667843] bus: 'usb': remove driver lan78xx
[ 1489.668416] ####### Raghu ######## link status 
[ 1489.669584] PM: Removing info for No Bus:enx00800f780000
[ 1489.706798] bus: 'mdio_bus': remove device usb-002:002:01
[ 1489.706834] PM: Removing info for mdio_bus:usb-002:002:01
[ 1489.706858] PM: Removing info for No Bus:usb-002:002
[ 1489.707595] driver: 'lan78xx': driver_release
[ 1489.759604] bus: 'usb': add driver lan78xx
[ 1489.759611] bus: 'usb': driver_probe_device: matched device 2-1:1.0 with driver lan78xx
[ 1489.759613] bus: 'usb': really_probe: probing driver lan78xx with device 2-1:1.0
[ 1489.759616] lan78xx 2-1:1.0: no default pinctrl state
[ 1490.043314] device: 'usb-002:002': device_add
[ 1490.043323] PM: Adding info for No Bus:usb-002:002
[ 1490.044410] device: 'usb-002:002:01': device_add
[ 1490.044427] bus: 'mdio_bus': add device usb-002:002:01
[ 1490.044432] PM: Adding info for mdio_bus:usb-002:002:01
[ 1490.044440] bus: 'mdio_bus': driver_probe_device: matched device usb-002:002:01 with driver Microchip LAN88xx
[ 1490.044441] bus: 'mdio_bus': really_probe: probing driver Microchip LAN88xx with device usb-002:002:01
[ 1490.044443] Microchip LAN88xx usb-002:002:01: no default pinctrl state
[ 1490.045728] driver: 'Microchip LAN88xx': driver_bound: bound to device 'usb-002:002:01'
[ 1490.045737] bus: 'mdio_bus': really_probe: bound device usb-002:002:01 to driver Microchip LAN88xx
[ 1490.045738] libphy: lan78xx-mdiobus: probed
[ 1490.045747] device: 'eth0': device_add
[ 1490.045768] PM: Adding info for No Bus:eth0
[ 1490.082815] driver: 'lan78xx': driver_bound: bound to device '2-1:1.0'
[ 1490.082858] bus: 'usb': really_probe: bound device 2-1:1.0 to driver lan78xx
[ 1490.082884] usbcore: registered new interface driver lan78xx
[ 1490.083916] lan78xx 2-1:1.0 enx00800f780000: renamed from eth0
[ 1490.083921] net eth0: renaming to enx00800f780000
[ 1490.119485] usbcore: deregistering interface driver lan78xx
[ 1490.119501] bus: 'usb': remove driver lan78xx
[ 1490.121484] PM: Removing info for No Bus:enx00800f780000
[ 1490.163013] bus: 'mdio_bus': remove device usb-002:002:01
[ 1490.163066] PM: Removing info for mdio_bus:usb-002:002:01
[ 1490.163102] PM: Removing info for No Bus:usb-002:002
[ 1490.163972] driver: 'lan78xx': driver_release
[ 1490.209265] bus: 'usb': add driver lan78xx
[ 1490.209281] bus: 'usb': driver_probe_device: matched device 2-1:1.0 with driver lan78xx
[ 1490.209285] bus: 'usb': really_probe: probing driver lan78xx with device 2-1:1.0
[ 1490.209291] lan78xx 2-1:1.0: no default pinctrl state
[ 1490.492647] device: 'usb-002:002': device_add
[ 1490.492657] PM: Adding info for No Bus:usb-002:002
[ 1490.493773] device: 'usb-002:002:01': device_add
[ 1490.493776] bus: 'mdio_bus': add device usb-002:002:01
[ 1490.493795] PM: Adding info for mdio_bus:usb-002:002:01
[ 1490.493815] bus: 'mdio_bus': driver_probe_device: matched device usb-002:002:01 with driver Microchip LAN88xx
[ 1490.493817] bus: 'mdio_bus': really_probe: probing driver Microchip LAN88xx with device usb-002:002:01
[ 1490.493819] Microchip LAN88xx usb-002:002:01: no default pinctrl state
[ 1490.495139] driver: 'Microchip LAN88xx': driver_bound: bound to device 'usb-002:002:01'
[ 1490.495148] bus: 'mdio_bus': really_probe: bound device usb-002:002:01 to driver Microchip LAN88xx
[ 1490.495150] libphy: lan78xx-mdiobus: probed
[ 1490.495159] device: 'eth0': device_add
[ 1490.495186] PM: Adding info for No Bus:eth0
[ 1490.531636] driver: 'lan78xx': driver_bound: bound to device '2-1:1.0'
[ 1490.531682] bus: 'usb': really_probe: bound device 2-1:1.0 to driver lan78xx
[ 1490.531725] usbcore: registered new interface driver lan78xx
[ 1490.532625] lan78xx 2-1:1.0 enx00800f780000: renamed from eth0
[ 1490.532630] net eth0: renaming to enx00800f780000
[ 1490.566942] usbcore: deregistering interface driver lan78xx
[ 1490.566955] bus: 'usb': remove driver lan78xx
[ 1490.569041] PM: Removing info for No Bus:enx00800f780000
[ 1490.619056] bus: 'mdio_bus': remove device usb-002:002:01
[ 1490.619108] PM: Removing info for mdio_bus:usb-002:002:01
[ 1490.619145] PM: Removing info for No Bus:usb-002:002
[ 1490.619947] driver: 'lan78xx': driver_release
[ 1490.666112] bus: 'usb': add driver lan78xx
[ 1490.666128] bus: 'usb': driver_probe_device: matched device 2-1:1.0 with driver lan78xx
[ 1490.666132] bus: 'usb': really_probe: probing driver lan78xx with device 2-1:1.0
[ 1490.666138] lan78xx 2-1:1.0: no default pinctrl state
[ 1490.950111] device: 'usb-002:002': device_add
[ 1490.950120] PM: Adding info for No Bus:usb-002:002
[ 1490.951329] device: 'usb-002:002:01': device_add
[ 1490.951333] bus: 'mdio_bus': add device usb-002:002:01
[ 1490.951353] PM: Adding info for mdio_bus:usb-002:002:01
[ 1490.951361] bus: 'mdio_bus': driver_probe_device: matched device usb-002:002:01 with driver Microchip LAN88xx
[ 1490.951362] bus: 'mdio_bus': really_probe: probing driver Microchip LAN88xx with device usb-002:002:01
[ 1490.951365] Microchip LAN88xx usb-002:002:01: no default pinctrl state
[ 1490.952702] driver: 'Microchip LAN88xx': driver_bound: bound to device 'usb-002:002:01'
[ 1490.952711] bus: 'mdio_bus': really_probe: bound device usb-002:002:01 to driver Microchip LAN88xx
[ 1490.952713] libphy: lan78xx-mdiobus: probed
[ 1490.952723] device: 'eth0': device_add
[ 1490.952749] PM: Adding info for No Bus:eth0
[ 1490.990128] driver: 'lan78xx': driver_bound: bound to device '2-1:1.0'
[ 1490.990168] bus: 'usb': really_probe: bound device 2-1:1.0 to driver lan78xx
[ 1490.990202] usbcore: registered new interface driver lan78xx
[ 1490.991015] lan78xx 2-1:1.0 enx00800f780000: renamed from eth0
[ 1490.991019] net eth0: renaming to enx00800f780000
[ 1491.020659] usbcore: deregistering interface driver lan78xx
[ 1491.020669] bus: 'usb': remove driver lan78xx
[ 1491.021688] PM: Removing info for No Bus:enx00800f780000
[ 1491.058773] bus: 'mdio_bus': remove device usb-002:002:01
[ 1491.058802] PM: Removing info for mdio_bus:usb-002:002:01
[ 1491.058826] PM: Removing info for No Bus:usb-002:002
[ 1491.059534] driver: 'lan78xx': driver_release
[ 1491.106696] bus: 'usb': add driver lan78xx
[ 1491.106709] bus: 'usb': driver_probe_device: matched device 2-1:1.0 with driver lan78xx
[ 1491.106712] bus: 'usb': really_probe: probing driver lan78xx with device 2-1:1.0
[ 1491.106717] lan78xx 2-1:1.0: no default pinctrl state
[ 1491.390738] device: 'usb-002:002': device_add
[ 1491.390747] PM: Adding info for No Bus:usb-002:002
[ 1491.391805] device: 'usb-002:002:01': device_add
[ 1491.391808] bus: 'mdio_bus': add device usb-002:002:01
[ 1491.391830] PM: Adding info for mdio_bus:usb-002:002:01
[ 1491.391837] bus: 'mdio_bus': driver_probe_device: matched device usb-002:002:01 with driver Microchip LAN88xx
[ 1491.391838] bus: 'mdio_bus': really_probe: probing driver Microchip LAN88xx with device usb-002:002:01
[ 1491.391841] Microchip LAN88xx usb-002:002:01: no default pinctrl state
[ 1491.393157] driver: 'Microchip LAN88xx': driver_bound: bound to device 'usb-002:002:01'
[ 1491.393166] bus: 'mdio_bus': really_probe: bound device usb-002:002:01 to driver Microchip LAN88xx
[ 1491.393168] libphy: lan78xx-mdiobus: probed
[ 1491.393177] device: 'eth0': device_add
[ 1491.393205] PM: Adding info for No Bus:eth0
[ 1491.431690] driver: 'lan78xx': driver_bound: bound to device '2-1:1.0'
[ 1491.431709] bus: 'usb': really_probe: bound device 2-1:1.0 to driver lan78xx
[ 1491.431720] usbcore: registered new interface driver lan78xx
[ 1491.432218] lan78xx 2-1:1.0 enx00800f780000: renamed from eth0
[ 1491.432220] net eth0: renaming to enx00800f780000
[ 1491.465433] usbcore: deregistering interface driver lan78xx
[ 1491.465440] bus: 'usb': remove driver lan78xx
[ 1491.466947] PM: Removing info for No Bus:enx00800f780000
[ 1491.502882] bus: 'mdio_bus': remove device usb-002:002:01
[ 1491.502925] PM: Removing info for mdio_bus:usb-002:002:01
[ 1491.502957] PM: Removing info for No Bus:usb-002:002
[ 1491.503594] driver: 'lan78xx': driver_release
[ 1491.551869] bus: 'usb': add driver lan78xx
[ 1491.551885] bus: 'usb': driver_probe_device: matched device 2-1:1.0 with driver lan78xx
[ 1491.551889] bus: 'usb': really_probe: probing driver lan78xx with device 2-1:1.0
[ 1491.551894] lan78xx 2-1:1.0: no default pinctrl state
[ 1491.835714] device: 'usb-002:002': device_add
[ 1491.835724] PM: Adding info for No Bus:usb-002:002
[ 1491.836867] device: 'usb-002:002:01': device_add
[ 1491.836872] bus: 'mdio_bus': add device usb-002:002:01
[ 1491.836893] PM: Adding info for mdio_bus:usb-002:002:01
[ 1491.836902] bus: 'mdio_bus': driver_probe_device: matched device usb-002:002:01 with driver Microchip LAN88xx
[ 1491.836920] bus: 'mdio_bus': really_probe: probing driver Microchip LAN88xx with device usb-002:002:01
[ 1491.836922] Microchip LAN88xx usb-002:002:01: no default pinctrl state
[ 1491.838482] driver: 'Microchip LAN88xx': driver_bound: bound to device 'usb-002:002:01'
[ 1491.838490] bus: 'mdio_bus': really_probe: bound device usb-002:002:01 to driver Microchip LAN88xx
[ 1491.838491] libphy: lan78xx-mdiobus: probed
[ 1491.838500] device: 'eth0': device_add
[ 1491.838522] PM: Adding info for No Bus:eth0
[ 1491.875716] driver: 'lan78xx': driver_bound: bound to device '2-1:1.0'
[ 1491.875759] bus: 'usb': really_probe: bound device 2-1:1.0 to driver lan78xx
[ 1491.875791] usbcore: registered new interface driver lan78xx
[ 1491.876758] lan78xx 2-1:1.0 enx00800f780000: renamed from eth0
[ 1491.876762] net eth0: renaming to enx00800f780000
[ 1491.918379] usbcore: deregistering interface driver lan78xx
[ 1491.918392] bus: 'usb': remove driver lan78xx
[ 1491.920484] PM: Removing info for No Bus:enx00800f780000
[ 1491.950795] bus: 'mdio_bus': remove device usb-002:002:01
[ 1491.950834] PM: Removing info for mdio_bus:usb-002:002:01
[ 1491.950862] PM: Removing info for No Bus:usb-002:002
[ 1491.951280] driver: 'lan78xx': driver_release
[ 1491.999706] bus: 'usb': add driver lan78xx
[ 1491.999721] bus: 'usb': driver_probe_device: matched device 2-1:1.0 with driver lan78xx
[ 1491.999725] bus: 'usb': really_probe: probing driver lan78xx with device 2-1:1.0
[ 1491.999731] lan78xx 2-1:1.0: no default pinctrl state
[ 1492.283507] device: 'usb-002:002': device_add
[ 1492.283516] PM: Adding info for No Bus:usb-002:002
[ 1492.284531] device: 'usb-002:002:01': device_add
[ 1492.284534] bus: 'mdio_bus': add device usb-002:002:01
[ 1492.284539] PM: Adding info for mdio_bus:usb-002:002:01
[ 1492.284546] bus: 'mdio_bus': driver_probe_device: matched device usb-002:002:01 with driver Microchip LAN88xx
[ 1492.284547] bus: 'mdio_bus': really_probe: probing driver Microchip LAN88xx with device usb-002:002:01
[ 1492.284549] Microchip LAN88xx usb-002:002:01: no default pinctrl state
[ 1492.285928] driver: 'Microchip LAN88xx': driver_bound: bound to device 'usb-002:002:01'
[ 1492.285937] bus: 'mdio_bus': really_probe: bound device usb-002:002:01 to driver Microchip LAN88xx
[ 1492.285938] libphy: lan78xx-mdiobus: probed
[ 1492.285947] device: 'eth0': device_add
[ 1492.285968] PM: Adding info for No Bus:eth0
[ 1492.322860] driver: 'lan78xx': driver_bound: bound to device '2-1:1.0'
[ 1492.322903] bus: 'usb': really_probe: bound device 2-1:1.0 to driver lan78xx
[ 1492.322932] usbcore: registered new interface driver lan78xx
[ 1492.324073] lan78xx 2-1:1.0 enx00800f780000: renamed from eth0
[ 1492.324078] net eth0: renaming to enx00800f780000
[ 1492.359594] usbcore: deregistering interface driver lan78xx
[ 1492.359607] bus: 'usb': remove driver lan78xx
[ 1492.362974] PM: Removing info for No Bus:enx00800f780000
[ 1492.364088] BUG: unable to handle kernel NULL pointer dereference at 0000000000000048
[ 1492.364097] #PF error: [WRITE]
[ 1492.364102] PGD 80000007e2ba4067 P4D 80000007e2ba4067 PUD 836bb6067 PMD 0 
[ 1492.364114] Oops: 0002 [#1] SMP PTI
[ 1492.364122] CPU: 4 PID: 8319 Comm: kworker/u16:0 Tainted: G            E     5.1.0-rc4+ #1
[ 1492.364127] Hardware name: Dell Inc. OptiPlex 7050/0D24M8, BIOS 1.7.9 01/30/2018
[ 1492.364138] Workqueue: events_power_efficient phy_state_machine
[ 1492.364150] RIP: 0010:netif_carrier_off+0x5/0x30
[ 1492.364157] Code: 5b 5d 41 5c 41 5d c3 48 c7 00 00 00 00 00 5b 5d 41 5c 41 5d e9 bc 65 89 ff 66 90 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 <f0> 48 0f ba 6f 48 02 72 09 80 bf d0 04 00 00 00 75 02 f3 c3 f0 ff
[ 1492.364163] RSP: 0018:ffffa5ee5649fdf8 EFLAGS: 00010246
[ 1492.364170] RAX: 0000000000000000 RBX: ffff902fe31e7000 RCX: ffffffffbc0df230
[ 1492.364174] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000000000000000
[ 1492.364179] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
[ 1492.364183] R10: 0000000000000001 R11: 0000000000000001 R12: ffff902fe31e7420
[ 1492.364188] R13: ffff902fe31e7000 R14: ffff902fe0c82840 R15: 0ffff90303d45640
[ 1492.364194] FS:  0000000000000000(0000) GS:ffff90303db00000(0000) knlGS:0000000000000000
[ 1492.364200] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1492.364205] CR2: 0000000000000048 CR3: 00000007e1db4001 CR4: 00000000003606e0
[ 1492.364210] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1492.364215] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 1492.364218] Call Trace:
[ 1492.364230]  phy_link_change+0x22/0x50
[ 1492.364239]  phy_check_link_status+0x8a/0xe0
[ 1492.364246]  phy_start_aneg+0xe2/0x120
[ 1492.364253]  phy_state_machine+0x81/0x230
[ 1492.364263]  process_one_work+0x15e/0x3f0
[ 1492.364272]  worker_thread+0x4c/0x440
[ 1492.364281]  ? rescuer_thread+0x350/0x350
[ 1492.364288]  kthread+0xf8/0x130
[ 1492.364295]  ? kthread_destroy_worker+0x40/0x40
[ 1492.364303]  ret_from_fork+0x35/0x40
[ 1492.364310] Modules linked in: lan78xx(E-) microchip snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio kvm snd_hda_intel snd_hda_codec snd_hda_core irqbypass input_leds snd_hwdep snd_pcm crct10dif_pclmul snd_seq_midi crc32_pclmul snd_seq_midi_event ghash_clmulni_intel aesni_intel snd_rawmidi aes_x86_64 snd_seq crypto_simd i2c_designware_platform cryptd glue_helper snd_seq_device i2c_designware_core snd_timer intel_cstate snd intel_rapl_perf soundcore dell_wmi idma64 dell_smbios serio_raw virt_dma dell_wmi_aio dcdbas mei_me sparse_keymap intel_lpss_pci mei mac_hid dell_wmi_descriptor wmi_bmof intel_lpss acpi_pad parport_pc ppdev sunrpc lp parport autofs4 i915 hid_generic usbhid hid i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm e1000e psmouse ahci ptp libahci pps_core wmi video [last unloaded: lan78xx]
[ 1492.364390] CR2: 0000000000000048
[ 1492.364397] ---[ end trace 69c97991895beef6 ]---
[ 1492.364406] RIP: 0010:netif_carrier_off+0x5/0x30
[ 1492.364411] Code: 5b 5d 41 5c 41 5d c3 48 c7 00 00 00 00 00 5b 5d 41 5c 41 5d e9 bc 65 89 ff 66 90 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 <f0> 48 0f ba 6f 48 02 72 09 80 bf d0 04 00 00 00 75 02 f3 c3 f0 ff
[ 1492.364417] RSP: 0018:ffffa5ee5649fdf8 EFLAGS: 00010246
[ 1492.364422] RAX: 0000000000000000 RBX: ffff902fe31e7000 RCX: ffffffffbc0df230
[ 1492.364426] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000000000000000
[ 1492.364430] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
[ 1492.364434] R10: 0000000000000001 R11: 0000000000000001 R12: ffff902fe31e7420
[ 1492.364439] R13: ffff902fe31e7000 R14: ffff902fe0c82840 R15: 0ffff90303d45640
[ 1492.364444] FS:  0000000000000000(0000) GS:ffff90303db00000(0000) knlGS:0000000000000000
[ 1492.364449] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1492.364454] CR2: 0000000000000048 CR3: 00000007e1db4001 CR4: 00000000003606e0
[ 1492.364458] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1492.364463] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 1492.398943] bus: 'mdio_bus': remove device usb-002:002:01
raghu@raghu:~$ 
raghu@raghu:~$ 
raghu@raghu:~$