From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbdDDOhi (ORCPT ); Tue, 4 Apr 2017 10:37:38 -0400 Received: from mail-sn1nam01on0045.outbound.protection.outlook.com ([104.47.32.45]:20000 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752129AbdDDOhg (ORCPT ); Tue, 4 Apr 2017 10:37:36 -0400 From: "Ghannam, Yazen" To: Borislav Petkov CC: "linux-edac@vger.kernel.org" , Tony Luck , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration Thread-Topic: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration Thread-Index: AQHSo0KoShwpVRxvPkaRQz/4bzH6yqGqquqAgAqd8jCAAAQUgIAADFpw Date: Tue, 4 Apr 2017 14:37:34 +0000 Message-ID: References: <1490210971-62346-1-git-send-email-Yazen.Ghannam@amd.com> <1490210971-62346-2-git-send-email-Yazen.Ghannam@amd.com> <20170328192303.a732usin3tq6els3@pd.tnic> <20170404134533.ohpdleaczenyilal@pd.tnic> In-Reply-To: <20170404134533.ohpdleaczenyilal@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.84.17] x-microsoft-exchange-diagnostics: 1;BN6PR1201MB0130;7:zw6W9WEBPIujFdS8x5ndNAR6pfsRGiDNGQ9p2N0DuG73YY/WOYuQQMIubIaEU7bNb1RQZIHJZzvlecrYUqaFEiTCHoJloRTn/N4AIpbIBIfDwDawuZ52SyXtgJ0xgcFkbHxKefMp0i9O4UYjr8Y8EhGLka2WgIhGTjH5aU6aweoo3CRQgqX/XrmpAvxMtdgVTeMK4aeOlbAwBhVvJTfy1BVYiJo5OPCKcq5MwFjpYTWfd7nxmSWJT/wB+hoqRtDARuQ19FzobS+n3GPMihzzVgyMbgS3N8Q43EuPAgm/4GDdZ9Kk7+V7+vI2/U/VCl4JKEC+ZErxeTj9tstI+A4biw==;20:XuNrR4cStB5Ttio51sfdcF6s/Nfq/U/LW1jBYc3gOfd0pRCoM5o5Zv6sFqZs+p7eZmuaNV2yYlGGXV924lh/muzbvJajCJ82pscLFexQUPPkyh30iIRK8J+AbRf+2uki0+Tf0ih1HgBckiJ9zxrcQ6mjpIfF3tLrLEJEcNVkVymmgsQStmq41vWmAcHXSRsaPFFNtFS+Xjmgfljwhz0e2vUJCBwSJRqWVdQdQlCAbcMs3NORHLy02yyecAEevSCs x-ms-office365-filtering-correlation-id: 1776bba6-cb6d-401e-54d8-08d47b682216 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR1201MB0130; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(767451399110)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:BN6PR1201MB0130;BCL:0;PCL:0;RULEID:;SRVR:BN6PR1201MB0130; x-forefront-prvs: 0267E514F9 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(39450400003)(39840400002)(39400400002)(39850400002)(39410400002)(13464003)(24454002)(377454003)(6506006)(2906002)(9686003)(77096006)(53936002)(53546009)(6916009)(86362001)(6116002)(33656002)(8936002)(81166006)(8676002)(4326008)(5660300001)(50986999)(55016002)(3280700002)(93886004)(66066001)(122556002)(25786009)(76176999)(6436002)(54356999)(2950100002)(54906002)(102836003)(305945005)(7736002)(3660700001)(110136004)(38730400002)(15650500001)(7696004)(3846002)(74316002)(99286003)(189998001)(6246003)(2900100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR1201MB0130;H:BN6PR1201MB0131.namprd12.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2017 14:37:34.2674 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v34Ebh3Q029243 > -----Original Message----- > From: Borislav Petkov [mailto:bp@alien8.de] > Sent: Tuesday, April 04, 2017 9:46 AM > To: Ghannam, Yazen > Cc: linux-edac@vger.kernel.org; Tony Luck ; > x86@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration > > On Tue, Apr 04, 2017 at 01:34:42PM +0000, Ghannam, Yazen wrote: > > I'd like to keep the functions separate since they're logically > > independent. I can define something like smca_configure() as a wrapper > > function that can contain current and future SMCA related functions. Is this > okay? > > Are you planning to call the one and not the other in some path? No, not at the moment. This patch is just to help with readability. Thanks, Yazen