From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753362AbdDDNep (ORCPT ); Tue, 4 Apr 2017 09:34:45 -0400 Received: from mail-dm3nam03on0088.outbound.protection.outlook.com ([104.47.41.88]:11578 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750877AbdDDNeo (ORCPT ); Tue, 4 Apr 2017 09:34:44 -0400 From: "Ghannam, Yazen" To: Borislav Petkov CC: "linux-edac@vger.kernel.org" , Tony Luck , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration Thread-Topic: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration Thread-Index: AQHSo0KoShwpVRxvPkaRQz/4bzH6yqGqquqAgAqd8jA= Date: Tue, 4 Apr 2017 13:34:42 +0000 Message-ID: References: <1490210971-62346-1-git-send-email-Yazen.Ghannam@amd.com> <1490210971-62346-2-git-send-email-Yazen.Ghannam@amd.com> <20170328192303.a732usin3tq6els3@pd.tnic> In-Reply-To: <20170328192303.a732usin3tq6els3@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.84.17] x-microsoft-exchange-diagnostics: 1;BN6PR1201MB0129;7:L0Ard3MHzEiJuqx0zQmLExMPhzYPkH/tEjsA/RV3khLnHH5rKP2ZgssPozU9LFEOo1aVpKZDQ8rRBKb/CVWkTayh9GAAoAuCM5EymYcRPAPBe8xdNxymjeQeKtpgxa1w78qfHosEsYukguJNq+SY4qH5G/UIJVMJcQrSYQsouPCvPfmjHYfQZ1GGeBwV3a6DXAqNxvWtgoedKF/XWckJI1XCeKjVZzRJ64uVcC/7NKUXpLrPBlwXjAkNYbRqLFQQFeqSwCKOHKeZooyxPydJT3E3ff8TT1iV5NCU1RJeq9SFrIB4EDMjxaq6GBgddQj41ctRtodMqkyIkhes7vXBkw==;20:+pq9LvxbOX/LklGNJoAa2/chainzxtkVVyf6AcVbdOMPPGXdch2dCxFVZ4AKE/nfDU80XgCWX9P9oITbMIX5R0/fZ0skv9g7KtX3jtiVT7BK7nz30B5KtqQuOul4aX1QOO17xb7ox6bgxLB2pEV9UNtY00Gufs3VZRblfNajHZ0m4ox8CVjUOOf4UUTSF22ETKazJmX54olXtAdam+kYO1aSXDIvXdt3DeDyq6a/n5dbCiqBPvsVbyLzzM2TeBLh x-ms-office365-filtering-correlation-id: 407cf600-4c6b-421b-5edb-08d47b5f59a3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR1201MB0129; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(767451399110)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:BN6PR1201MB0129;BCL:0;PCL:0;RULEID:;SRVR:BN6PR1201MB0129; x-forefront-prvs: 0267E514F9 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39850400002)(39860400002)(39450400003)(39400400002)(39840400002)(24454002)(377454003)(13464003)(54906002)(15650500001)(74316002)(8676002)(6506006)(8936002)(54356999)(7736002)(6246003)(3660700001)(3280700002)(81166006)(6116002)(229853002)(38730400002)(102836003)(305945005)(3846002)(86362001)(2900100001)(50986999)(53546009)(6436002)(33656002)(25786009)(6916009)(2950100002)(9686003)(5660300001)(2906002)(189998001)(99286003)(7696004)(122556002)(55016002)(4326008)(53936002)(77096006)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR1201MB0129;H:BN6PR1201MB0131.namprd12.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2017 13:34:42.0569 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0129 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v34DYsWX022933 > -----Original Message----- > From: Borislav Petkov [mailto:bp@suse.de] > Sent: Tuesday, March 28, 2017 3:23 PM > To: Ghannam, Yazen > Cc: linux-edac@vger.kernel.org; Tony Luck ; > x86@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration > > On Wed, Mar 22, 2017 at 02:29:31PM -0500, Yazen Ghannam wrote: > > From: Yazen Ghannam > > > > Scalable MCA systems have a new MCA_CONFIG register that we use to > > configure each bank. We currently use this when we set up thresholding. > > However, this is logically separate. > > > > Move setup of MCA_CONFIG into a separate function. > > > > Signed-off-by: Yazen Ghannam > > --- > > arch/x86/kernel/cpu/mcheck/mce_amd.c | 48 > > ++++++++++++++++++++---------------- > > 1 file changed, 27 insertions(+), 21 deletions(-) > > ... > > > /* cpu init entry point, called from mce.c with preempt off */ @@ > > -515,8 +519,10 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c) > > int offset = -1; > > > > for (bank = 0; bank < mca_cfg.banks; ++bank) { > > - if (mce_flags.smca) > > + if (mce_flags.smca) { > > get_smca_bank_info(bank); > > + set_smca_config(bank); > > Or simply bundle those two which do something SMCA-aware per bank into a > single: > > smca_configure(bank); > > which reads almost like a sentence. > I'd like to keep the functions separate since they're logically independent. I can define something like smca_configure() as a wrapper function that can contain current and future SMCA related functions. Is this okay? Thanks, Yazen