From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762216AbdEXM6e (ORCPT ); Wed, 24 May 2017 08:58:34 -0400 Received: from mail-by2nam01on0063.outbound.protection.outlook.com ([104.47.34.63]:32365 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1764211AbdEXM46 (ORCPT ); Wed, 24 May 2017 08:56:58 -0400 From: "Deucher, Alexander" To: "'Joerg Roedel'" CC: "'David Woodhouse'" , "'Joerg Roedel'" , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Daniel Drake , "Samuel Sieb" Subject: RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Thread-Topic: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Thread-Index: AQHSr6vHBMNtgiI4D0yTU57sgEnxvKG6HXRQgCoDoICAHntcoIAA2DoAgABGKlA= Date: Wed, 24 May 2017 12:56:49 +0000 Message-ID: References: <1491575538-22694-1-git-send-email-joro@8bytes.org> <1493893297.4904.71.camel@infradead.org> <20170524084450.GB12353@suse.de> In-Reply-To: <20170524084450.GB12353@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.55.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR12MB1650;7:pY5kmRuap9FJATPKo8YPq+ZAJ+gQ7azzdSjZrQbjSWonC5I4q/9KvIJbAnS524utQfGvOfa+zwyUCU4bWFKwqCHBVJKin3unzc5ZpRDrlLVj3xA3MV7gBuk4618/YZFKxb45u9ttiVnOzcnD3IX0tK6TywhiouwdpkFhWf8Q8vo0pU+5BXGzBLMyP19mE4I8NxPNyONoTxUjS7Ngit1G82N9m26DtxL9FQqBuS0oW7YAmcOuJ6W3X2lgSoEL2FMVArY106Bi0/z7MpMQqOQrIhUllwW8zyO5Vj1uWiDMTPtuyfucR9OJ0BQM8RnUhsnOlBHQhrKnXrGX6fxIqxgbHw==;20:1NXcgE7T2UfHKVMpDdWhA20tMisgdkgoljbjH6Jn4R/rAzO2lR8ZHz+AeijqcRt/C8MS3dauH2l4sRNrdjkJy3pxPJSSbjQZLXdHxYPggIaUxFqWsEUfMdDX1h03qcimY9W/AmJZ0GRQkaFEiHcc2Azuh+QekcsgLFrYNMiXK9TffvmJys/sh7SD1easPOvMEdKGuHviALV3Q2pCE8X2wxqSqiIwvwNcYlzCkRtIDSGCDDF2PoFJiItfGWZt3GJJ x-ms-traffictypediagnostic: BN6PR12MB1650: x-ms-office365-filtering-correlation-id: f7cededc-a210-4ccd-717e-08d4a2a457e0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR12MB1650; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148);SRVR:BN6PR12MB1650;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1650; x-forefront-prvs: 031763BCAF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39840400002)(39400400002)(39450400003)(39860400002)(39410400002)(24454002)(377454003)(13464003)(478600001)(72206003)(966005)(3846002)(74316002)(7696004)(3660700001)(102836003)(33656002)(6116002)(2906002)(3280700002)(7736002)(86362001)(305945005)(50986999)(8936002)(5660300001)(2900100001)(122556002)(54356999)(76176999)(66066001)(54906002)(53546009)(8676002)(81166006)(53936002)(25786009)(2950100002)(189998001)(6246003)(38730400002)(77096006)(6436002)(6916009)(99286003)(55016002)(4326008)(9686003)(6306002)(229853002)(6506006)(110136004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1650;H:BN6PR12MB1652.namprd12.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2017 12:56:49.6063 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1650 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4OD1JjI005411 > -----Original Message----- > From: Joerg Roedel [mailto:jroedel@suse.de] > Sent: Wednesday, May 24, 2017 4:45 AM > To: Deucher, Alexander > Cc: 'David Woodhouse'; 'Joerg Roedel'; Bjorn Helgaas; linux- > pci@vger.kernel.org; linux-kernel@vger.kernel.org; Daniel Drake; Samuel > Sieb > Subject: Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs > > Hi Alexander, > > On Tue, May 23, 2017 at 07:54:12PM +0000, Deucher, Alexander wrote: > > I finally got an answer from the hw team and we validated ATS on > > stoney as well so in theory this patch shouldn’t actually be needed. > > I think we may actually be papering over some other issue. The > > following patch seems to also fix this issue (and other issues): > > https://www.spinics.net/lists/stable/msg172631.html > > Yeah, but it still looks to me like that the hardware got into some > weird state with the storm of ATS invalidations sent to it. > > The Completion-Wait loop timeouts seen in the original bug report > indicate that the IOMMU is waiting for a response that never comes. And > this is probably the ATS flush completion response from the GPU, as > disabling ATS on the GPU makes the issue disappear. Yeah, it's weird. My ack on the patch still stands. Just adding some additional data. Alex