From: <Kumaravel.Thiagarajan@microchip.com>
To: <arnd@arndb.de>, <sudipm.mukherjee@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-next@vger.kernel.org>
Subject: RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")
Date: Wed, 7 Sep 2022 12:40:11 +0000 [thread overview]
Message-ID: <BN8PR11MB366846DC380A755B64E870ADE9419@BN8PR11MB3668.namprd11.prod.outlook.com> (raw)
In-Reply-To: <77b0aa7b-3183-4a05-85ff-b278aa7f8f11@www.fastmail.com>
> -----Original Message-----
> From: Arnd Bergmann <arnd@arndb.de>
> Sent: Wednesday, September 7, 2022 2:12 PM
> To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>; Greg Kroah-
> Hartman <gregkh@linuxfoundation.org>
> Cc: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; open list:GPIO SUBSYSTEM
> <linux-gpio@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>;
> linux-next <linux-next@vger.kernel.org>
> Subject: Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip: pci1xxxx: Add power management functions - suspend & resume
> handlers.")
>
>
> On Tue, Sep 6, 2022, at 11:07 PM, Sudip Mukherjee wrote:
> > On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >> On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink)
> wrote:
> >> >
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> >> > 311 | static int pci1xxxx_gpio_resume(struct device *dev)
> >> > | ^~~~~~~~~~~~~~~~~~~~
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> >> > 295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> >> > | ^~~~~~~~~~~~~~~~~~~~~
> >> >
> >> >
> >> > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add
> power management functions - suspend & resume handlers.").
> >> >
> >
> > Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
> > pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
> > "#ifdef CONFIG_PM_SLEEP".
Thank you Sudip ! I will review this.
>
> That would work, but a better fix is to use DEFINE_SIMPLE_DEV_PM_OPS()
> in place of the deprecated SIMPLE_DEV_PM_OPS().
Thank you Arnd ! I will review this.
next prev parent reply other threads:[~2022-09-07 12:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 14:23 build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.") Sudip Mukherjee (Codethink)
2022-09-06 17:15 ` Greg Kroah-Hartman
2022-09-06 21:07 ` Sudip Mukherjee
2022-09-07 6:08 ` Greg Kroah-Hartman
2022-09-07 8:41 ` Arnd Bergmann
2022-09-07 12:40 ` Kumaravel.Thiagarajan [this message]
2022-09-09 15:12 ` Kumaravel.Thiagarajan
2022-09-09 17:51 ` Sudip Mukherjee
2022-09-12 11:48 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB366846DC380A755B64E870ADE9419@BN8PR11MB3668.namprd11.prod.outlook.com \
--to=kumaravel.thiagarajan@microchip.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).