From: "Wan Mohamad, Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>
To: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Cc: "kishon@ti.com" <kishon@ti.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>
Subject: RE: [RESEND v5 2/2] phy: intel: Add Keem Bay eMMC PHY support
Date: Fri, 19 Jun 2020 03:17:11 +0000 [thread overview]
Message-ID: <BN8PR11MB37143C5A4C98BF28C521B838DD980@BN8PR11MB3714.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200617140107.GF2428291@smile.fi.intel.com>
> -----Original Message-----
> From: Shevchenko, Andriy <andriy.shevchenko@intel.com>
> Sent: Wednesday, June 17, 2020 10:01 PM
> To: Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@intel.com>
> Cc: kishon@ti.com; vkoul@kernel.org; robh+dt@kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; Hunter, Adrian
> <adrian.hunter@intel.com>
> Subject: Re: [RESEND v5 2/2] phy: intel: Add Keem Bay eMMC PHY support
>
> On Wed, Jun 17, 2020 at 07:32:52AM +0800, Wan Ahmad Zainie wrote:
> > Add support for eMMC PHY on Intel Keem Bay SoC.
>
> ...
>
> > + ret = regmap_read_poll_timeout(priv->syscfg, PHY_STAT,
> > + dllrdy, IS_DLLRDY(dllrdy),
> > + 0, 50 * USEC_PER_MSEC);
> > + if (ret) {
> > + dev_err(&phy->dev, "dllrdy failed, ret=%d\n", ret);
> > + return ret;
> > + }
> > +
> > + return ret;
> > +}
>
> This has no changes.
>
> Are you sure the version is correct?
Ah. Sorry Andy. I misunderstood your earlier review comment.
You mean return inside the last if(...) should be discarded.
Kishon, should I send another version, or is it acceptable?
>
> --
> With Best Regards,
> Andy Shevchenko
>
prev parent reply other threads:[~2020-06-19 3:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 23:32 [RESEND v5 0/2] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-06-16 23:32 ` [RESEND v5 1/2] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings Wan Ahmad Zainie
2020-06-16 23:32 ` [RESEND v5 2/2] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-06-17 14:01 ` Andy Shevchenko
2020-06-19 3:17 ` Wan Mohamad, Wan Ahmad Zainie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB37143C5A4C98BF28C521B838DD980@BN8PR11MB3714.namprd11.prod.outlook.com \
--to=wan.ahmad.zainie.wan.mohamad@intel.com \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).