From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"martin.blumenstingl@googlemail.com"
<martin.blumenstingl@googlemail.com>,
"treding@nvidia.com" <treding@nvidia.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"weifeng.voon@intel.com" <weifeng.voon@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/2] net: stmmac: remove useless code of phy_mask
Date: Wed, 8 Jan 2020 13:25:21 +0000 [thread overview]
Message-ID: <BN8PR12MB3266601BC7BA0F414BD60E19D33E0@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20200108112652.GA5316@nuc8i5>
From: Dejin Zheng <zhengdejin5@gmail.com>
Date: Jan/08/2020, 11:26:52 (UTC+00:00)
> On Wed, Jan 08, 2020 at 07:57:14AM +0000, Jose Abreu wrote:
> > From: Dejin Zheng <zhengdejin5@gmail.com>
> > Date: Jan/08/2020, 07:25:48 (UTC+00:00)
> >
> > > Changes since v1:
> > > 1, add a new commit for remove the useless member phy_mask.
> >
> > No, this is not useless. It's an API for developers that need only
> > certain PHYs to be detected. Please do not remove this.
> >
> Hi Jose:
>
> Okay, If you think it is a feature that needs to be retained, I will
> abandon it. since I am a newbie, after that, Do I need to update the
> other commit in this patchset for patch v3? Thanks!
Your first commit (1/2) looks okay so you can submit that stand-alone in
my opinion.
---
Thanks,
Jose Miguel Abreu
next prev parent reply other threads:[~2020-01-08 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 7:25 [PATCH v2 0/2] net: stmmac: remove useless code of phy_mask Dejin Zheng
2020-01-08 7:25 ` [PATCH v2 1/2] net: stmmac: pci: remove the duplicate code of set phy_mask Dejin Zheng
2020-01-08 7:25 ` [PATCH v2 2/2] net: stmmac: remove the useless member phy_mask Dejin Zheng
2020-01-18 7:51 ` kbuild test robot
2020-01-20 16:28 ` Dejin Zheng
2020-01-08 7:57 ` [PATCH v2 0/2] net: stmmac: remove useless code of phy_mask Jose Abreu
2020-01-08 11:26 ` Dejin Zheng
2020-01-08 13:25 ` Jose Abreu [this message]
2020-01-08 13:43 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB3266601BC7BA0F414BD60E19D33E0@BN8PR12MB3266.namprd12.prod.outlook.com \
--to=jose.abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=tglx@linutronix.de \
--cc=treding@nvidia.com \
--cc=weifeng.voon@intel.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).