From: Jose Abreu <Jose.Abreu@synopsys.com>
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
Joao Lima <Joao.Lima@synopsys.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version
Date: Wed, 29 Apr 2020 06:49:09 +0000 [thread overview]
Message-ID: <BN8PR12MB3266D1F9B038EF821FA8D503D3AD0@BN8PR12MB3266.namprd12.prod.outlook.com> (raw)
In-Reply-To: <SN6PR08MB5693C397D88D16EC43E85490DBD00@SN6PR08MB5693.namprd08.prod.outlook.com>
From: Bean Huo (beanhuo) <beanhuo@micron.com>
Date: Apr/24/2020, 16:57:07 (UTC+00:00)
> Hi, Jose
>
> > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
> > *mmio_base, unsigned int irq)
> > if ((hba->ufs_version != UFSHCI_VERSION_10) &&
> > (hba->ufs_version != UFSHCI_VERSION_11) &&
> > (hba->ufs_version != UFSHCI_VERSION_20) &&
> > - (hba->ufs_version != UFSHCI_VERSION_21))
> > + (hba->ufs_version != UFSHCI_VERSION_21) &&
> > + (hba->ufs_version != UFSHCI_VERSION_30))
>
> I don't think these checkups of UFSHCI version is necessary, does the UFSHCI have other version number except these?
> Is there somebody still v1.0 and v1.1?
Probably. I think we can leave them or change the dev_err to a dev_warn.
This way we have logs in case someone is using a non-supported version.
What do you think ?
---
Thanks,
Jose Miguel Abreu
next prev parent reply other threads:[~2020-04-29 6:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 13:44 [PATCH v2 0/5] scsi: ufs: Misc improvements for DesignWare drivers and UFS Jose Abreu
2020-04-24 13:44 ` [PATCH v2 1/5] scsi: ufs: Allow UFS 3.0 as a valid version Jose Abreu
2020-04-24 15:57 ` [EXT] " Bean Huo (beanhuo)
2020-04-29 6:49 ` Jose Abreu [this message]
2020-04-29 12:59 ` Bean Huo (beanhuo)
2020-04-30 8:14 ` Jose Abreu
2020-06-10 3:39 ` Alim Akhtar
2020-06-12 9:40 ` Jose Abreu
2020-04-24 13:44 ` [PATCH v2 2/5] scsi: ufs: Rename tc-dwc-g210 -> tc-dwc Jose Abreu
2020-04-24 13:44 ` [PATCH v2 3/5] scsi: ufs: tc-dwc-pci: Use PDI ID to match Test Chip type Jose Abreu
2020-04-24 13:44 ` [PATCH v2 4/5] scsi: ufs: tc-dwc-pci: Allow for MSI interrupt type Jose Abreu
2020-04-24 13:44 ` [PATCH v2 5/5] MAINTAINERS: Change Maintainers for SCSI UFS DWC Drivers Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB3266D1F9B038EF821FA8D503D3AD0@BN8PR12MB3266.namprd12.prod.outlook.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Lima@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).