From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] iommu/vt-d: Remove duplicate identity domain flag
Date: Mon, 27 Sep 2021 01:02:38 +0000 [thread overview]
Message-ID: <BN9PR11MB54339C8E99C6DE37CDF7CE588CA79@BN9PR11MB5433.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210926114535.923263-2-baolu.lu@linux.intel.com>
> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Sunday, September 26, 2021 7:46 PM
>
> The iommu_domain data structure already has the "type" field to keep the
> type of a domain. It's unnecessary to have the
> DOMAIN_FLAG_STATIC_IDENTITY
> flag in the vt-d implementation. This cleans it up with no functionality
> change.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> ---
> include/linux/intel-iommu.h | 3 ---
> drivers/iommu/intel/iommu.c | 9 ++++-----
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
> index 4bff70c26416..c24bdf5a9285 100644
> --- a/include/linux/intel-iommu.h
> +++ b/include/linux/intel-iommu.h
> @@ -517,9 +517,6 @@ struct context_entry {
> u64 hi;
> };
>
> -/* si_domain contains mulitple devices */
> -#define DOMAIN_FLAG_STATIC_IDENTITY BIT(0)
> -
> /*
> * When VT-d works in the scalable mode, it allows DMA translation to
> * happen through either first level or second level page table. This
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index b0076f54f5f4..dc2030d014e0 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -528,7 +528,7 @@ static inline void free_devinfo_mem(void *vaddr)
>
> static inline int domain_type_is_si(struct dmar_domain *domain)
> {
> - return domain->flags & DOMAIN_FLAG_STATIC_IDENTITY;
> + return domain->domain.type == IOMMU_DOMAIN_IDENTITY;
> }
>
> static inline bool domain_use_first_level(struct dmar_domain *domain)
> @@ -1996,7 +1996,7 @@ static bool first_level_by_default(void)
> return scalable_mode_support() && intel_cap_flts_sanity();
> }
>
> -static struct dmar_domain *alloc_domain(int flags)
> +static struct dmar_domain *alloc_domain(unsigned int type)
> {
> struct dmar_domain *domain;
>
> @@ -2006,7 +2006,6 @@ static struct dmar_domain *alloc_domain(int flags)
>
> memset(domain, 0, sizeof(*domain));
> domain->nid = NUMA_NO_NODE;
> - domain->flags = flags;
> if (first_level_by_default())
> domain->flags |= DOMAIN_FLAG_USE_FIRST_LEVEL;
> domain->has_iotlb_device = false;
> @@ -2830,7 +2829,7 @@ static int __init si_domain_init(int hw)
> struct device *dev;
> int i, nid, ret;
>
> - si_domain = alloc_domain(DOMAIN_FLAG_STATIC_IDENTITY);
> + si_domain = alloc_domain(IOMMU_DOMAIN_IDENTITY);
> if (!si_domain)
> return -EFAULT;
>
> @@ -4639,7 +4638,7 @@ static struct iommu_domain
> *intel_iommu_domain_alloc(unsigned type)
> case IOMMU_DOMAIN_DMA:
> case IOMMU_DOMAIN_DMA_FQ:
> case IOMMU_DOMAIN_UNMANAGED:
> - dmar_domain = alloc_domain(0);
> + dmar_domain = alloc_domain(type);
> if (!dmar_domain) {
> pr_err("Can't allocate dmar_domain\n");
> return NULL;
> --
> 2.25.1
next prev parent reply other threads:[~2021-09-27 1:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 11:45 [PATCH v2 0/3] iommu/t-d: Use SL for GPA->HPA translation Lu Baolu
2021-09-26 11:45 ` [PATCH v2 1/3] iommu/vt-d: Remove duplicate identity domain flag Lu Baolu
2021-09-27 1:02 ` Tian, Kevin [this message]
2021-09-26 11:45 ` [PATCH v2 2/3] iommu/vt-d: Check FL and SL capability sanity in scalable mode Lu Baolu
2021-09-27 1:12 ` Tian, Kevin
2021-09-27 1:30 ` Tian, Kevin
2021-09-27 1:33 ` Tian, Kevin
2021-09-27 1:39 ` Lu Baolu
2021-09-26 11:45 ` [PATCH v2 3/3] iommu/vt-d: Use second level for GPA->HPA translation Lu Baolu
2021-09-27 1:31 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB54339C8E99C6DE37CDF7CE588CA79@BN9PR11MB5433.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).