From: "Sanil, Shruthi" <shruthi.sanil@intel.com>
To: "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"Thokala, Srikanth" <srikanth.thokala@intel.com>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>
Subject: RE: [PATCH v10 0/2] Add the driver for Intel Keem Bay SoC timer block
Date: Wed, 30 Mar 2022 05:04:01 +0000 [thread overview]
Message-ID: <BN9PR11MB55459A4EA8D0599DCB753173F11F9@BN9PR11MB5545.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220322130005.16045-1-shruthi.sanil@intel.com>
Gentle Reminder!
Regards,
Shruthi
> -----Original Message-----
> From: Sanil, Shruthi <shruthi.sanil@intel.com>
> Sent: Tuesday, March 22, 2022 6:30 PM
> To: daniel.lezcano@linaro.org; tglx@linutronix.de; robh+dt@kernel.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Cc: andriy.shevchenko@linux.intel.com; mgross@linux.intel.com; Thokala,
> Srikanth <srikanth.thokala@intel.com>; Raja Subramanian, Lakshmi Bai
> <lakshmi.bai.raja.subramanian@intel.com>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@intel.com>; Sanil, Shruthi
> <shruthi.sanil@intel.com>
> Subject: [PATCH v10 0/2] Add the driver for Intel Keem Bay SoC timer block
>
> From: Shruthi Sanil <shruthi.sanil@intel.com>
>
> The timer block supports 1 64-bit free running counter and 8 32-bit general
> purpose timers.
>
> Patch 1 holds the device tree binding documentation.
> Patch 2 holds the device driver.
>
> This driver is tested on the Keem Bay evaluation module board.
>
> Changes since v9:
> - Updated the error message with the macro FW_BUG wherever applicable.
>
> Changes since v8:
> - The clockevent stucture has been declared as a global static variable,
> rather than allocating memory using kzalloc during probing.
> - Updated the print statement indicating the configuration missing as the FW
> Bug.
> - Updated the comments in the function keembay_timer_isr().
> - Updated the dt-binding to remove 'oneOf' as there is only 1 entry.
> - Updated the dt-binding description clearly indicating that
> the descrption is about the undelying HW.
>
> Changes since v7:
> - Added back the compatible string "intel,keembay-gpt-creg"
> as an enum to the mfd device node in the device tree bindings.
> - As the timer is used as a broadcast timer during CPU idle,
> only one timer is needed. Hence updated the driver accordingly
> incorporating the review comments.
>
> Changes since v6:
> - Removed the unused compatible string from the mfd device node
> to fix the error thrown by the make dt-binding command.
>
> Changes since v5:
> - Created a MFD device for the common configuration register
> in the device tree bindings.
> - Updated the timer driver with the MFD framework to access the
> common configuration register.
>
> Changes since v4:
> - Updated the description in the device tree bindings.
> - Updated the unit address of all the timers and counter
> in the device tree binding.
>
> Changes since v3:
> - Update in KConfig file to support COMPILE_TEST for Keem Bay timer.
> - Update in device tree bindings to remove status field.
> - Update in device tree bindings to remove 64-bit address space for
> the child nodes by using non-empty ranges.
>
> Changes since v2:
> - Add multi timer support.
> - Update in the device tree binding to support multi timers.
> - Code optimization.
>
> Changes since v1:
> - Add support for KEEMBAY_TIMER to get selected through
> Kconfig.platforms.
> - Add CLOCK_EVT_FEAT_DYNIRQ as part of clockevent feature.
> - Avoid overlapping reg regions across 2 device nodes.
> - Simplify 2 device nodes as 1 because both are from same IP block.
> - Adapt the driver code according to the new simplified devicetree.
>
> Shruthi Sanil (2):
> dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer
> clocksource: Add Intel Keem Bay timer support
>
> .../bindings/timer/intel,keembay-timer.yaml | 125 ++++++++++
> MAINTAINERS | 6 +
> drivers/clocksource/Kconfig | 11 +
> drivers/clocksource/Makefile | 1 +
> drivers/clocksource/timer-keembay.c | 226 ++++++++++++++++++
> 5 files changed, 369 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/timer/intel,keembay-timer.yaml
> create mode 100644 drivers/clocksource/timer-keembay.c
>
>
> base-commit: ffb217a13a2eaf6d5bd974fc83036a53ca69f1e2
> --
> 2.17.1
next prev parent reply other threads:[~2022-03-30 5:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 13:00 [PATCH v10 0/2] Add the driver for Intel Keem Bay SoC timer block shruthi.sanil
2022-03-22 13:00 ` [PATCH v10 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer shruthi.sanil
2022-03-30 11:44 ` Daniel Lezcano
2022-03-30 11:55 ` Krzysztof Kozlowski
2022-04-06 8:06 ` Daniel Lezcano
2022-04-06 15:13 ` Rob Herring
2022-03-22 13:00 ` [PATCH v10 2/2] clocksource: Add Intel Keem Bay timer support shruthi.sanil
2022-03-30 5:04 ` Sanil, Shruthi [this message]
2022-03-30 8:59 ` [PATCH v10 0/2] Add the driver for Intel Keem Bay SoC timer block andriy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB55459A4EA8D0599DCB753173F11F9@BN9PR11MB5545.namprd11.prod.outlook.com \
--to=shruthi.sanil@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=srikanth.thokala@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).