From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753159AbcKUFPH (ORCPT ); Mon, 21 Nov 2016 00:15:07 -0500 Received: from mail-by2nam03on0046.outbound.protection.outlook.com ([104.47.42.46]:20413 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750787AbcKUFPG (ORCPT ); Mon, 21 Nov 2016 00:15:06 -0500 From: "Gurumurthy, Anil" To: Johannes Thumshirn , Arnd Bergmann CC: "James E.J. Bottomley" , "Martin K. Petersen" , Anil Gurumurthy , Sudarsana Kalluru , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions Thread-Topic: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions Thread-Index: AQHSQBw2qZrW8Bg760+FpxVTLjTBbqDevUeAgAQlLsA= Date: Mon, 21 Nov 2016 04:41:37 +0000 Message-ID: References: <20161116151445.3208739-1-arnd@arndb.de> <20161118132203.3og7fayqxk3xd5r2@linux-x5ow.site> In-Reply-To: <20161118132203.3og7fayqxk3xd5r2@linux-x5ow.site> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anil.Gurumurthy@cavium.com; x-originating-ip: [122.166.129.188] x-microsoft-exchange-diagnostics: 1;BY1PR0701MB1643;7:0aNZjkyeBKhQ/2X3plghnlfUA9wzYgKcFQqAkOAtEItysiCIRDbQh8cjkNL4u/+JY0Vf7lNe/Y+WACmnXqCUe8zYScJi90XFhHvxNBuesI+GLEcttRQUj4bytjKwz7Uw+ZzVwZKArzxR+B6wOorBIaNnwM5NEcVpDeWKqUBBvrksv/Y0ihdpbfDQnDPW+RJiPhr4EARAtYI+yuGRS+3C9s/HpOgGtsA1xeZD6cHgZnu1zrzwGZliFsQI0MgDS6GW6YkWz3705bWWe+8SvAal18xIrxdGtwsnpdpaSkuMHipOta1Ui8wD1ocOTT73d+3xX09iV+TclYUe91edVx7k3r+3IoNd3ArAUPELqBGZFQ0= x-ms-office365-filtering-correlation-id: f689d4de-6923-4728-67d3-08d411c8adc3 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY1PR0701MB1643; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(104084551191319)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040307)(6060326)(6045199)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(6061324);SRVR:BY1PR0701MB1643;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1643; x-forefront-prvs: 01334458E5 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(199003)(24454002)(13464003)(87936001)(3660700001)(8676002)(2900100001)(81166006)(77096005)(92566002)(33656002)(3846002)(81156014)(38730400001)(7846002)(86362001)(9686002)(575784001)(5001770100001)(8936002)(97736004)(74316002)(105586002)(7736002)(6116002)(68736007)(122556002)(102836003)(189998001)(50986999)(2906002)(76576001)(66066001)(229853002)(3280700002)(76176999)(101416001)(54356999)(4326007)(106356001)(106116001)(6506003)(5660300001)(7696004)(2950100002)(99286002)(305945005)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1643;H:BY1PR0701MB1644.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2016 04:41:37.1247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1643 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAL5FB84024520 Patch looks good. Acked by: Anil Gurumurthy -----Original Message----- From: Johannes Thumshirn [mailto:jthumshirn@suse.de] Sent: 18 November 2016 18:52 To: Arnd Bergmann Cc: James E.J. Bottomley ; Martin K. Petersen ; Anil Gurumurthy ; Sudarsana Kalluru ; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions On Wed, Nov 16, 2016 at 04:14:27PM +0100, Arnd Bergmann wrote: > These two macros cause lots of warnings with gcc-7: > > drivers/scsi/bfa/bfa_svc.c: In function 'bfa_fcxp_meminfo': > drivers/scsi/bfa/bfa_svc.c:521:103: error: '*' in boolean context, > suggest '&&' instead [-Werror=int-in-bool-context] > > Using inline functions makes them much more readable and avoids the > warnings. > > Signed-off-by: Arnd Bergmann > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850