From: "Zhou, David(ChunMing)" <David1.Zhou@amd.com>
To: Eric Anholt <eric@anholt.net>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: RE: [PATCH] drm/syncobj: Fix oops on drm_syncobj_find_fence(file_priv, 0, ...).
Date: Tue, 6 Nov 2018 02:18:38 +0000 [thread overview]
Message-ID: <BY1PR12MB050299A6BA4B1967250724AAB4CB0@BY1PR12MB0502.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20181105230110.4812-1-eric@anholt.net>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> -----Original Message-----
> From: Eric Anholt <eric@anholt.net>
> Sent: Tuesday, November 06, 2018 7:01 AM
> To: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org; Eric Anholt <eric@anholt.net>; Zhou,
> David(ChunMing) <David1.Zhou@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>
> Subject: [PATCH] drm/syncobj: Fix oops on
> drm_syncobj_find_fence(file_priv, 0, ...).
>
> This broke rendering on V3D, where we almost always have a 0 in-syncobj.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9")
> Cc: Chunming Zhou <david1.zhou@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/drm_syncobj.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c
> b/drivers/gpu/drm/drm_syncobj.c index 4dca5f7e8c4b..da8175d9c6ff 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -443,7 +443,8 @@ int drm_syncobj_find_fence(struct drm_file
> *file_private,
> int ret;
>
> ret = drm_syncobj_search_fence(syncobj, point, flags, fence);
> - drm_syncobj_put(syncobj);
> + if (syncobj)
> + drm_syncobj_put(syncobj);
> return ret;
> }
> EXPORT_SYMBOL(drm_syncobj_find_fence);
> --
> 2.19.1
next prev parent reply other threads:[~2018-11-06 2:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 23:01 [PATCH] drm/syncobj: Fix oops on drm_syncobj_find_fence(file_priv, 0, ...) Eric Anholt
2018-11-06 2:18 ` Zhou, David(ChunMing) [this message]
2018-11-06 9:10 ` Koenig, Christian
2018-11-06 10:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY1PR12MB050299A6BA4B1967250724AAB4CB0@BY1PR12MB0502.namprd12.prod.outlook.com \
--to=david1.zhou@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).