From: Matthew Wilcox <mawilcox@microsoft.com>
To: Heiko Stuebner <heiko@sntech.de>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: thermal zones break with patch "Reimplement IDR and IDA using the radix tree" (mainline+next)
Date: Fri, 16 Dec 2016 21:19:37 +0000 [thread overview]
Message-ID: <BY2PR21MB00362FC819BA305D09EAF6FACB9C0@BY2PR21MB0036.namprd21.prod.outlook.com> (raw)
In-Reply-To: <1758112.VgMJOyEgSu@phil>
From: Heiko Stuebner [mailto:heiko@sntech.de]
> commit b05bbe3ea2db ("Reimplement IDR and IDA using the radix tree")
> seems to
> break thermal zone allocation. This happens both on todays mainline and
> linux-next-20161216 and produces errors like:
> While I haven't looked to deeply into what idr exactly does, some findings:
> - thermal_zone0 and thermal_zone1 are allocated correctly
> - every further thermal_zone always gets allocated the number "1"
> - thermal core calls idr_alloc with 0 for both start and end
> - the rewrite-patch seems to change the semantics of idr_alloc
> where it orignally said "@end: the maximum id (exclusive, <= 0 for max)"
> the "<= 0" part is gone now, but I checked, simply setting INT_MAX
> as end in the thermal_core does not help
Hi Heiko,
Thanks for the report! The problem is because the thermal subsystem calls idr_alloc() passing a NULL pointer for the data. I have fixed this problem in my git tree but haven't sent the patch to Andrew yet. This patch should fix the problem for you:
http://git.infradead.org/users/willy/linux-dax.git/commitdiff/c52eeed7b759c3fefe9b7f1b0a17a438df6950f3
Now ... thermal is actually using an IDR when it could save memory by using an IDA. Are you interested in doing that conversion?
next prev parent reply other threads:[~2016-12-16 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 21:12 thermal zones break with patch "Reimplement IDR and IDA using the radix tree" (mainline+next) Heiko Stuebner
2016-12-16 21:19 ` Matthew Wilcox [this message]
2016-12-17 0:48 ` Heiko Stuebner
2016-12-20 3:56 ` Eduardo Valentin
2016-12-18 19:43 ` Andy Shevchenko
2016-12-19 16:37 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY2PR21MB00362FC819BA305D09EAF6FACB9C0@BY2PR21MB0036.namprd21.prod.outlook.com \
--to=mawilcox@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).