From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
To: Jijie Shao <shaojijie@huawei.com>,
"yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
"salil.mehta@huawei.com" <salil.mehta@huawei.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Cc: "shenjian15@huawei.com" <shenjian15@huawei.com>,
"wangjie125@huawei.com" <wangjie125@huawei.com>,
"liuyonglong@huawei.com" <liuyonglong@huawei.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 6/8] net: hns3: fix reset timeout under full functions and queues
Date: Thu, 7 Mar 2024 11:24:09 +0000 [thread overview]
Message-ID: <BY3PR18MB4737FA1796C8BC8180296BE8C6202@BY3PR18MB4737.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240307010115.3054770-7-shaojijie@huawei.com>
> -----Original Message-----
> From: Jijie Shao <shaojijie@huawei.com>
> Sent: Thursday, March 7, 2024 6:31 AM
> To: yisen.zhuang@huawei.com; salil.mehta@huawei.com;
> davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com
> Cc: shenjian15@huawei.com; wangjie125@huawei.com;
> liuyonglong@huawei.com; shaojijie@huawei.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] [PATCH net 6/8] net: hns3: fix reset timeout under full
> functions and queues
>
> From: Peiyang Wang <wangpeiyang1@huawei.com>
>
> The cmdq reset command times out when all VFs are enabled and the
> queue is full. The hardware processing time exceeds the timeout set by the
> driver.
> In order to avoid the above extreme situations, the driver extends the reset
> timeout to 1 second.
>
Reviewed-by: Sunil Goutham <sgoutham@marvell.com>
But one observation, loop of udelay(1) for 1sec seems a lot, probably better to use usleep_range().
next prev parent reply other threads:[~2024-03-07 11:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 1:01 [PATCH net 0/8] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-03-07 1:01 ` [PATCH net 1/8] net: hns3: fix wrong judgment condition issue Jijie Shao
2024-03-07 1:01 ` [PATCH net 2/8] net: hns3: add new 200G link modes for hisilicon device Jijie Shao
2024-03-07 1:01 ` [PATCH net 3/8] net: hns3: Disable SerDes serial loopback for HiLink H60 Jijie Shao
2024-03-07 1:01 ` [PATCH net 4/8] net: hns3: fix kernel crash when 1588 is received on HIP08 devices Jijie Shao
2024-03-07 1:01 ` [PATCH net 5/8] net: hns3: fix delete tc fail issue Jijie Shao
2024-03-07 1:01 ` [PATCH net 6/8] net: hns3: fix reset timeout under full functions and queues Jijie Shao
2024-03-07 11:24 ` Sunil Kovvuri Goutham [this message]
2024-03-08 9:38 ` Jijie Shao
2024-03-07 1:01 ` [PATCH net 7/8] net: hns3: fix port duplex configure error in IMP reset Jijie Shao
2024-03-07 1:01 ` [PATCH net 8/8] net: hns3: add checking for vf id of mailbox Jijie Shao
2024-03-07 11:09 ` Sunil Kovvuri Goutham
2024-03-08 12:10 ` [PATCH net 0/8] There are some bugfix for the HNS3 ethernet driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY3PR18MB4737FA1796C8BC8180296BE8C6202@BY3PR18MB4737.namprd18.prod.outlook.com \
--to=sgoutham@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).