From: Anand Ashok Dumbre <ANANDASH@xilinx.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>, git <git@xilinx.com>,
Michal Simek <michals@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>
Subject: RE: [PATCH v10 0/5] Add Xilinx AMS Driver
Date: Thu, 18 Nov 2021 15:03:44 +0000 [thread overview]
Message-ID: <BY5PR02MB691686AFC8D0DC41DEE5B493A99B9@BY5PR02MB6916.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VdkGHvauZG7Nw4dDEb4+ZeVS4Pt2x05EiOiVCBVv8s10w@mail.gmail.com>
Hi Andy,
Thanks for the review.
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Wednesday 17 November 2021 5:14 PM
> To: Anand Ashok Dumbre <ANANDASH@xilinx.com>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Jonathan
> Cameron <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; linux-
> iio <linux-iio@vger.kernel.org>; git <git@xilinx.com>; Michal Simek
> <michals@xilinx.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>;
> Rafael J. Wysocki <rafael@kernel.org>; ACPI Devel Maling List <linux-
> acpi@vger.kernel.org>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Krogerus, Heikki
> <heikki.krogerus@linux.intel.com>
> Subject: Re: [PATCH v10 0/5] Add Xilinx AMS Driver
>
> On Wed, Nov 17, 2021 at 6:46 PM Anand Ashok Dumbre
> <anand.ashok.dumbre@xilinx.com> wrote:
> >
> > Add Xilinx AMS driver which is used for Xilinx's ZynqMP AMS controller.
> > This AMS driver is used to report various interface voltages and
> > temperatures across the system.
> > This driver will be used by iio-hwmon to repport voltages and
> > temperatures across the system by using various channel interfaces.
> > This driver handles AMS module including PS-Sysmon & PL-Sysmon. The
> > binding documentation is added for understanding of AMS, PS, PL Sysmon
> Channels.
>
> Thanks and wait a bit, please. No need to send patches so often. We haven't
> settled down yet on v9. Here you effectively ignored my comment given
> again patch 5/5. Why?
>
Apologies for sending patch too soon. I sent the patch before I saw your response.
> ...
>
> > Changes in v10:
> > - Fixed licence in zynqmp.dtsi.
> > - Changed the macros to use BIT().
> > - Realign some code to fit within 100 chars.
> > - Modified readl_poll_timeout usage.
>
> > - Usage of array_size() instead of check_mul_overflow().
>
> Why? I have asked you why you haven't used kcalloc there as well.
Yes, I saw the implementation of kcalloc after reading your comment and
It does check_mul_overflow internally so this is not needed.
I will wait a couple of days before sending new patches.
>
> > - Usage of dev_err_probe() instead of dev_err().
> > - Usage of kcalloc instead of kzalloc()
>
> --
> With Best Regards,
> Andy Shevchenko
Thanks,
Anand
prev parent reply other threads:[~2021-11-18 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 16:10 [PATCH v10 0/5] Add Xilinx AMS Driver Anand Ashok Dumbre
2021-11-17 16:10 ` [PATCH v10 1/5] device property: Add fwnode_iomap() Anand Ashok Dumbre
2021-11-17 16:10 ` [PATCH v10 2/5] arm64: zynqmp: DT: Add Xilinx AMS node Anand Ashok Dumbre
2021-11-17 16:10 ` [PATCH v10 3/5] iio: adc: Add Xilinx AMS driver Anand Ashok Dumbre
2021-11-17 19:01 ` kernel test robot
2021-11-17 20:03 ` Andy Shevchenko
2021-11-18 8:07 ` Michal Simek
2021-11-18 14:14 ` Anand Ashok Dumbre
2021-11-18 15:42 ` Andy Shevchenko
2021-11-21 12:29 ` Anand Ashok Dumbre
2021-11-18 22:25 ` kernel test robot
2021-11-20 16:54 ` Jonathan Cameron
2021-11-21 11:27 ` Anand Ashok Dumbre
2021-11-17 16:10 ` [PATCH v10 4/5] dt-bindings: iio: adc: Add Xilinx AMS binding documentation Anand Ashok Dumbre
2021-11-17 16:10 ` [PATCH v10 5/5] MAINTAINERS: Add maintainer for xilinx-ams Anand Ashok Dumbre
2021-11-17 17:13 ` [PATCH v10 0/5] Add Xilinx AMS Driver Andy Shevchenko
2021-11-18 15:03 ` Anand Ashok Dumbre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR02MB691686AFC8D0DC41DEE5B493A99B9@BY5PR02MB6916.namprd02.prod.outlook.com \
--to=anandash@xilinx.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).