* [PATCH] nios2: signal: Mark expected switch fall-through
@ 2020-06-08 17:36 Gustavo A. R. Silva
2020-06-12 6:19 ` Tan, Ley Foon
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2020-06-08 17:36 UTC (permalink / raw)
To: Ley Foon Tan, Christian Brauner; +Cc: linux-kernel, Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
Fix the following warning through the use of the new the new
pseudo-keyword fallthrough;
arch/nios2/kernel/signal.c:254:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
254 | restart = -2;
| ~~~~~~~~^~~~
arch/nios2/kernel/signal.c:255:3: note: here
255 | case ERESTARTNOHAND:
| ^~~~
Reported-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
arch/nios2/kernel/signal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/nios2/kernel/signal.c b/arch/nios2/kernel/signal.c
index a42dd09c65783..d8a087cf2b424 100644
--- a/arch/nios2/kernel/signal.c
+++ b/arch/nios2/kernel/signal.c
@@ -252,6 +252,7 @@ static int do_signal(struct pt_regs *regs)
switch (retval) {
case ERESTART_RESTARTBLOCK:
restart = -2;
+ fallthrough;
case ERESTARTNOHAND:
case ERESTARTSYS:
case ERESTARTNOINTR:
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] nios2: signal: Mark expected switch fall-through
2020-06-08 17:36 [PATCH] nios2: signal: Mark expected switch fall-through Gustavo A. R. Silva
@ 2020-06-12 6:19 ` Tan, Ley Foon
0 siblings, 0 replies; 2+ messages in thread
From: Tan, Ley Foon @ 2020-06-12 6:19 UTC (permalink / raw)
To: Gustavo A. R. Silva, Christian Brauner; +Cc: linux-kernel, Gustavo A. R. Silva
> -----Original Message-----
> From: Gustavo A. R. Silva <gustavoars@kernel.org>
> Sent: Tuesday, June 9, 2020 1:37 AM
> To: Tan, Ley Foon <ley.foon.tan@intel.com>; Christian Brauner
> <christian.brauner@ubuntu.com>
> Cc: linux-kernel@vger.kernel.org; Gustavo A. R. Silva
> <gustavo@embeddedor.com>
> Subject: [PATCH] nios2: signal: Mark expected switch fall-through
>
> Mark switch cases where we are expecting to fall through.
>
> Fix the following warning through the use of the new the new pseudo-
> keyword fallthrough;
>
> arch/nios2/kernel/signal.c:254:12: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 254 | restart = -2;
> | ~~~~~~~~^~~~
> arch/nios2/kernel/signal.c:255:3: note: here
> 255 | case ERESTARTNOHAND:
> | ^~~~
>
> Reported-by: Christian Brauner <christian.brauner@ubuntu.com>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
Will merge to coming release.
Thanks.
Regards
Ley Foon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-12 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 17:36 [PATCH] nios2: signal: Mark expected switch fall-through Gustavo A. R. Silva
2020-06-12 6:19 ` Tan, Ley Foon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).