From: Rajan Vaja <RAJANV@xilinx.com>
To: Sudeep Holla <sudeep.holla@arm.com>, Jolly Shah <JOLLYS@xilinx.com>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
Michal Simek <michals@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tejas Patel <TEJASP@xilinx.com>
Subject: RE: [PATCH 0/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional
Date: Mon, 13 Jan 2020 06:46:52 +0000 [thread overview]
Message-ID: <BYAPR02MB4055B8A5ED27C2F23A28D8D0B7350@BYAPR02MB4055.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20200110115415.GC39451@bogus>
Hi Sudeep,
Thanks for the reviewing patch.
> -----Original Message-----
> From: Sudeep Holla <sudeep.holla@arm.com>
> Sent: 10 January 2020 05:24 PM
> To: Jolly Shah <JOLLYS@xilinx.com>
> Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; gregkh@linuxfoundation.org;
> matt@codeblueprint.co.uk; hkallweit1@gmail.com; keescook@chromium.org;
> dmitry.torokhov@gmail.com; Michal Simek <michals@xilinx.com>; Rajan Vaja
> <RAJANV@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Sudeep Holla <sudeep.holla@arm.com>; Tejas Patel
> <TEJASP@xilinx.com>
> Subject: Re: [PATCH 0/2] arch: arm64: xilinx: Make zynqmp_firmware driver
> optional
>
> EXTERNAL EMAIL
>
> On Thu, Jan 09, 2020 at 11:06:02AM -0800, Jolly Shah wrote:
> > From: Tejas Patel <tejas.patel@xilinx.com>
> >
> > Zynqmp firmware driver requires firmware to be present in system.
> > Zynqmp firmware driver will crash if firmware is not present in system.
> > For example single arch QEMU, may not have firmware, with such setup
> > Linux booting fails.
> >
> > So make zynqmp_firmware driver as optional to disable it if user don't
> > have firmware in system.
> >
>
> Why can't it be detected runtime ? How do you handle single binary if you
> make this compile time option ?
[Rajan] There is PMU register which indicates if firmware is present or not, but in case of single arch QEMU that register will not be available so there is no way to detect if firmware is present or not from Linux.
Linux firmware crashes while arm_smccc_smc() call for firmware, but before this call there is no way to identify if firmware is present or not. So we are just giving user an option if they want to use it on single arch
Platform they can disable firmware driver.
Thanks,
Rajan
> --
> Regards,
> Sudeep
next prev parent reply other threads:[~2020-01-13 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:06 [PATCH 0/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional Jolly Shah
2020-01-09 19:06 ` [PATCH 1/2] include: linux: firmware: Correct config dependency of zynqmp_eemi_ops Jolly Shah
2020-02-24 10:35 ` Michal Simek
2020-01-09 19:06 ` [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional Jolly Shah
2020-02-24 10:43 ` Michal Simek
2020-02-26 0:12 ` Jolly Shah
2020-01-10 11:54 ` [PATCH 0/2] " Sudeep Holla
2020-01-13 6:46 ` Rajan Vaja [this message]
2020-01-13 15:13 ` Sudeep Holla
2020-02-24 10:33 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR02MB4055B8A5ED27C2F23A28D8D0B7350@BYAPR02MB4055.namprd02.prod.outlook.com \
--to=rajanv@xilinx.com \
--cc=JOLLYS@xilinx.com \
--cc=TEJASP@xilinx.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=michals@xilinx.com \
--cc=mingo@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).