From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E9FC433DF for ; Thu, 18 Jun 2020 15:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC2E92075E for ; Thu, 18 Jun 2020 15:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="Fm2SQL6B"; dkim=pass (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="XDYrv+2l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731442AbgFRPXZ (ORCPT ); Thu, 18 Jun 2020 11:23:25 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:9011 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726905AbgFRPXY (ORCPT ); Thu, 18 Jun 2020 11:23:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1592493804; x=1624029804; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=PkHxP8yCC+XpZWfA3hJOcNoZlW7rdiT2lsFhBfxPXlE=; b=Fm2SQL6BLX6hxj1AxYzecHO1Am/Rn3gU31GbzEy1xQuuTeQ8fP3UAs8/ 6MXHFYCKALkK2KF7geHQM6PpAmgIbmYDQT9MBuD0Qkb1Pt/r+d543Zot3 6MjVLK/YXo7r6pH8GRtTtOuSPEl9LW7TvKxAJRmZy5xxF4RqABpzNGcv8 vvjCXigzluOThfLadabjGqbI/R3bC2IagMAM4beDNc8xB5cXgRlTUdQ8N fKa4P8/9FyqYUhxitHLPY15lByL7cbxNC7vPLjNyB4CspbI4uLHUybT7A ffJZ95oPwPg+RPreltNlnsTlj+mI4SYq7XzAWxapXA0O1WAEry51ffugO A==; IronPort-SDR: wkAlW/CYAGF3U2lB9x6rrrvNWgNYq0CDxUW0xdbaVIYbx+M46HQPaccLcjO9XeebIkTxNT66xI okxgpTCWrmKczFm/ejwqYfKtFOIWfIlGbP6PB6g9cdRO2ZBsurpGc8iiftg4swCCbCHq2Tovoh IqYDzN/gv2q7oRccx/luA2zz2K74A59BPgWXdm7quQoXwzKDK7Js3YdOE+UNv4nZw+wP4b3TEr O1g7GCsKll83c0njc8gGldTG6BtwguHvb9uX6Jg4jRxh7s5kqvCLIy5/ec0LFjQvA7+jVz7tJC /Es= X-IronPort-AV: E=Sophos;i="5.75,251,1589212800"; d="scan'208";a="141713018" Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hgst.iphmx.com with ESMTP; 18 Jun 2020 23:23:22 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bC2s7ghKSfEZLYg3gMswqjimdExoxnXKNY/wuw8s+5tjlHKoCWYlrtRnnXXnmDg2HUWIBofVyweeQA48O1VutJcxK8hhrBIXpbgzWUzWDgJFG77tGBLpJA/pqX77AG0wAyZRHNkuq6Lg0mR3ixskkjAfkRWl6vLFbX1ebGfsH9k9kSdmEthUi49Blq8NV6ok440Jop+pQpohn6FKV2f+hJf6I5tv5qU5huHs6z1dNyIOFqxu/d0OpQ5Y/Ne/LiGS2+mFJSGG4tom7ovUesZAatU45E78EW661THnUk2EyDGlZnerzgDbLUR/zhPP6q+HHx8vjbVb2K/C+Nh9w39DPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SbAjMdmqOKCwsEWL6nQBXj1WTlUOLPY6dLdahLISmxc=; b=SzmXNj/dA90EOE5Z1yzpe8cHWvk8f4UIW9qYY05dw4qaoGcM4TnpfqmyFPiXT6T4Qh3n18TYefvo+y+C4p01rtVAn0ZBqsJFUi3YFKg3A/IS42ITAo1UD4F2a99hTc6r3sFat5FL+3lKlF4MEZsvCbHN9SAAjHVCjhWXiLLk+qHxtafbwPMFKECCcQe/QuZWfKyxKw893LYo+d23vSaLrH5a725OOBpYvkhYoLmGlie2oQ/Fd0APKdswnM2+2JI5AX0YivvGEN6MeV7YSURfHAwkSK8JCEOma06AmbFCbViPSb0Lnbt3cjW6f3jT2jpXIf6co0tt+ijRGDH31gbgWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SbAjMdmqOKCwsEWL6nQBXj1WTlUOLPY6dLdahLISmxc=; b=XDYrv+2lL1JKBYBriRhPKJTMMn5CSY7+WxUJWUPw+QxHkL4hLnbb4ZvQ6fLgKqHQ0CaT62eh6BFAuCmh0JatUzumAvv8aowUQc/8LTn59nlu5xs2JdcELAo0SaxtW6f0CfoLRD5WApVhtUt+1k4lUvWzM/UIfBYNlqu6tsqU28I= Received: from BYAPR04MB4965.namprd04.prod.outlook.com (2603:10b6:a03:4d::25) by BY5PR04MB6552.namprd04.prod.outlook.com (2603:10b6:a03:1d8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Thu, 18 Jun 2020 15:23:21 +0000 Received: from BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::4d72:27c:c075:c5e6]) by BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::4d72:27c:c075:c5e6%7]) with mapi id 15.20.3109.023; Thu, 18 Jun 2020 15:23:21 +0000 From: Chaitanya Kulkarni To: Niklas Cassel , Christoph Hellwig , Sagi Grimberg CC: "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed fields in initializers Thread-Topic: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed fields in initializers Thread-Index: AQHWRX1ZyGByOih9fUSrbaAjQMq7Ig== Date: Thu, 18 Jun 2020 15:23:21 +0000 Message-ID: References: <20200618143241.1056800-1-niklas.cassel@wdc.com> <20200618143241.1056800-2-niklas.cassel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [199.255.45.62] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6b6de368-fbe5-4e59-d55e-08d8139b8922 x-ms-traffictypediagnostic: BY5PR04MB6552: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:3383; x-forefront-prvs: 0438F90F17 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oyiTMO0i2qUxQrwsKOI2qCjnYMVPofeK2e0rOuA4M7+11ZICLSCI1pQTcYU+iq1h9/UcGwvtoF9+T7uBkcgbBDtpKSDqEhS9u3ciThMbxbYVS5YwY1rM4P8EaxAqoUjHyr3vNcFVyROwEbwr/5WteMlAjMP4HH3DXyPvF/7Ih2w/tBOe8KEDJdzghmplEujb6N/P/8+9MY4O30UvXC/WEs0mCJ+hoqV2l5I2GluhvAP3ZbZVC2wgHelUd2aZyU1CiDs9+5CMuf3n7jLsFH/xFoNPLVx0pg5ZLcs0TW6iQYWE8xifm7MukEfdaszCPByvfOg1Bi0d89nGD1Ya2+aOzQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR04MB4965.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(52536014)(2906002)(9686003)(26005)(55016002)(53546011)(4326008)(6506007)(478600001)(5660300002)(71200400001)(110136005)(7696005)(8936002)(86362001)(316002)(8676002)(66946007)(186003)(76116006)(66446008)(33656002)(66476007)(66556008)(83380400001)(54906003)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: w+j/+79LV7VvoevOLXCdlVw6al+UIomLMPITqipUvyoDsg9FSKo1qL6Hk61QerD8tDPIbUvj6SYLDqz27dH9UNAonODD1YE+RsTkFwDsyf3xILRXQAjfQaLsyKpK3qbcHd9WzJvPstTzzNwMMzoFG6ZINUeahcFYAwwKaSAcoLZ3QEPxKu8p60xs+apoROOoUXog4kWS8rRkw1CCUO3/TxyBHmrAw1q86BnmJYiOe6V1YTrPKDZbcP14ro3wQZxCKcFMEzUBRqABnly/DKruEsj1nJZiKq5C0VTNrcN7LDmkJwxCRFsCX+hG4jhFJkV4jeUyfv1OU6zIk3Bulvm/42WOWCDZOKhNyfEtxDN8DXvAWjVnEW0/ufHqG+bmNXqGtcKoh+QT/v850KRpDt92XaCQ6YdxXkVnZ98LK+Yc8THAO+emN6q/XJ15rPhjzmTaiFAOamQCatC/QJKnfSSEkO4g1nlAfnPsCrDNq6QhwQA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b6de368-fbe5-4e59-d55e-08d8139b8922 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 15:23:21.3285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OtjSB1YIcqpHDAYyk2BPSWB0y8UJ+fR+iLKRxTUw5drAbNNN8Pdq5vBP5wWmDzxT/+SZa2Zr2o/E5hGgAYFffo994cZg3MojOtK/9gOhXrE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6552 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/18/20 7:32 AM, Niklas Cassel wrote:=0A= > drivers/nvme/target/rdma.c | 23 ++++++++++++-----------=0A= > 1 file changed, 12 insertions(+), 11 deletions(-)=0A= > =0A= > diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c=0A= > index 6731e0349480..85c6ff0b0e44 100644=0A= > --- a/drivers/nvme/target/rdma.c=0A= > +++ b/drivers/nvme/target/rdma.c=0A= > @@ -1535,19 +1535,20 @@ static int nvmet_rdma_cm_accept(struct rdma_cm_id= *cm_id,=0A= > struct nvmet_rdma_queue *queue,=0A= > struct rdma_conn_param *p)=0A= > {=0A= > - struct rdma_conn_param param =3D { };=0A= > - struct nvme_rdma_cm_rep priv =3D { };=0A= > + struct rdma_conn_param param =3D {=0A= > + .rnr_retry_count =3D 7,=0A= > + .flow_control =3D 1,=0A= > + .initiator_depth =3D min_t(u8, p->initiator_depth,=0A= > + queue->dev->device->attrs.max_qp_init_rd_atom),=0A= > + .private_data =3D &priv,=0A= > + .private_data_len =3D sizeof(priv),=0A= > + };=0A= > + struct nvme_rdma_cm_rep priv =3D {=0A= > + .recfmt =3D cpu_to_le16(NVME_RDMA_CM_FMT_1_0),=0A= > + .crqsize =3D cpu_to_le16(queue->recv_queue_size),=0A= > + };=0A= > int ret =3D -ENOMEM;=0A= > =0A= > - param.rnr_retry_count =3D 7;=0A= > - param.flow_control =3D 1;=0A= > - param.initiator_depth =3D min_t(u8, p->initiator_depth,=0A= > - queue->dev->device->attrs.max_qp_init_rd_atom);=0A= > - param.private_data =3D &priv;=0A= > - param.private_data_len =3D sizeof(priv);=0A= > - priv.recfmt =3D cpu_to_le16(NVME_RDMA_CM_FMT_1_0);=0A= > - priv.crqsize =3D cpu_to_le16(queue->recv_queue_size);=0A= > -=0A= > ret =3D rdma_accept(cm_id, ¶m);=0A= > if (ret)=0A= > pr_err("rdma_accept failed (error code =3D %d)\n", ret);=0A= > -- 2.26.2=0A= =0A= What is the issue with existing code that we need this patch for ?=0A=