From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC74C433DF for ; Sun, 2 Aug 2020 22:54:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BED912072A for ; Sun, 2 Aug 2020 22:54:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="FyiV1VKv"; dkim=pass (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="ORQ513IO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbgHBWyv (ORCPT ); Sun, 2 Aug 2020 18:54:51 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:16988 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726257AbgHBWyv (ORCPT ); Sun, 2 Aug 2020 18:54:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1596408892; x=1627944892; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=38KtaqXSFng6jLn2sPIZ0nnrIVSyMxRGlox7P9LTs8I=; b=FyiV1VKvnThuLHFaG6v3BFsk4muV2CcajMjris5PUxvfqU53jFP8e72D /Gp05+NCGYJ3VTPQviShPm9bMAUtyDdJSliPgsN9LymvnzO8eFuIOjJ2S aqpskWM837lNDu+BVs4azix8cPcyeWRCayVwIL1zz/PtyMu/X0HGegRQB b9ANQliDEyLSxodvitc7pkGxRpg5TTA93T8OkkuN9h/4dSj2kUK/2otKo AK0u6QSwzp1BatIyGN+g7JVTACTUYpAzzU3m+cCWpZF2d9lORG2pamnXw acM3LmHt09rclnIBCGkiG4J1ouf0E5YpC+mROt0R3T9KdFkxIo9tLI2zE A==; IronPort-SDR: 3XKu7bkHrS3akBOMyYba7+w0oCgIn2E3aPN7K8cX87Rpkcn5qJIl0jEEikeNDc8dYs17fmqPjZ 5H9J/hHThD7R7lU9xgciQdRyEk7ZLU5LJEwlheDk/KtfrXMk1CKL3hdhuREjrG1by+DAFOHaos Kw0lPbbrmqRiCOjZcl33LJUheVkefSCpZcrdmWSMi2vFeNO+vJv5Msak/2zJQEBNqVOdcVtT0w qLWnSiiJ5/T66cvGUY+3Al5apu9dWu0T5cKMTzl1levkQfdzmvk6TI8D0YgK7Of0zXItKYerQ0 uS8= X-IronPort-AV: E=Sophos;i="5.75,427,1589212800"; d="scan'208";a="148277463" Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hgst.iphmx.com with ESMTP; 03 Aug 2020 06:54:50 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2QSlLsIUw2g1aLr5an5SGAPYut9ZyxaiZcesgh5rFg3y7Q6ENRzUlGUKxhdJwba1OdpKfq3uYTutcp0RRl89eaxnv2MuQD/wHUF+mhb3DI0sFH1Xg3/GQxFKpSlnhg5zunBjaNaG2C+7N56lZdaXgNN4HQ/2iMdR6+Tb4k3A/YJs6yNAgTmt/jc8q92wvKPnqyo9T1ltM0qd3Swj3/F3zRZuGPllRneI8tav5JENyeJ4u5lshgavlfFT2t1VKGEKlxjRRG+M0XoKkBHVj3oxYvfOuZwyl7f9SG/BbL5cHlMxxaGt2M+adJo3e9B9YDvvDRsjwkU3pOa+6gjwjTZ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38KtaqXSFng6jLn2sPIZ0nnrIVSyMxRGlox7P9LTs8I=; b=Yoc+C+yXy85bemzLYSp+21lkC0PvBYPtqVbAOo8xf6hXqtxRfvqGXDpP9YxWH8zwaSEft/0WlmN/SlLgzo07AtfaSukm+oup2aibyqO1zRGvHO2vzgXnNHkd1dYdNHppiPkNzrEnjS+Bc2L+BBlIOe55tVfK/W5hYPSz1eSjzZU8xvI6RLTu02ilHMKxzL8H4set9lYa1hmyBDv+gbBuxzfsXBRhL/Og1DMfHiLeFoDPN+axz1igeIIXlTLYZJ9YW0uhpD5LW/IDLa8r8H9KXRexk1bHw2Mifx56mdQvAcLbowgJhil4K5PnbgCpav97BSpWc62pAl0jyeUEWhrKEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38KtaqXSFng6jLn2sPIZ0nnrIVSyMxRGlox7P9LTs8I=; b=ORQ513IOtbgJrXBIww8OzbVYBfybOp5sq5q9xErjtdJWii3pIoOjzVOYZuMxomI72CyJ9gjA987Uhdx8Uj2BxYLYpHX9d0eAiWv5azkY+/ePHn3B6Kzeb8Lninf495pkSiH8FASE+4o9OVCVM4LBSrqqnJP9C34Im747RKWFgAQ= Received: from BYAPR04MB4965.namprd04.prod.outlook.com (2603:10b6:a03:4d::25) by BYAPR04MB4038.namprd04.prod.outlook.com (2603:10b6:a02:af::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.16; Sun, 2 Aug 2020 22:54:48 +0000 Received: from BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::98a4:d2c9:58c5:dee4]) by BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::98a4:d2c9:58c5:dee4%5]) with mapi id 15.20.3239.021; Sun, 2 Aug 2020 22:54:48 +0000 From: Chaitanya Kulkarni To: Tianjia Zhang , "james.smart@broadcom.com" , "kbusch@kernel.org" , "axboe@fb.com" , "hch@lst.de" , "sagi@grimberg.me" , "jthumshirn@suse.de" , "james_p_freyensee@linux.intel.com" CC: "tianjia.zhang@alibaba.com" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" Subject: Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request() Thread-Topic: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request() Thread-Index: AQHWaL8mFLvfhLKbFkmZZIl4kdfgNQ== Date: Sun, 2 Aug 2020 22:54:48 +0000 Message-ID: References: <20200802111545.5566-1-tianjia.zhang@linux.alibaba.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.alibaba.com; dkim=none (message not signed) header.d=none;linux.alibaba.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [199.255.45.62] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: be6f7988-e869-4ef2-21fe-08d837370edd x-ms-traffictypediagnostic: BYAPR04MB4038: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:1443; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0TGJFwSlwkwGa6IhmUAvf13Uo2g105d18YxLeGQnk1PkG7wIb6XH1oCGWwDA9lC2o/IcK/EUZ3cHL7OwcIf2z95whOEDP8t49sArJPcvtqzoZw7uLL9ugfW9BCJbs3lycwc02aYUBBGXwCMr6Zbqvg9lHUrnjhgb2iLV7iBO5IT42AO8X8wKvkRn2He8cB1/474OYi/zWRDJWGnsYcRJw4DrTJ89JkcLkoT1VQB0qv896lKPG/yIbEXiOOkm+VodTa/RT1o3bMNR2zbZ1pMIdKr7sF135Bt3kQSJw4kleuFOFe9qYM3iCEc05WpUN0q+ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR04MB4965.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(396003)(39850400004)(346002)(136003)(366004)(9686003)(55016002)(53546011)(478600001)(2906002)(26005)(186003)(52536014)(6506007)(71200400001)(7416002)(110136005)(8936002)(66476007)(76116006)(8676002)(316002)(66946007)(7696005)(5660300002)(66446008)(64756008)(4326008)(33656002)(54906003)(86362001)(66556008)(4744005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: wcANrUiwe1++v/cpNSRKT9HOvs6DGhCQsGOiV1zcyexiD+LNJ/qJ6MBL4Wx7QGGlDsQ6ktYIgfxwMhp01OKb6ROAePtIdTu1JOL+l5JXfybodOoSS1y2Gle2onSNuTZMwDFwH1c4arot5ThFcUt/Q10Mjskro9e3iS3i/M1S38n0D8iafQPPz0J38A/80AIw4ZpYQGZ5mgDjqT9EPbZi4S/0Nqpbfd7Nffr598oLVIV7UfD1eOEbJAUJzDvelCTYWo0Th5ZgWxKKtwoQsh/0sbIA4yxWlKtoU0J3+Emyq7op8bVP3EIzXXL2rnY6QaxVQejg33sj/sUwU0H44JFjjy3G7OvafHynkDtdVsyQAHbOagQ6UjTEM7fSWOw9KliXePXvVA2TiHwJIJZMxyBS4BUl0eTy8fUHmNuUp0vivovGa/q9tzrOX1WlP08w/yfMqxODa9QirfoagGrIJK3ukqGU8i8LOOAU+cMeAijqz6vnRn8CB8QKU6P8H0byq6zcxaFoH2mjVbzU4a2+9U+FZiIhc6qG5pEsaXtjzWaEaCAEumTf2ddRfjs+3rmu/WMtD1vksyjeCcynxxOUUCDSCqGS6iConXgEyinm/tQr+VODGOLCvCdDU5PO7GGohuBB7ZHSKNOWZNL3/LLaNKr82w== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR04MB4965.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be6f7988-e869-4ef2-21fe-08d837370edd X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2020 22:54:48.4263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eiYQzqQk7TaWadOF+PPdiRIBLSsoVk+sD/mEI/nAR+zOh/QVbhIpGLQkPyTvMx0Uyyd7UEr1NIwuA/115joWJQD2qxHCx1oRv0tJgb6eWLk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4038 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/20 04:22, Tianjia Zhang wrote:=0A= > On an error exit path, a negative error code should be returned=0A= > instead of a positive return value.=0A= > =0A= > Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")= =0A= > Cc: James Smart=0A= > Signed-off-by: Tianjia Zhang=0A= =0A= Looks good.=0A= =0A= Reviewed-by: Chaitanya Kulkarni =0A=