From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Balbir Singh <sblbir@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"ssomesh@amazon.com" <ssomesh@amazon.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"hch@lst.de" <hch@lst.de>, "mst@redhat.com" <mst@redhat.com>
Subject: Re: [resend v1 1/5] block/genhd: Notify udev about capacity change
Date: Fri, 3 Jan 2020 06:16:39 +0000 [thread overview]
Message-ID: <BYAPR04MB5749EE1549B30FCECEC1154B86230@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200102075315.22652-2-sblbir@amazon.com
On 01/01/2020 11:53 PM, Balbir Singh wrote:
> Allow block/genhd to notify user space (via udev) about disk size changes
> using a new helper disk_set_capacity(), which is a wrapper on top
> of set_capacity(). disk_set_capacity() will only notify via udev if
> the current capacity or the target capacity is not zero.
>
> Suggested-by: Christoph Hellwig<hch@lst.de>
> Signed-off-by: Someswarudu Sangaraju<ssomesh@amazon.com>
> Signed-off-by: Balbir Singh<sblbir@amazon.com>
> ---
Since disk_set_capacity(() is on the same line as set_capacity()
we should follow the same convention, which is :-
1. Avoid exporting symbol.
2. Mark new function in-line.
Unless there is a very specific reason for breaking the pattern.
Why not this (totally untested but easy convey above comment)
on the top of this patch ?
# git diff
diff --git a/block/genhd.c b/block/genhd.c
index 94faec98607b..ff6268970ddc 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -46,25 +46,6 @@ static void disk_add_events(struct gendisk *disk);
static void disk_del_events(struct gendisk *disk);
static void disk_release_events(struct gendisk *disk);
-/*
- * Set disk capacity and notify if the size is not currently
- * zero and will not be set to zero
- */
-void disk_set_capacity(struct gendisk *disk, sector_t size)
-{
- sector_t capacity = get_capacity(disk);
-
- set_capacity(disk, size);
- if (capacity != 0 && size != 0) {
- char *envp[] = { "RESIZE=1", NULL };
-
- kobject_uevent_env(&disk_to_dev(disk)->kobj,
KOBJ_CHANGE, envp);
- }
-}
-
-EXPORT_SYMBOL_GPL(disk_set_capacity);
-
-
void part_inc_in_flight(struct request_queue *q, struct hd_struct
*part, int rw)
{
if (queue_is_mq(q))
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index d5e87d7cc357..5e595a28f893 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -469,6 +469,22 @@ static inline void set_capacity(struct gendisk
*disk, sector_t size)
disk->part0.nr_sects = size;
}
+/*
+ * Set disk capacity and notify if the size is not currently
+ * zero and will not be set to zero
+ */
+static inline void disk_set_capacity(struct gendisk *disk, sector_t size)
+{
+ sector_t capacity = get_capacity(disk);
+
+ set_capacity(disk, size);
+ if (capacity != 0 && size != 0) {
+ char *envp[] = { "RESIZE=1", NULL };
+
+ kobject_uevent_env(&disk_to_dev(disk)->kobj,
KOBJ_CHANGE, envp);
+ }
+}
+
#ifdef CONFIG_SOLARIS_X86_PARTITION
next prev parent reply other threads:[~2020-01-03 6:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 7:53 [resend v1 0/5] Add support for block disk resize notification Balbir Singh
2020-01-02 7:53 ` [resend v1 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2020-01-03 6:16 ` Chaitanya Kulkarni [this message]
2020-01-04 4:44 ` Singh, Balbir
2020-01-04 22:32 ` Chaitanya Kulkarni
2020-01-08 15:02 ` hch
2020-01-07 3:32 ` Martin K. Petersen
2020-01-07 22:30 ` Singh, Balbir
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 15:04 ` hch
2020-01-21 19:57 ` Singh, Balbir
2020-01-02 7:53 ` [resend v1 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
2020-01-02 7:53 ` [resend v1 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2020-01-02 7:53 ` [resend v1 4/5] drivers/nvme/host/core.c: " Balbir Singh
2020-01-04 22:27 ` Chaitanya Kulkarni
2020-01-06 0:46 ` Singh, Balbir
2020-01-08 15:04 ` hch
2020-01-09 3:33 ` Martin K. Petersen
2020-01-09 13:12 ` Ewan D. Milne
2020-01-21 19:52 ` Singh, Balbir
2020-01-02 7:53 ` [resend v1 5/5] drivers/scsi/sd.c: " Balbir Singh
2020-01-02 22:21 ` Chaitanya Kulkarni
2020-01-03 0:23 ` Singh, Balbir
2020-01-07 3:48 ` Martin K. Petersen
2020-01-07 3:57 ` James Bottomley
2020-01-07 4:39 ` Martin K. Petersen
2020-01-07 21:37 ` Ewan D. Milne
2020-01-08 2:59 ` Martin K. Petersen
2020-01-08 21:27 ` Ewan D. Milne
2020-01-07 22:28 ` Singh, Balbir
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 4:20 ` Singh, Balbir
2020-01-08 21:32 ` Ewan D. Milne
2020-01-08 15:06 ` Christoph Hellwig
2020-01-09 2:53 ` Martin K. Petersen
2020-01-06 5:59 ` [resend v1 0/5] Add support for block disk resize notification Bob Liu
2020-01-06 8:47 ` Singh, Balbir
2020-01-06 9:08 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB5749EE1549B30FCECEC1154B86230@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mst@redhat.com \
--cc=sblbir@amazon.com \
--cc=ssomesh@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).