From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jth@kernel.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH v9 1/2] fs: New zonefs file system
Date: Tue, 28 Jan 2020 01:34:52 +0000 [thread overview]
Message-ID: <BYAPR04MB581681ADF3F2F02BBF6A1B20E70A0@BYAPR04MB5816.namprd04.prod.outlook.com> (raw)
In-Reply-To: CAHk-=whHZzyaRKu5WXTE7_mPaQPf-E-r=cZ+8YGVK5RPbzjt1g@mail.gmail.com
On 2020/01/28 10:28, Linus Torvalds wrote:
> On Mon, Jan 27, 2020 at 5:26 PM Damien Le Moal <Damien.LeMoal@wdc.com> wrote:
>>
>> Yes, good catch. Furthermore, since this array is used only in
>> zonefs_create_zgroup(), I moved its declaration on-stack in that function.
>
> What?
>
> Making it _local_ to that function makes sense, but not on stack.
> Please keep it "static const char *[]" so that it isn't copied onto
> the stack.
Done. Thanks.
>
> Linus
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2020-01-28 1:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 12:49 [PATCH v9 1/2] fs: New zonefs file system Markus Elfring
2020-01-28 1:26 ` Damien Le Moal
2020-01-28 1:28 ` Linus Torvalds
2020-01-28 1:34 ` Damien Le Moal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-28 16:24 Markus Elfring
2020-01-29 4:14 ` Damien Le Moal
2020-01-28 15:34 Markus Elfring
2020-01-29 4:13 ` Damien Le Moal
2020-01-27 10:05 [PATCH v9 0/2] " Damien Le Moal
2020-01-27 10:05 ` [PATCH v9 1/2] fs: " Damien Le Moal
2020-01-28 17:46 ` Darrick J. Wong
2020-01-29 13:06 ` Damien Le Moal
2020-01-29 21:33 ` Dave Chinner
2020-01-30 3:00 ` Damien Le Moal
2020-01-30 22:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB581681ADF3F2F02BBF6A1B20E70A0@BYAPR04MB5816.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Markus.Elfring@web.de \
--cc=Naohiro.Aota@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).