From: Pawel Laszczak <pawell@cadence.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lukasz Tyrala <ltyrala@cadence.com>,
Alan Douglas <adouglas@cadence.com>
Subject: RE: [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver
Date: Thu, 2 Aug 2018 04:26:45 +0000 [thread overview]
Message-ID: <BYAPR07MB4709106F8160EBF0F3B5DBB4DD2C0@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)
In-Reply-To: <82e8093d-eb6b-ea04-7d36-54ee27df3e06@ti.com>
> > This patch set introduce new Cadence USBSSP DRD driver to linux
> > kernel.
> >
> > The Cadence USBSSP DRD Driver s a highly configurable IP Core which
> > can be instantiated as Dual-Role Device (DRD), Peripheral Only and
> > Host Only (XHCI) configurations.
> >
> > The current driver has been validated with FPGA burned. We have
> > support for PCIe bus, which is used on FPGA prototyping.
> >
> > The host site of USBSSP controller is compliance with XHCI
> > specification, so it works with standard XHCI linux driver.
> >
> > Also, device side of USBSSP controller was designed in such way to
> > looks like XHCI. It means that most of logic of USBSSP controller is
> > also compliance with XHCI specification.
> >
> > Consequently, the USBSSP driver for peripheral mode is very similar to
> > XHCI driver.
> >
> > This version of driver supports only Device mode but DRD and Host mode
> > will be added in the future.
> >
>
> Based on the posting date this series looks like v3.
>
> You should add the version prefix to the patches next time.
> e.g. [PATCH v4 ...]
>
I wanted to start versioning driver after this set patch will be approved.
Also I have plan to add change-log after approval this patch set.
I now treat this patch set as Initial version of driver.
If my approach is incorrect please correct me ??
Maybe before approval the better versioning will be [PATCH vrc4] ?
> It is also recommended to add a Change-log in the cover letter explaining
> what changes were made in each revision.
>
I
> There are a bunch of checkpatch warnings in this series.
> You can use ./scripts/checkpatch.pl on the patches and fix the issues.
Yes I know, but most of them are related to "line over 80 characters"
and " quoted string split across lines" warnings. The first group I could correct
but then I will make readability worse.
To eliminate the second group I will have to enlarge the first group of warnings and
the number of characters in single line will be bigger than 100.
> > ---
> >
> > Pawel Laszczak (31):
> > usb: usbssp: Defined register maps and other useful structures.
> > usb: usbssp: Added some decoding functions.
> > usb: usbssp: Add trace events used in driver
> > usb: usbssp: Added USBSSP platform driver
> > usb: usbssp: Added first part of initialization sequence.
> > usb: usbssp: added template functions used by upper layer.
> > usb: usbssp: Initialization - added usbssp_mem_init
> > usb: usbssp: Added ring and segment handling functions.
> > usb: usbssp: add implementation of usbssp_mem_cleanup
> > usb: usbssp: added usbssp_trb_in_td function.
> > usb: usbssp: added function for stopping driver.
> > usb: usbssp: added functions for queuing commands.
> > usb: usbssp: addec procedure for handlin Port Status Change events.
> > usb: usbssp: added procedure handling command completion events.
> > usb: usbssp: added device controller error, transfer and SETUP
> > completion event.
> > usb: usbssp: added connect/disconnect procedures.
> > usb: usbssp: added implementation of usbssp_halt_endpoint function.
> > usb: usbssp: added handling of Port Reset event.
> > usb: usbssp: added support for USB enumeration process.
> > usb: usbssp: added queuing procedure for control transfer.
> > usb: usbssp: added queuing procedure for BULK and INT transfer.
> > usb: usbssp: added procedure removing request from transfer ring
> > usb: usbssp: added implementation of transfer events.
> > usb: usbssp: added detecting command timeout.
> > usb: usbssp: added implementation of usbssp interface.
> > usb: usbssp: added endpoint configuration functionality.
> > usb: usbssp: implements usbssp_gadget_ep_enable function
> > usb: usbssp: implemented usbssp_gadget_ep_disable function.
> > usb: usbssp: added support for LPM.
> > usb: usbssp: added support for TEST_MODE.
> > usb: usbssp: add pci to platform driver wrapper.
> >
> > drivers/usb/Kconfig | 2 +
> > drivers/usb/Makefile | 2 +
> > drivers/usb/usbssp/Kconfig | 29 +
> > drivers/usb/usbssp/Makefile | 15 +
> > drivers/usb/usbssp/gadget-dbg.c | 39 +
> > drivers/usb/usbssp/gadget-ep0.c | 571 +++++
> > drivers/usb/usbssp/gadget-ext-caps.h | 102 +
> > drivers/usb/usbssp/gadget-if.c | 569 +++++
> > drivers/usb/usbssp/gadget-mem.c | 1938 +++++++++++++++
> > drivers/usb/usbssp/gadget-port.c | 287 +++
> > drivers/usb/usbssp/gadget-ring.c | 3452 ++++++++++++++++++++++++++
> > drivers/usb/usbssp/gadget-trace.c | 13 +
> > drivers/usb/usbssp/gadget-trace.h | 482 ++++
> > drivers/usb/usbssp/gadget.c | 1909 ++++++++++++++
> > drivers/usb/usbssp/gadget.h | 2373 ++++++++++++++++++
> > drivers/usb/usbssp/usbssp-pci-wrap.c | 226 ++
> > drivers/usb/usbssp/usbssp-plat.c | 186 ++
> > 17 files changed, 12195 insertions(+) create mode 100644
> > drivers/usb/usbssp/Kconfig create mode 100644
> > drivers/usb/usbssp/Makefile create mode 100644
> > drivers/usb/usbssp/gadget-dbg.c create mode 100644
> > drivers/usb/usbssp/gadget-ep0.c create mode 100644
> > drivers/usb/usbssp/gadget-ext-caps.h
> > create mode 100644 drivers/usb/usbssp/gadget-if.c create mode 100644
> > drivers/usb/usbssp/gadget-mem.c create mode 100644
> > drivers/usb/usbssp/gadget-port.c create mode 100644
> > drivers/usb/usbssp/gadget-ring.c create mode 100644
> > drivers/usb/usbssp/gadget-trace.c create mode 100644
> > drivers/usb/usbssp/gadget-trace.h create mode 100644
> > drivers/usb/usbssp/gadget.c create mode 100644
> > drivers/usb/usbssp/gadget.h create mode 100644
> > drivers/usb/usbssp/usbssp-pci-wrap.c
> > create mode 100644 drivers/usb/usbssp/usbssp-plat.c
> >
>
> --
cheers,
Pawel
next prev parent reply other threads:[~2018-08-02 4:31 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 17:57 [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver Pawel Laszczak
2018-07-19 17:57 ` [PATCH 01/31] usb: usbssp: Defined register maps and other useful structures Pawel Laszczak
2018-07-19 17:57 ` [PATCH 02/31] usb: usbssp: Added some decoding functions Pawel Laszczak
2018-09-10 18:18 ` Greg Kroah-Hartman
2018-09-11 5:48 ` Felipe Balbi
2018-09-11 8:12 ` Greg Kroah-Hartman
2018-09-11 9:01 ` Pawel Laszczak
2018-07-19 17:57 ` [PATCH 03/31] usb: usbssp: Add trace events used in driver Pawel Laszczak
2018-07-19 17:57 ` [PATCH 04/31] usb: usbssp: Added USBSSP platform driver Pawel Laszczak
2018-08-01 12:24 ` Roger Quadros
2018-08-02 6:25 ` Pawel Laszczak
2018-08-02 13:28 ` Roger Quadros
2018-07-19 17:57 ` [PATCH 05/31] usb: usbssp: Added first part of initialization sequence Pawel Laszczak
2018-08-03 10:17 ` Roger Quadros
2018-08-06 8:57 ` Pawel Laszczak
2018-08-06 10:33 ` Roger Quadros
2018-08-06 12:03 ` Pawel Laszczak
2018-07-19 17:57 ` [PATCH 06/31] usb: usbssp: added template functions used by upper layer Pawel Laszczak
2018-08-03 10:42 ` Roger Quadros
2018-08-04 6:37 ` Pawel Laszczak
2018-08-06 8:57 ` Roger Quadros
2018-08-06 11:40 ` Pawel Laszczak
2018-07-19 17:57 ` [PATCH 07/31] usb: usbssp: Initialization - added usbssp_mem_init Pawel Laszczak
2018-07-19 17:57 ` [PATCH 08/31] usb: usbssp: Added ring and segment handling functions Pawel Laszczak
2018-07-19 17:57 ` [PATCH 09/31] usb: usbssp: add implementation of usbssp_mem_cleanup Pawel Laszczak
2018-07-19 17:57 ` [PATCH 10/31] usb: usbssp: added usbssp_trb_in_td function Pawel Laszczak
2018-07-19 17:57 ` [PATCH 11/31] usb: usbssp: added function for stopping driver Pawel Laszczak
2018-07-19 17:57 ` [PATCH 12/31] usb: usbssp: added functions for queuing commands Pawel Laszczak
2018-07-19 17:57 ` [PATCH 13/31] usb: usbssp: addec procedure for handlin Port Status Change events Pawel Laszczak
2018-07-19 17:57 ` [PATCH 14/31] usb: usbssp: added procedure handling command completion events Pawel Laszczak
2018-07-19 17:57 ` [PATCH 15/31] usb: usbssp: added device controller error, transfer and SETUP completion event Pawel Laszczak
2018-07-19 17:57 ` [PATCH 16/31] usb: usbssp: added connect/disconnect procedures Pawel Laszczak
2018-07-19 17:57 ` [PATCH 17/31] usb: usbssp: added implementation of usbssp_halt_endpoint function Pawel Laszczak
2018-07-19 17:57 ` [PATCH 18/31] usb: usbssp: added handling of Port Reset event Pawel Laszczak
2018-07-19 17:57 ` [PATCH 19/31] usb: usbssp: added support for USB enumeration process Pawel Laszczak
2018-07-19 17:57 ` [PATCH 20/31] usb: usbssp: added queuing procedure for control transfer Pawel Laszczak
2018-07-19 17:57 ` [PATCH 21/31] usb: usbssp: added queuing procedure for BULK and INT transfer Pawel Laszczak
2018-07-19 17:57 ` [PATCH 22/31] usb: usbssp: added procedure removing request from transfer ring Pawel Laszczak
2018-07-19 17:57 ` [PATCH 23/31] usb: usbssp: added implementation of transfer events Pawel Laszczak
2018-07-19 17:57 ` [PATCH 24/31] usb: usbssp: added detecting command timeout Pawel Laszczak
2018-07-19 17:57 ` [PATCH 25/31] usb: usbssp: added implementation of usbssp interface Pawel Laszczak
2018-07-19 17:57 ` [PATCH 26/31] usb: usbssp: added endpoint configuration functionality Pawel Laszczak
2018-07-19 17:58 ` [PATCH 27/31] usb: usbssp: implements usbssp_gadget_ep_enable function Pawel Laszczak
2018-07-19 17:58 ` [PATCH 28/31] usb: usbssp: implemented usbssp_gadget_ep_disable function Pawel Laszczak
2018-07-19 17:58 ` [PATCH 29/31] usb: usbssp: added support for LPM Pawel Laszczak
2018-07-19 17:58 ` [PATCH 30/31] usb: usbssp: added support for TEST_MODE Pawel Laszczak
2018-07-19 17:58 ` [PATCH 31/31] usb: usbssp: add pci to platform driver wrapper Pawel Laszczak
2018-08-01 11:27 ` [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver Roger Quadros
2018-08-02 4:26 ` Pawel Laszczak [this message]
2018-08-02 13:24 ` Roger Quadros
2018-09-10 18:21 ` Greg Kroah-Hartman
2018-08-17 21:05 ` Bin Liu
2018-08-21 14:50 ` Pawel Laszczak
2018-09-10 18:20 ` Greg Kroah-Hartman
2018-09-10 18:16 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2018-07-12 5:46 Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB4709106F8160EBF0F3B5DBB4DD2C0@BYAPR07MB4709.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=adouglas@cadence.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltyrala@cadence.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).