From: Pawel Laszczak <pawell@cadence.com>
To: Roger Quadros <rogerq@ti.com>,
"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
Jayshri Dajiram Pawar <jpawar@cadence.com>,
Rahul Kumar <kurahul@cadence.com>,
Anil Joy Varughese <aniljoy@cadence.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>
Subject: RE: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Mon, 12 Aug 2019 09:43:31 +0000 [thread overview]
Message-ID: <BYAPR07MB4709F306EC472B7AABEB7D4CDDD30@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)
In-Reply-To: <1e557bcf-2d50-f600-0e81-1f9fba5499a1@ti.com>
Hi,
>
>On 11/08/2019 14:59, Pawel Laszczak wrote:
>> Hi,
>>
>>>
>>> On 21/07/2019 21:32, Pawel Laszczak wrote:
>>>> This patch introduce new Cadence USBSS DRD driver to Linux kernel.
>>>>
>>>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>>>> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>>>> Host Only (XHCI)configurations.
>>>>
>>>> The current driver has been validated with FPGA platform. We have
>>>> support for PCIe bus, which is used on FPGA prototyping.
>>>>
>>>> The host side of USBSS-DRD controller is compliant with XHCI
>>>> specification, so it works with standard XHCI Linux driver.
>>>>
>>>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>>> ---
>>>> drivers/usb/Kconfig | 2 +
>>>> drivers/usb/Makefile | 2 +
>>>> drivers/usb/cdns3/Kconfig | 46 +
>>>> drivers/usb/cdns3/Makefile | 17 +
>>>> drivers/usb/cdns3/cdns3-pci-wrap.c | 203 +++
>>>> drivers/usb/cdns3/core.c | 554 +++++++
>>>> drivers/usb/cdns3/core.h | 109 ++
>>>> drivers/usb/cdns3/debug.h | 171 ++
>>>> drivers/usb/cdns3/debugfs.c | 87 ++
>>>> drivers/usb/cdns3/drd.c | 390 +++++
>>>> drivers/usb/cdns3/drd.h | 166 ++
>>>> drivers/usb/cdns3/ep0.c | 914 +++++++++++
>>>> drivers/usb/cdns3/gadget-export.h | 28 +
>>>> drivers/usb/cdns3/gadget.c | 2338 ++++++++++++++++++++++++++++
>>>> drivers/usb/cdns3/gadget.h | 1321 ++++++++++++++++
>>>> drivers/usb/cdns3/host-export.h | 28 +
>>>> drivers/usb/cdns3/host.c | 71 +
>>>> drivers/usb/cdns3/trace.c | 11 +
>>>> drivers/usb/cdns3/trace.h | 493 ++++++
>>>> 19 files changed, 6951 insertions(+)
>>>> create mode 100644 drivers/usb/cdns3/Kconfig
>>>> create mode 100644 drivers/usb/cdns3/Makefile
>>>> create mode 100644 drivers/usb/cdns3/cdns3-pci-wrap.c
>>>> create mode 100644 drivers/usb/cdns3/core.c
>>>> create mode 100644 drivers/usb/cdns3/core.h
>>>> create mode 100644 drivers/usb/cdns3/debug.h
>>>> create mode 100644 drivers/usb/cdns3/debugfs.c
>>>> create mode 100644 drivers/usb/cdns3/drd.c
>>>> create mode 100644 drivers/usb/cdns3/drd.h
>>>> create mode 100644 drivers/usb/cdns3/ep0.c
>>>> create mode 100644 drivers/usb/cdns3/gadget-export.h
>>>> create mode 100644 drivers/usb/cdns3/gadget.c
>>>> create mode 100644 drivers/usb/cdns3/gadget.h
>>>> create mode 100644 drivers/usb/cdns3/host-export.h
>>>> create mode 100644 drivers/usb/cdns3/host.c
>>>> create mode 100644 drivers/usb/cdns3/trace.c
>>>> create mode 100644 drivers/usb/cdns3/trace.h
>>>>
>>>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>>>> index e4b27413f528..c2e78882f8c2 100644
>>>> --- a/drivers/usb/Kconfig
>>>> +++ b/drivers/usb/Kconfig
>>>> @@ -113,6 +113,8 @@ source "drivers/usb/usbip/Kconfig"
>>>>
>>>> endif
>>>>
<snip>
>>>> + real_role = cdsn3_real_role_switch_get(cdns->dev);
>>>> +
>>>> + current_role = role;
>>>> + dev_dbg(cdns->dev, "Switching role");
>>>> +
>>>> + ret = cdns3_role_start(cdns, real_role);
>>>> + if (ret) {
>>>> + /* Back to current role */
>>>> + dev_err(cdns->dev, "set %d has failed, back to %d\n",
>>>> + role, current_role);
>>>> + ret = cdns3_role_start(cdns, current_role);
>>>> + if (ret)
>>>> + dev_err(cdns->dev, "back to %d failed too\n",
>>>> + current_role);
>>>> + }
>>>> +exit:
>>>> + pm_runtime_put_sync(cdns->dev);
>>>> + return ret;
>>>> +}
>>>> +
>>>> +static const struct usb_role_switch_desc cdns3_switch_desc = {
>>>> + .set = cdns3_role_switch_set,
>>>> + .get = cdsn3_real_role_switch_get,
>>>> + .allow_userspace_control = true,
>>>
>>> how does user initiated cdns3_role_switch_set() via sysfs co-exist with role
>>> changes done by hardware events. e.g. ID/VBUS?
>>>
>>
>> Do you expect any issues whit this, have you seen any problem with this
>> on your platform ?
>>
>> I assume that it should work in this way:
>> 1. user change role by sysfs
>> 2. Driver change the role according with user request.
>> 3. If we receive correct ID/VBUS then role should not be changed
>> because new role is the same as current set in point 2.
>>
>
>I have not tested this series yet.
>My understanding is that if user sets role to "host" or "device" then it should
>remain in that role irrespective of ID/VBUS. Once user sets it to "none" then
>port should set role based on ID/VBUS.
According with your understanding it works the same way as by debugfs.
Now I have no doubts to remove debugfs.c file :)
>
>>
>>>> +};
>>>> +
>>>> +/**
>>>> + * cdns3_probe - probe for cdns3 core device
>>>> + * @pdev: Pointer to cdns3 core platform device
>>>> + *
>>>> + * Returns 0 on success otherwise negative errno
>>>> + */
>>>> +static int cdns3_probe(struct platform_device *pdev)
<snip>
>>>> + * Returns 0 on success otherwise negative errno
>>>> + */
>>>> +int cdns3_drd_update_mode(struct cdns3 *cdns)
>>>> +{
>>>> + int ret = 0;
>>>> +
>>>> + if (cdns->desired_dr_mode == cdns->current_dr_mode)
>>>> + return ret;
>>>> +
>>>> + switch (cdns->desired_dr_mode) {
>>>> + case USB_DR_MODE_PERIPHERAL:
>>>> + ret = cdns3_set_mode(cdns, USB_DR_MODE_PERIPHERAL);
>>>> + break;
>>>> + case USB_DR_MODE_HOST:
>>>> + ret = cdns3_set_mode(cdns, USB_DR_MODE_HOST);
>>>> + break;
>>>> + case USB_DR_MODE_OTG:
>>>> + ret = cdns3_init_otg_mode(cdns);
>>>> + break;
>>>> + default:
>>>> + dev_err(cdns->dev, "Unsupported mode of operation %d\n",
>>>> + cdns->dr_mode);
>>>> + return -EINVAL;
>>>> + }
>>>> +
>>>> + return ret;
>>>> +}
>>>> +
>>>> +static irqreturn_t cdns3_drd_thread_irq(int irq, void *data)
>>>> +{
>>>> + struct cdns3 *cdns = data;
>>>> +
>>>> + usb_role_switch_set_role(cdns->role_sw, cdns->role);
>>>
>>> How to ensure that HW events don't step over user chosen role?
>>
>> I need to think about this and find out how to test it and eventually force
>> such cases.
>>
>> But I assume that after attaching/detaching plug the user chosen role can
>> be forgotten.
>>
>
>No. Only when user sets role to none then role should be based on HW.
Ok, I will try to test it in next week.
>>>
>
><snip>
Cheers,
Pawell
next prev parent reply other threads:[~2019-08-12 9:43 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 18:32 [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 1/6] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 2/6] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2019-07-21 19:05 ` Joe Perches
2019-07-21 20:45 ` Alan Stern
2019-07-21 20:54 ` Joe Perches
2019-07-22 10:06 ` Pawel Laszczak
2019-07-22 11:49 ` gregkh
2019-07-21 18:32 ` [PATCH v10 3/6] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2019-07-21 19:07 ` Joe Perches
2019-07-22 10:12 ` Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 4/6] usb:common Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2019-07-31 3:36 ` Pawel Laszczak
2019-08-07 12:08 ` Roger Quadros
2019-08-11 11:59 ` Pawel Laszczak
2019-08-12 8:45 ` Roger Quadros
2019-08-12 9:43 ` Pawel Laszczak [this message]
2019-08-12 10:31 ` Heikki Krogerus
2019-08-12 11:05 ` Roger Quadros
2019-08-12 12:46 ` Felipe Balbi
2019-08-12 13:04 ` Roger Quadros
2019-08-13 5:15 ` Felipe Balbi
2019-08-13 7:30 ` Chunfeng Yun
2019-08-13 7:48 ` Roger Quadros
2019-08-13 8:50 ` Chunfeng Yun
2019-08-12 10:05 ` Roger Quadros
2019-08-12 11:10 ` Pawel Laszczak
2019-08-14 13:32 ` Roger Quadros
2019-08-15 6:10 ` Felipe Balbi
2019-08-19 8:20 ` Pawel Laszczak
2019-08-14 13:38 ` Roger Quadros
2019-08-14 14:30 ` Pawel Laszczak
2019-08-15 11:22 ` Roger Quadros
2019-08-19 10:30 ` Pawel Laszczak
2019-08-19 10:59 ` Roger Quadros
2019-08-23 8:53 ` Vignesh Raghavendra
2019-08-23 9:39 ` Pawel Laszczak
2019-08-26 2:16 ` Peter Chen
2019-08-26 7:53 ` Pawel Laszczak
2019-07-21 18:32 ` [PATCH v10 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer Pawel Laszczak
2019-07-21 19:03 ` [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver Pavel Machek
2019-07-22 9:58 ` Pawel Laszczak
2019-07-22 11:48 ` gregkh
2019-07-22 11:56 ` Pavel Machek
2019-07-22 12:11 ` gregkh
2019-07-22 12:11 ` Pawel Laszczak
2019-07-22 21:00 ` Pavel Machek
2019-07-23 4:32 ` Pawel Laszczak
2019-08-07 11:05 ` Roger Quadros
2019-08-08 4:12 ` Pawel Laszczak
2019-08-09 10:36 ` Roger Quadros
2019-08-09 10:44 ` Felipe Balbi
2019-08-13 8:22 ` Pavel Machek
2019-08-15 12:12 ` Roger Quadros
2019-08-15 14:39 ` Alan Stern
2019-08-19 12:08 ` Roger Quadros
2019-08-19 14:19 ` Alan Stern
2019-08-21 9:54 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB4709F306EC472B7AABEB7D4CDDD30@BYAPR07MB4709.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=aniljoy@cadence.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=jpawar@cadence.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).