From: Pawel Laszczak <pawell@cadence.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH][next] usb: cdnsp: Fix spelling mistake "delagete" -> "delegate"
Date: Thu, 4 Feb 2021 05:07:16 +0000 [thread overview]
Message-ID: <BYAPR07MB5381361C15E436BE54D25C93DDB39@BYAPR07MB5381.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20210203130440.GV2696@kadam>
Hi Dan,
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a spelling mistake in a literal string. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/usb/cdns3/cdnsp-ep0.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c
>> index e2b1bcb3f80e..e30931ebc870 100644
>> --- a/drivers/usb/cdns3/cdnsp-ep0.c
>> +++ b/drivers/usb/cdns3/cdnsp-ep0.c
>> @@ -45,7 +45,7 @@ static int cdnsp_ep0_delegate_req(struct cdnsp_device *pdev,
>> {
>> int ret;
>>
>> - trace_cdnsp_ep0_request("delagete");
>> + trace_cdnsp_ep0_request("delegate");
>>
>
>This printk is useless and should just be deleted. Use ftrace instead.
Maybe this printk is redundant but it's more comfortable in use.
To debug I can simply enable cdns-dev events (echo cdnsp-dev:* > set_event)
and I will get the full picture of what the driver is doing.
Otherwise, I must remember which function I need to add to set_ftrace_filter.
Of course, by default I can simply add all cdnsp* functions (echo cdnsp* > set_ftrace_filter) but it
increases the trace log and makes it a little more difficult to analyze.
So maybe in some cases we shouldn't complain for such printk ?
It's my private opinion and not necessarily correct :)
Thanks,
Pawel Laszczak
>
>regards,
>dan carpenter
next prev parent reply other threads:[~2021-02-04 5:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 11:12 [PATCH][next] usb: cdnsp: Fix spelling mistake "delagete" -> "delegate" Colin King
2021-02-03 13:06 ` Dan Carpenter
2021-02-04 5:07 ` Pawel Laszczak [this message]
2021-02-04 6:30 ` Greg Kroah-Hartman
2021-02-04 9:25 ` Pawel Laszczak
2021-02-04 9:25 ` Colin Ian King
-- strict thread matches above, loose matches on Subject: below --
2020-12-14 22:28 [PATCH][next] usb: cdnsp: fix " Colin King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB5381361C15E436BE54D25C93DDB39@BYAPR07MB5381.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).