From: "Zhang, Qiang" <Qiang.Zhang@windriver.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rafael Wysocki <rafael.j.wysocki@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: 回复: [PATCH] PM: remove PF_WQ_WORKER mask
Date: Thu, 28 Jan 2021 01:42:28 +0000 [thread overview]
Message-ID: <BYAPR11MB2632E0A742A67B72536BF844FFBA9@BYAPR11MB2632.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJZ5v0j-JxkPPdbUMiG3oqRs7O-35a0G2ryEHHKy-PagczizGA@mail.gmail.com>
________________________________________
发件人: Rafael J. Wysocki <rafael@kernel.org>
发送时间: 2021年1月28日 2:16
收件人: Zhang, Qiang
抄送: Rafael Wysocki; Linux PM; Linux Kernel Mailing List
主题: Re: [PATCH] PM: remove PF_WQ_WORKER mask
[Please note: This e-mail is from an EXTERNAL e-mail address]
On Mon, Jan 25, 2021 at 5:01 AM <qiang.zhang@windriver.com> wrote:
>
> From: Zqiang <qiang.zhang@windriver.com>
>
> Due to kworker also is kernel thread, it's already included
> PF_KTHREAD mask, so remove PF_WQ_WORKER mask.
>So you are saying that all threads having PF_WQ_WORKER set must also
>have PF_KTHREAD set, right?
yes
#define PF_KTHREAD 0x00200000
#define PF_WQ_WORKER 0x00000020
I tracing kwoker's task->flags as follows:
comm kworker/1:0, cpu 1, task->flags 0x4208060, delayed 3, func intel_fbc_work_fn
Thanks
Qiang
>That sounds correct, so I'm going to rewrite the changelog and apply
>the patch as 5.12 material, thanks!
> Signed-off-by: Zqiang <qiang.zhang@windriver.com>
> ---
> kernel/power/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 45b054b7b5ec..50cc63534486 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -235,7 +235,7 @@ void thaw_kernel_threads(void)
>
> read_lock(&tasklist_lock);
> for_each_process_thread(g, p) {
> - if (p->flags & (PF_KTHREAD | PF_WQ_WORKER))
> + if (p->flags & PF_KTHREAD)
> __thaw_task(p);
> }
> read_unlock(&tasklist_lock);
> --
> 2.17.1
>
prev parent reply other threads:[~2021-01-28 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 4:18 [PATCH] PM: remove PF_WQ_WORKER mask qiang.zhang
2021-01-27 3:18 ` 回复: " Zhang, Qiang
2021-01-27 18:16 ` Rafael J. Wysocki
2021-01-28 1:42 ` Zhang, Qiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB2632E0A742A67B72536BF844FFBA9@BYAPR11MB2632.namprd11.prod.outlook.com \
--to=qiang.zhang@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).