* [PATCH] ACPICA: fix if condition
@ 2021-07-03 9:12 gushengxian
2021-07-03 9:38 ` Joe Perches
2021-07-09 14:38 ` Moore, Robert
0 siblings, 2 replies; 3+ messages in thread
From: gushengxian @ 2021-07-03 9:12 UTC (permalink / raw)
To: robert.moore, erik.kaneda, rafael.j.wysocki, lenb
Cc: linux-acpi, devel, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
Fix if condition.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
drivers/acpi/acpica/dswexec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/dswexec.c b/drivers/acpi/acpica/dswexec.c
index 41ba7773fd10..c4cd61469e1f 100644
--- a/drivers/acpi/acpica/dswexec.c
+++ b/drivers/acpi/acpica/dswexec.c
@@ -561,8 +561,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
op->common.
node->object,
NULL);
- if ACPI_FAILURE
- (status) {
+ if (ACPI_FAILURE(status)) {
ACPI_EXCEPTION((AE_INFO, status,
"While writing to buffer field"));
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPICA: fix if condition
2021-07-03 9:12 [PATCH] ACPICA: fix if condition gushengxian
@ 2021-07-03 9:38 ` Joe Perches
2021-07-09 14:38 ` Moore, Robert
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2021-07-03 9:38 UTC (permalink / raw)
To: gushengxian, robert.moore, erik.kaneda, rafael.j.wysocki, lenb
Cc: linux-acpi, devel, linux-kernel, gushengxian
On Sat, 2021-07-03 at 02:12 -0700, gushengxian wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> Fix if condition.
A few more of these...
drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_START, ret, battery))
drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_STOP, ret, battery))
drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(SET_START, &ret, param)) {
drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(SET_STOP, &ret, param)) {
drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_START, &ret, battery)) {
drivers/platform/x86/thinkpad_acpi.c: if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_STOP, &ret, battery)) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] ACPICA: fix if condition
2021-07-03 9:12 [PATCH] ACPICA: fix if condition gushengxian
2021-07-03 9:38 ` Joe Perches
@ 2021-07-09 14:38 ` Moore, Robert
1 sibling, 0 replies; 3+ messages in thread
From: Moore, Robert @ 2021-07-09 14:38 UTC (permalink / raw)
To: gushengxian, erik.kaneda, Wysocki, Rafael J, lenb
Cc: linux-acpi, devel, linux-kernel, gushengxian
Got it,
Thanks.
-----Original Message-----
From: gushengxian <gushengxian507419@gmail.com>
Sent: Saturday, July 03, 2021 2:12 AM
To: Moore, Robert <robert.moore@intel.com>; erik.kaneda@intel.com; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; lenb@kernel.org
Cc: linux-acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org; gushengxian <gushengxian@yulong.com>
Subject: [PATCH] ACPICA: fix if condition
From: gushengxian <gushengxian@yulong.com>
Fix if condition.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
drivers/acpi/acpica/dswexec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/dswexec.c b/drivers/acpi/acpica/dswexec.c index 41ba7773fd10..c4cd61469e1f 100644
--- a/drivers/acpi/acpica/dswexec.c
+++ b/drivers/acpi/acpica/dswexec.c
@@ -561,8 +561,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
op->common.
node->object,
NULL);
- if ACPI_FAILURE
- (status) {
+ if (ACPI_FAILURE(status)) {
ACPI_EXCEPTION((AE_INFO, status,
"While writing to buffer field"));
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-09 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-03 9:12 [PATCH] ACPICA: fix if condition gushengxian
2021-07-03 9:38 ` Joe Perches
2021-07-09 14:38 ` Moore, Robert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).