From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>,
Shardar Mohammed <smohammed@nvidia.com>,
Timo Alho <talho@nvidia.com>
Cc: "wsa@the-dreams.de" <wsa@the-dreams.de>,
"peda@axentia.se" <peda@axentia.se>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH V17 3/6] i2c: tegra: fix maximum transfer size
Date: Fri, 8 Feb 2019 18:25:10 +0000 [thread overview]
Message-ID: <BYAPR12MB33981B3AD88271597CC4F7F5C2690@BYAPR12MB3398.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3e4db3e9-8198-f1bf-f909-492bf1ff8c56@gmail.com>
> >>> static const struct i2c_adapter_quirks tegra194_i2c_quirks = {
> >>> .flags = I2C_AQ_NO_ZERO_LEN,
> >>> + .max_write_len = 65535 - I2C_PACKET_HEADER_SIZE,
> >>
> >> Ideally it should be SZ_64K - I2C_PACKET_HEADER_SIZE to not miss the one byte, otherwise good to me:
> >>
> >> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> >
> > With SZ_64K - I2C_PACKET_HEADR_Size, When we compute dma_buf_size = max_write_len + I2C_PACKET_HEADER_SIZE, dma_buf_size will be SZ_64K which is 0x10000 apbdma dma count limit should be < 64K meaning 65535 max is allowed
> >
>
> But it's for the GPCDMA, does it have the same 64K limit as APB DMA?
64K limit is for APBDMA. This patch has APBDMA support only. No GPCDMA support so buf size limit is based on APBDMA.
GPCDMA supports upto 1GB.
next prev parent reply other threads:[~2019-02-08 18:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 17:49 [PATCH V17 1/6] i2c: tegra: sort all the include headers alphabetically Sowjanya Komatineni
2019-02-08 17:49 ` [PATCH V17 2/6] i2c: tegra: add bus clear Master Support Sowjanya Komatineni
2019-02-08 17:49 ` [PATCH V17 3/6] i2c: tegra: fix maximum transfer size Sowjanya Komatineni
2019-02-08 18:06 ` Dmitry Osipenko
2019-02-08 18:17 ` Sowjanya Komatineni
2019-02-08 18:21 ` Dmitry Osipenko
2019-02-08 18:25 ` Sowjanya Komatineni [this message]
2019-02-08 18:28 ` Sowjanya Komatineni
2019-02-08 18:34 ` Sowjanya Komatineni
2019-02-08 18:37 ` Sowjanya Komatineni
2019-02-08 18:38 ` Dmitry Osipenko
2019-02-08 17:49 ` [PATCH V17 4/6] i2c: tegra: Add DMA support Sowjanya Komatineni
2019-02-08 17:49 ` [PATCH V17 5/6] i2c: tegra: update transfer timeout Sowjanya Komatineni
2019-02-08 17:49 ` [PATCH V17 6/6] i2c: tegra: add i2c interface timing support Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB33981B3AD88271597CC4F7F5C2690@BYAPR12MB3398.namprd12.prod.outlook.com \
--to=skomatineni@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=peda@axentia.se \
--cc=smohammed@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).