From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Wolfram Sang <wsa@the-dreams.de>, Dmitry Osipenko <digetx@gmail.com>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>,
"Shardar Mohammed" <smohammed@nvidia.com>,
Timo Alho <talho@nvidia.com>, "peda@axentia.se" <peda@axentia.se>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: RE: [PATCH V18 4/6] i2c: tegra: Add DMA support
Date: Mon, 11 Feb 2019 16:26:04 +0000 [thread overview]
Message-ID: <BYAPR12MB3398E24A9C3AC87F601DA1A2C2640@BYAPR12MB3398.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190211132851.pxrawigdgggoc32k@ninjato>
> > > I am not sure if you are aware of this document, so I mention it:
> > >
> > > Documentation/i2c/DMA-considerations
> > >
> > > I am not pushing you to use the i2c_get_dma_safe_msg_buf() helpers,
> > > just wanted to make sure you know about them. I am also fine with an
> > > incremental patch on top of this if you want to add usage of those
> > > helpers somewhen later.
> >
> > At least I was not aware of those helpers. It looks to me that the
> > approach of having a statically allocated buffer is more optimal than
> > having to allocate and map the buffer on each transfer.
>
> Can be argued, yes.
>
> > >> /* Match table for of_platform binding */ static const struct
> > >> of_device_id tegra_i2c_of_match[] = {
> > >> { .compatible = "nvidia,tegra194-i2c", .data = &tegra194_i2c_hw,
> > >> },
> > >> + { .compatible = "nvidia,tegra186-i2c", .data = &tegra186_i2c_hw,
> > >> +},
> > >> { .compatible = "nvidia,tegra210-i2c", .data = &tegra210_i2c_hw, },
> > >> { .compatible = "nvidia,tegra124-i2c", .data = &tegra124_i2c_hw, },
> > >> { .compatible = "nvidia,tegra114-i2c", .data = &tegra114_i2c_hw,
> > >> },
> > >
> > > Shouldn't this be a seperate patch?
> >
> > I asked for this change and no, it shouldn't be a separate patch as it
> > adds "has_apb_dma = false" property for T186 that older Tegra's have
> > as "true". Without this change T186 uses tegra_i2c_hw_feature of T210,
> > see [0]. Hence this change is absolutely correct and appropriate for
> > this patch.
>
> Then please update the patch description to contain this information.
>
Will update commit message about the reason for adding has_apb_dma
>
>
> > > This should definately be a seperate patch. While I am all for
> > > taking it, are you sure it does not regress on older Tegra platforms?
> > >
> >
> > All the patches are tested on older Tegra's (T20/T30 specifically by
> > me) and we fixed several bugs that were regressing them over the few
> > versions of the patchset. I specifically asked for this change for
> > older Tegra's because the APBDMA driver (T20-T210) is getting
> > registered from the module-init level and hence I2C driver probe is
> > always getting deferred. I'm not sure that it's worth to factor out
> > this hunk into a separate patch as it's directly related to the DMA
> > support addition, maybe worth to mention why this is needed in the
> > commit message.
>
> At least, this, yes.
>
Will update commit message to reflect this...
>
>
next prev parent reply other threads:[~2019-02-11 16:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 18:59 [PATCH V18 1/6] i2c: tegra: sort all the include headers alphabetically Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 2/6] i2c: tegra: add bus clear Master Support Sowjanya Komatineni
2019-02-11 12:44 ` Wolfram Sang
2019-02-11 20:18 ` Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 3/6] i2c: tegra: fix maximum transfer size Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 4/6] i2c: tegra: Add DMA support Sowjanya Komatineni
2019-02-11 12:55 ` Wolfram Sang
2019-02-11 13:22 ` Dmitry Osipenko
2019-02-11 13:28 ` Wolfram Sang
2019-02-11 16:26 ` Sowjanya Komatineni [this message]
2019-02-08 18:59 ` [PATCH V18 5/6] i2c: tegra: update transfer timeout Sowjanya Komatineni
2019-02-08 18:59 ` [PATCH V18 6/6] i2c: tegra: add i2c interface timing support Sowjanya Komatineni
2019-02-11 13:03 ` Wolfram Sang
2019-02-11 16:23 ` Sowjanya Komatineni
2019-02-11 12:45 ` [PATCH V18 1/6] i2c: tegra: sort all the include headers alphabetically Wolfram Sang
2019-02-11 13:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB3398E24A9C3AC87F601DA1A2C2640@BYAPR12MB3398.namprd12.prod.outlook.com \
--to=skomatineni@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=peda@axentia.se \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).