From: Manish Rangankar <mrangankar@marvell.com>
To: Yue Haibing <yuehaibing@huawei.com>,
"QLogic-Storage-Upstream@cavium.com"
<QLogic-Storage-Upstream@cavium.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev' and 'udev'
Date: Fri, 10 May 2019 05:28:18 +0000 [thread overview]
Message-ID: <BYAPR18MB248596EAD386EC09F380162DD80C0@BYAPR18MB2485.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190424080256.30012-1-yuehaibing@huawei.com>
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org <linux-scsi-
> owner@vger.kernel.org> On Behalf Of Yue Haibing
> Sent: Wednesday, April 24, 2019 1:33 PM
> To: QLogic-Storage-Upstream@cavium.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev'
> and 'udev'
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/qedi/qedi_iscsi.c: In function 'qedi_ep_connect':
> drivers/scsi/qedi/qedi_iscsi.c:813:23: warning: variable 'udev' set but not
> used [-Wunused-but-set-variable]
> drivers/scsi/qedi/qedi_iscsi.c:812:18: warning: variable 'cdev' set but not
> used [-Wunused-but-set-variable]
>
> They are never used since introduction.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/qedi/qedi_iscsi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
> index e4391ee..688a6d8 100644
> --- a/drivers/scsi/qedi/qedi_iscsi.c
> +++ b/drivers/scsi/qedi/qedi_iscsi.c
> @@ -809,8 +809,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
> struct qedi_endpoint *qedi_ep;
> struct sockaddr_in *addr;
> struct sockaddr_in6 *addr6;
> - struct qed_dev *cdev = NULL;
> - struct qedi_uio_dev *udev = NULL;
> struct iscsi_path path_req;
> u32 msg_type = ISCSI_KEVENT_IF_DOWN;
> u32 iscsi_cid = QEDI_CID_RESERVED;
> @@ -830,8 +828,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
> }
>
> qedi = iscsi_host_priv(shost);
> - cdev = qedi->cdev;
> - udev = qedi->udev;
>
> if (test_bit(QEDI_IN_OFFLINE, &qedi->flags) ||
> test_bit(QEDI_IN_RECOVERY, &qedi->flags)) {
> --
> 2.7.4
>
Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>
next prev parent reply other threads:[~2019-05-10 5:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 8:02 [PATCH -next] scsi: qedi: remove set but not used variables 'cdev' and 'udev' Yue Haibing
2019-05-10 5:28 ` Manish Rangankar [this message]
2019-05-13 22:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB248596EAD386EC09F380162DD80C0@BYAPR18MB2485.namprd18.prod.outlook.com \
--to=mrangankar@marvell.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).