RE: [PATCH v3 09/10] x86/hyperv: Remove hv_isolation_type_en_snp

From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: Dexuan Cui <decui@microsoft.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"arnd@arndb.de" <arnd@arndb.de>, "bp@alien8.de" <bp@alien8.de>,
	"brijesh.singh@amd.com" <brijesh.singh@amd.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"dave.hansen@intel.com" <dave.hansen@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"jane.chu@oracle.com" <jane.chu@oracle.com>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	KY Srinivasan <kys@microsoft.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"luto@kernel.org" <luto@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"sathyanarayanan.kuppuswamy@linux.intel.com" 
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>,
	jason <jason@zx2c4.com>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>,
	"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
	Anthony Davis <andavis@redhat.com>,
	Mark Heslin <mheslin@redhat.com>, vkuznets <vkuznets@redhat.com>,
	"xiaoyao.li@intel.com" <xiaoyao.li@intel.com>
Subject: RE: [PATCH v3 09/10] x86/hyperv: Remove hv_isolation_type_en_snp
Date: Thu, 24 Aug 2023 14:09:28 +0000	[thread overview]
Message-ID: <BYAPR21MB16885DE4D8C4F71F3D9F2B20D71DA@BYAPR21MB1688.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20230824080712.30327-10-decui@microsoft.com>

From: Dexuan Cui <decui@microsoft.com> Sent: Thursday, August 24, 2023 1:07 AM
> 
> In ms_hyperv_init_platform(), do not distinguish between a SNP VM with
> the paravisor and a SNP VM without the paravisor.
> 
> Replace hv_isolation_type_en_snp() with
> !ms_hyperv.paravisor_present && hv_isolation_type_snp().
> 
> The hv_isolation_type_en_snp() in drivers/hv/hv.c and
> drivers/hv/hv_common.c can be changed to hv_isolation_type_snp() since
> we know !ms_hyperv.paravisor_present is true there.
> 
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> ---
> 
> Changes in v2:
>   Rebased to Tianyu's v7 SNP patchset: the changes are small.
>     In hyperv_init_ghcb() and hyperv_init(), added the test of
> hyperv_paravisor_present, which was missed in v1.
>     Updated the test before the call of get_vtl().
>     Updated the test in hv_do_hypercall() and friends.
>     Updated the test for hv_smp_prepare_cpus().
> 
> Changes in v3:
>   hyperv_paravisor_present -> ms_hyperv.paravisor_present
> 
> 
>  arch/x86/hyperv/hv_init.c       |  8 ++++----
>  arch/x86/hyperv/ivm.c           | 12 +-----------
>  arch/x86/include/asm/mshyperv.h | 11 ++++-------
>  arch/x86/kernel/cpu/mshyperv.c  | 10 ++++------
>  drivers/hv/hv.c                 |  4 ++--
>  drivers/hv/hv_common.c          |  8 +-------
>  include/asm-generic/mshyperv.h  |  3 +--
>  7 files changed, 17 insertions(+), 39 deletions(-)
> 

Reviewed-by: Michael Kelley <mikelley@microsoft.com>