From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8213DC5CFEB for ; Wed, 11 Jul 2018 16:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40E6320C0B for ; Wed, 11 Jul 2018 16:20:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40E6320C0B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aosc.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389692AbeGKQZR convert rfc822-to-8bit (ORCPT ); Wed, 11 Jul 2018 12:25:17 -0400 Received: from hermes.aosc.io ([199.195.250.187]:37329 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733247AbeGKQZR (ORCPT ); Wed, 11 Jul 2018 12:25:17 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id A071F64AFD; Wed, 11 Jul 2018 16:20:03 +0000 (UTC) Date: Thu, 12 Jul 2018 00:19:28 +0800 In-Reply-To: <20180711161356.GA4685@rob-hp-laptop> References: <20180706153805.25842-1-icenowy@aosc.io> <20180706153805.25842-7-icenowy@aosc.io> <20180711161356.GA4685@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH v2 6/9] dt-bindings: phy: add binding for Allwinner USB3 PHY To: Rob Herring CC: Maxime Ripard , Chen-Yu Tsai , Kishon Vijay Abraham I , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com From: Icenowy Zheng Message-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年7月12日 GMT+08:00 上午12:13:56, Rob Herring 写到: >On Fri, Jul 06, 2018 at 11:38:02PM +0800, Icenowy Zheng wrote: >> The new Allwinner H6 SoC contains a USB3 PHY that is wired to the >> external USB3 pins of the SoC. >> >> Add a device tree binding for the PHY. >> >> Signed-off-by: Icenowy Zheng >> --- >> Splitted from the PHY driver patch in v1. >> >> .../bindings/phy/sun50i-usb3-phy.txt | 24 >+++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 >Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >> >> diff --git >a/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >> new file mode 100644 >> index 000000000000..912d55f9f69d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt >> @@ -0,0 +1,24 @@ >> +Allwinner sun50i USB3 PHY >> +----------------------- >> + >> +Required properties: >> +- compatible : should be one of >> + * allwinner,sun60i-h6-usb3-phy >> +- reg : a list of offset + length pairs >> +- #phy-cells : from the generic phy bindings, must be 0 >> +- clocks : phandle + clock specifier for the phy clock >> +- resets : phandle + reset specifier for the phy reset >> + >> +Optional Properties: >> +- phy-supply : from the generic phy bindings, a phandle to a >regulator that >> + provides power to VBUS. > >Power to the phy or Vbus? If the latter only, then this property should > >be elsewhere (like a connector node). I don't think there's connector nodes for USB ports now. And by checking existed device trees, use phy-supply on USB phy is common. It's seen on Meson GXBB, RK3399 and Hi6220 in arch/arm64/boot/dts. > >> + >> +Example: >> + usb3phy: phy@5210000 { >> + compatible = "allwinner,sun50i-h6-usb3-phy"; >> + reg = <0x5210000 0x10000>; >> + clocks = <&ccu CLK_USB_PHY1>; >> + resets = <&ccu RST_USB_PHY1>; >> + #phy-cells = <0>; >> + status = "disabled"; >> + }; >> -- >> 2.17.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" >in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html