RE: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

From: "Anaczkowski, Lukasz" <lukasz.anaczkowski@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	"mhocko@suse.com" <mhocko@suse.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"Srinivasappa, Harish" <harish.srinivasappa@intel.com>,
	"Odzioba, Lukasz" <lukasz.odzioba@intel.com>,
	"Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com>,
	"Daniluk, Lukasz" <lukasz.daniluk@intel.com>
Subject: RE: [PATCH v2] Linux VM workaround for Knights Landing A/D leak
Date: Wed, 15 Jun 2016 13:12:13 +0000	[thread overview]
Message-ID: <C1C2579D7BE026428F81F41198ADB17237A866F9@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <20160614181002.GA30049@pd.tnic>

From: Borislav Petkov [mailto:bp@alien8.de] 
Sent: Tuesday, June 14, 2016 8:10 PM

>> +	if (boot_cpu_has_bug(X86_BUG_PTE_LEAK))
>
> static_cpu_has_bug()

>> +	if (c->x86_model == 87) {
>
> That should be INTEL_FAM6_XEON_PHI_KNL, AFAICT.

>> +		static bool printed;
>> +
>> +		if (!printed) {
>> +			pr_info("Enabling PTE leaking workaround\n");
>> +			printed = true;
>> +		}
>
> pr_info_once

Thanks, Boris! This is very valuable. I'll address  those comments in next version of the patch.

Cheers,
Lukasz