From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753682AbcFONNI (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 09:13:08 -0400
Received: from mga11.intel.com ([192.55.52.93]:36906 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753454AbcFONND convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 09:13:03 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,476,1459839600"; 
   d="scan'208";a="1002466745"
From: "Anaczkowski, Lukasz" <lukasz.anaczkowski@intel.com>
To: Nadav Amit <nadav.amit@gmail.com>
CC: LKML <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "mhocko@suse.com" <mhocko@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "Srinivasappa, Harish" <harish.srinivasappa@intel.com>,
        "Odzioba, Lukasz" <lukasz.odzioba@intel.com>,
        "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com>,
        "Daniluk, Lukasz" <lukasz.daniluk@intel.com>
Subject: RE: [PATCH v2] Linux VM workaround for Knights Landing A/D leak
Thread-Topic: [PATCH v2] Linux VM workaround for Knights Landing A/D leak
Thread-Index: AQHRxl58dY/shcvhokGDWF3s6tlV3Z/pOkiAgADgybA=
Date: Wed, 15 Jun 2016 13:12:59 +0000
Message-ID: <C1C2579D7BE026428F81F41198ADB17237A8670A@irsmsx110.ger.corp.intel.com>
References: <7FB15233-B347-4A87-9506-A9E10D331292@gmail.com>
 <1465923672-14232-1-git-send-email-lukasz.anaczkowski@intel.com>
 <76F6D5F2-6723-441B-BD63-52628731F1FF@gmail.com>
In-Reply-To: <76F6D5F2-6723-441B-BD63-52628731F1FF@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWU1ZDdkMjktMzU1MC00MjA1LTlhYjUtY2NkYWJjOGZmMDU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhCQW1uV0I4dU9OTUZBekNPcGlSaW5ZNEZGZlwvSGJyeU9cL3l1UFp6Q0pZTT0ifQ==
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Nadav Amit [mailto:nadav.amit@gmail.com] 
Sent: Tuesday, June 14, 2016 8:38 PM

>> +	pte_t pte = ptep_get_and_clear(mm, addr, ptep);
>> +
>> +	if (boot_cpu_has_bug(X86_BUG_PTE_LEAK))
>> +		fix_pte_leak(mm, addr, ptep);
>> +	return pte;
>> }
>
> I missed it on the previous iteration: ptep_get_and_clear already calls 
> fix_pte_leak when needed. So do you need to call it again here?

You're right, Nadav. Not needing this. Will be removed in next version of the patch.

Cheers,
Lukasz