From: Anton Altaparmakov <anton@tuxera.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-ntfs-dev@lists.sourceforge.net"
<linux-ntfs-dev@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
Zheng Zengkai <zhengzengkai@huawei.com>
Subject: Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'
Date: Thu, 10 Dec 2020 02:51:17 +0000 [thread overview]
Message-ID: <C1D18C59-3E1B-4825-881C-B7AE6FACF4D7@tuxera.com> (raw)
In-Reply-To: <20201209183623.b26e90de3d0aa92a72010ff0@linux-foundation.org>
Hi Andrew,
Ah, oops! Thank you and apologies. Quite right the alternative patch was even better. No need to apply this patch after all...
Zheng, the log_page_mask variable was removed altogether so your patch no longer makes sense.
Best regards,
Anton
> On 10 Dec 2020, at 02:36, Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov <anton@tuxera.com> wrote:
>
>> Can you please apply this?
>>
>> ...
>>
>>> --- a/fs/ntfs/logfile.c
>>> +++ b/fs/ntfs/logfile.c
>>> @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp)
>>> * optimize log_page_size and log_page_bits into constants.
>>> */
>>> log_page_bits = ntfs_ffs(log_page_size) - 1;
>>> - size &= ~(s64)(log_page_size - 1);
>>> + size &= ~(s64)(log_page_mask);
>>> /*
>>> * Ensure the log file is big enough to store at least the two restart
>>> * pages and the minimum number of log record pages.
>
> https://lore.kernel.org/lkml/1604821092-54631-1-git-send-email-alex.shi@linux.alibaba.com/
> addressed this?
>
--
Anton Altaparmakov <anton at tuxera.com> (replace at with @)
Lead in File System Development, Tuxera Inc., http://www.tuxera.com/
Linux NTFS maintainer
next prev parent reply other threads:[~2020-12-10 2:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 4:13 [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask' Zheng Zengkai
2020-11-28 1:29 ` Zheng Zengkai
2020-12-08 8:24 ` Anton Altaparmakov
2020-12-10 2:36 ` Andrew Morton
2020-12-10 2:51 ` Anton Altaparmakov [this message]
2020-12-10 6:17 ` Zheng Zengkai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1D18C59-3E1B-4825-881C-B7AE6FACF4D7@tuxera.com \
--to=anton@tuxera.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=zhengzengkai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).