From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161212AbcE3Ki4 (ORCPT ); Mon, 30 May 2016 06:38:56 -0400 Received: from mail-sn1nam02on0046.outbound.protection.outlook.com ([104.47.36.46]:24608 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932899AbcE3Kix (ORCPT ); Mon, 30 May 2016 06:38:53 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Appana Durga Kedareswara Rao To: Shubhrajyoti Datta CC: Rob Herring , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , "Michal Simek" , Soren Brinkmann , "vinod.koul@intel.com" , "dan.j.williams@intel.com" , Moritz Fischer , Laurent Pinchart , "luis@debethencourt.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , Punnaiah Choudary Kalluri Subject: RE: [PATCH v9 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Thread-Topic: [PATCH v9 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Thread-Index: AQHRrOWlX+831qz6H0aMXw3L5muVW5/QldmAgADO8CA= Date: Mon, 30 May 2016 10:38:47 +0000 Message-ID: References: <1463123033-5443-1-git-send-email-appanad@xilinx.com> <1463123033-5443-2-git-send-email-appanad@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.23.95.162] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22358.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(9170700003)(5004730100002)(5003600100002)(2900100001)(6806005)(11100500001)(1220700001)(8676002)(86362001)(106466001)(2906002)(4326007)(2920100001)(55846006)(47776003)(3846002)(106116001)(8936002)(81166006)(110136002)(50466002)(6116002)(189998001)(5008740100001)(23676002)(586003)(107886002)(92566002)(50986999)(33656002)(102836003)(87936001)(2950100001)(5250100002)(76176999)(54356999)(4001430100002)(63266004)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1NAM02HT053;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: dce78429-b07a-48df-fd96-08d388769770 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1NAM02HT053; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(5005006)(13023025)(13024025)(13018025)(13017025)(8121501046)(10201501046)(3002001)(6055026);SRVR:SN1NAM02HT053;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM02HT053; X-Forefront-PRVS: 09583628E0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2016 10:38:51.2029 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT053 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4UAd13j025316 Hi Shubhrajyoti, > > + */ > > +static void zynqmp_dma_update_desc_to_ctrlr(struct zynqmp_dma_chan > *chan, > > + struct zynqmp_dma_desc_sw *desc) > > +{ > > + dma_addr_t addr; > > + > > + addr = desc->src_p; > > + writel(addr, chan->regs + ZYNQMP_DMA_SRC_START_LSB); > > + writel(upper_32_bits(addr), chan->regs + > > + ZYNQMP_DMA_SRC_START_MSB); > Can we combine the two writes to a 64bit write. > It may be helpful on 64-bit systems. Ok will fix this in the next version of the patch... Thanks, Kedar.