From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753608AbcFMFiD (ORCPT ); Mon, 13 Jun 2016 01:38:03 -0400 Received: from mail-sn1nam02on0068.outbound.protection.outlook.com ([104.47.36.68]:44489 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751113AbcFMFiA convert rfc822-to-8bit (ORCPT ); Mon, 13 Jun 2016 01:38:00 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Appana Durga Kedareswara Rao To: Vinod Koul CC: "dan.j.williams@intel.com" , Michal Simek , Soren Brinkmann , "moritz.fischer@ettus.com" , "laurent.pinchart@ideasonboard.com" , "luis@debethencourt.com" , "sfr@canb.auug.org.au" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode Thread-Topic: [PATCH] dmaengine: vdma: Fix compilation warning in cyclic dma mode Thread-Index: AQHRwhR+wfZEFvR3JECEHQS14aO5Xp/mYosAgACEdZA= Date: Mon, 13 Jun 2016 05:37:54 +0000 Message-ID: References: <1465452132-13512-1-git-send-email-appanad@xilinx.com> <20160613054243.GB16910@localhost> In-Reply-To: <20160613054243.GB16910@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.23.94.221] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22386.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(199003)(189002)(50466002)(106116001)(8936002)(55846006)(63266004)(5250100002)(46406003)(4326007)(8746002)(33656002)(97756001)(102836003)(87936001)(6116002)(106466001)(86362001)(2950100001)(2906002)(23726003)(2920100001)(2900100001)(189998001)(5004730100002)(47776003)(8676002)(3846002)(586003)(110136002)(11100500001)(50986999)(5008740100001)(81156014)(6806005)(54356999)(81166006)(5003600100002)(92566002)(76176999)(356003)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2NAM02HT073;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 60198894-09a2-41c0-ca82-08d3934ce016 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BL2NAM02HT073; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13017025)(8121501046)(13023025)(13018025)(13024025)(13015025)(3002001)(10201501046)(6055026);SRVR:BL2NAM02HT073;BCL:0;PCL:0;RULEID:;SRVR:BL2NAM02HT073; X-Forefront-PRVS: 0972DEC1D9 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2016 05:37:57.3882 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT073 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, > On Thu, Jun 09, 2016 at 11:32:12AM +0530, Kedareswara rao Appana wrote: > > This patch fixes the below compilation warining. > > drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic': > > drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be > > used uninitialized in this function [-Wmaybe-uninitialized] > > segment->hw.control |= XILINX_DMA_BD_SOP; > > > > The start of packet (SOP) should be set to the first segment in the > > desc chain not for the last segment of the desc chain. > > I have applied this after adding Reported by from SFR. Sorry will fix it next time on wards.... > > You should always give credit to folks who report issues. Sure will fix next time onwards... Thanks, Kedar.