From: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
Michal Simek <michals@xilinx.com>,
Soren Brinkmann <sorenb@xilinx.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"moritz.fischer@ettus.com" <moritz.fischer@ettus.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"luis@debethencourt.com" <luis@debethencourt.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Subject: RE: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support
Date: Thu, 30 Jun 2016 05:23:30 +0000 [thread overview]
Message-ID: <C246CAC1457055469EF09E3A7AC4E11A4A5BA435@XAP-PVEXMBX01.xlnx.xilinx.com> (raw)
In-Reply-To: <20160630042653.GM14945@localhost>
Hi Vinod,
>
> On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote:
>
> > + dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
> > + dma_cap_set(DMA_SG, zdev->common.cap_mask);
> > + dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask);
>
> > /**
> > + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure
> > + * @ovrfetch: Overfetch status
> > + * @has_sg: Support scatter gather transfers
> > + * @ratectrl: Rate control value
> > + * @src_issue: Out standing transactions on source
> > + * @src_burst_len: Source burst length
> > + * @dst_burst_len: Dest burst length
> > + */
>
> As discussed in other thread as well, this is no-go for memcpy. Please come back
> after removing this
>
> For slave usages use the dma_slave_config
Sure will fix in the next version...
Regards,
Kedar.
>
> --
> ~Vinod
prev parent reply other threads:[~2016-06-30 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 15:37 [PATCH v11 1/2] Documentation: DT: dma: Add Xilinx zynqmp dma device tree binding documentation Kedareswara rao Appana
2016-06-09 15:37 ` [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Kedareswara rao Appana
2016-06-30 4:26 ` Vinod Koul
2016-06-30 5:23 ` Appana Durga Kedareswara Rao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C246CAC1457055469EF09E3A7AC4E11A4A5BA435@XAP-PVEXMBX01.xlnx.xilinx.com \
--to=appana.durga.rao@xilinx.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=moritz.fischer@ettus.com \
--cc=pawel.moll@arm.com \
--cc=punnaia@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sorenb@xilinx.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).