From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969457AbdDTGzN convert rfc822-to-8bit (ORCPT ); Thu, 20 Apr 2017 02:55:13 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:46772 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967567AbdDTGzK (ORCPT ); Thu, 20 Apr 2017 02:55:10 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency From: Marcel Holtmann In-Reply-To: <20170420001534.ecnkaqlk652thya7@earth> Date: Thu, 20 Apr 2017 08:55:02 +0200 Cc: Arnd Bergmann , "Gustavo F. Padovan" , Johan Hedberg , Rob Herring , Bjorn Andersson , "David S. Miller" , Kalle Valo , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20170419175051.4177480-1-arnd@arndb.de> <20170420001534.ecnkaqlk652thya7@earth> To: Sebastian Reichel X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, >> With CONFIG_SERIAL_DEV_BUS=m, the hci_serdev.o file does not actually >> get built into hci_uart.o as the Makefile doesn't pick it up, leading >> to a link error with anything referring to it: >> >> ERROR: "hci_uart_register_device" [drivers/bluetooth/hci_nokia.ko] undefined! >> scripts/Makefile.modpost:91: recipe for target '__modpost' failed >> >> Changing this in the Makefile would cause another problem when >> hci_uart itself is built-in and cannot reference symbols from the >> serdev module. >> >> This tries to address both problems by introducing a new hidden >> Kconfig symbol that controls both the compilation of hci_serdev.o >> and whether the Nokia driver can be selected. This seems to address >> the problem for me, though there might be a better way to do it. >> >> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver") >> Signed-off-by: Arnd Bergmann >> --- >> drivers/bluetooth/Kconfig | 8 +++++++- >> drivers/bluetooth/Makefile | 2 +- >> 2 files changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig >> index 8aafbed9e160..737d93ef27c5 100644 >> --- a/drivers/bluetooth/Kconfig >> +++ b/drivers/bluetooth/Kconfig >> @@ -76,6 +76,12 @@ config BT_HCIUART >> Say Y here to compile support for Bluetooth UART devices into the >> kernel or say M to compile it as module (hci_uart). >> >> +config BT_HCIUART_SERDEV >> + bool >> + depends on SERIAL_DEV_BUS && BT_HCIUART >> + depends on SERIAL_DEV_BUS=y || SERIAL_DEV_BUS=BT_HCIUART >> + default y >> + >> config BT_HCIUART_H4 >> bool "UART (H4) protocol support" >> depends on BT_HCIUART >> @@ -89,7 +95,7 @@ config BT_HCIUART_H4 >> config BT_HCIUART_NOKIA >> tristate "UART Nokia H4+ protocol support" >> depends on BT_HCIUART > > I guess BT_HCIUART dependency is no longer needed > when we have BT_HCIUART_SERDEV dependency? if so then we need another patch since I already applied the one from Arnd. Regards Marcel