From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbbDGMrK (ORCPT ); Tue, 7 Apr 2015 08:47:10 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:46190 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753286AbbDGMrE convert rfc822-to-8bit (ORCPT ); Tue, 7 Apr 2015 08:47:04 -0400 From: Vineet Gupta To: Joe Perches , Stefan Agner CC: Greg Kroah-Hartman , Jiri Slaby , "linux-ia64@vger.kernel.org" , "kernel@stlinux.com" , Nicolas Ferre , Timur Tabi , "linux-kernel@vger.kernel.org" , Pat Gefre , Laxman Dewangan , "Maciej W. Rozycki" , Daniel Walker , "sparclinux@vger.kernel.org" , Peter Korsgaard , Sonic Zhang , Alexandre Courbot , Russell King , Michal Simek , "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" , Tobias Klauser , "Stephen Warren" , "linux-arm-msm@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , Thadeu Lima de Souza Cascardo , "linux-tegra@vger.kernel.org" , David Brown , =?iso-8859-1?Q?S=F6ren_Brinkmann?= , "Maxime Coquelin" , Barry Song , "Vineet Gupta" , Patrice Chotard , Tony Prisk , Bryan Huntsman , Thierry Reding , =?iso-8859-1?Q?Uwe_Kleine-K=F6nig?= , "Srinivas Kandagatla" , "nios2-dev@lists.rocketboards.org" , linuxppc-dev , "David S. Miller" Subject: Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations Thread-Topic: [PATCH V2] tty: serial: Add const to struct uart_ops declarations Thread-Index: AQHQb83YP+bxxJwu6Eqo1PLZ76tTcQ== Date: Tue, 7 Apr 2015 12:46:46 +0000 Message-ID: References: <1428169665.2775.53.camel@perches.com> <1428258294.2775.69.camel@perches.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.3] Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 05 April 2015 11:55 PM, Joe Perches wrote: These structs can be const, so make them const. Miscellanea: o Add static to struct uart_ops declaration in bfin_sport_uart Signed-off-by: Joe Perches --- On Sun, 2015-04-05 at 00:04 +0200, Stefan Agner wrote: > On 2015-04-04 19:47, Joe Perches wrote: > > Done with: > > sed -r -i -e 's/\bstruct\s+uart_ops\s+(\w+)\s*=\s*/const struct > > uart_ops \1 = /g' drivers/tty/serial/*.c [] > +++ b/drivers/tty/serial/fsl_lpuart.c > Something went wrong in this driver, const is twice... Apologies, thanks for noticing. The sed was mistakenly done twice on that file. V2: o Fix duplicate const in fsl_lpuart.c o Add static to drivers/tty/serial/bfin_sport_uart.c Still compiled only x86 and not cross-compiled or tested. drivers/tty/serial/21285.c | 2 +- drivers/tty/serial/altera_jtaguart.c | 2 +- drivers/tty/serial/altera_uart.c | 2 +- drivers/tty/serial/amba-pl010.c | 2 +- drivers/tty/serial/amba-pl011.c | 2 +- drivers/tty/serial/apbuart.c | 2 +- drivers/tty/serial/ar933x_uart.c | 2 +- drivers/tty/serial/arc_uart.c | 2 +- Acked-by: Vineet Gupta # for arc_uart Th, -Vineet