From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C395FC4363D for ; Fri, 25 Sep 2020 03:57:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F9D920EDD for ; Fri, 25 Sep 2020 03:57:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727074AbgIYD5n convert rfc822-to-8bit (ORCPT ); Thu, 24 Sep 2020 23:57:43 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:51525 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbgIYD5m (ORCPT ); Thu, 24 Sep 2020 23:57:42 -0400 Received: from mail-pj1-f71.google.com ([209.85.216.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kLerb-00078o-Tw for linux-kernel@vger.kernel.org; Fri, 25 Sep 2020 03:57:40 +0000 Received: by mail-pj1-f71.google.com with SMTP id fs5so911024pjb.7 for ; Thu, 24 Sep 2020 20:57:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1LdherrVFx5eJRxgEW9+dGdwxO9PmjDU56jtqG1BEPk=; b=Vi7q4h3HzcFa70meL23zv6IbCwx9sKdi0T5Oqe2A8ysVj1GsMN8DEkMhVElBeYQxb9 e2wCzi8/dfUfOjBNIJRD+nFHFtPhfLBclEV3oSdz9+LrKaTYCAJNGvUSXIAxnCy9qPic jMJ+JnD4PsguTxNDcSMxLBscf14ZNyW8ENuN59613G612BOvLRC18YbyRK1fre8gj/L5 pzkQOgPM71iry5JXOz1MofOSIy33BWAfq/NJ/hHNCv6kdqp55nO0B1VAnBHqW69lz+Je WbX/FQgFO1YgfxdrseKCcg9CSOpKMncAPVm2Nkj6gyROfEyhzELi+LQ65Ti/wo07KH0a jOLg== X-Gm-Message-State: AOAM530D78ulOFKMZdbnPX+5/wXXSXddKJpiCJPGvfLeBc2vSSbgS9xh OgdCjeiJk1u/5bF9zPS/9bWmM+lZKns4yneEz+7tq0NwfqqpQN5tMk0dAWTLuy3/3nU5+G+B36X CAlbGANIrynYmST1P3LjOrXz4UUfaos88vOoKOEiQWA== X-Received: by 2002:a17:90a:ec06:: with SMTP id l6mr849224pjy.66.1601006258428; Thu, 24 Sep 2020 20:57:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7pLxjFzkzosFKtVxO8GnnwK1Fol9HRjQArB4CvcP1EqjBodisTZUbT0khBqkmqeNntbJ60Q== X-Received: by 2002:a17:90a:ec06:: with SMTP id l6mr849204pjy.66.1601006258035; Thu, 24 Sep 2020 20:57:38 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id gb17sm627128pjb.15.2020.09.24.20.57.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Sep 2020 20:57:37 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH v3] e1000e: Increase iteration on polling MDIC ready bit From: Kai-Heng Feng In-Reply-To: <20200924195719.GF3821492@lunn.ch> Date: Fri, 25 Sep 2020 11:57:34 +0800 Cc: Jeff Kirsher , "David S. Miller" , Jakub Kicinski , "moderated list:INTEL ETHERNET DRIVERS" , "open list:NETWORKING DRIVERS" , open list Content-Transfer-Encoding: 8BIT Message-Id: References: <20200924150958.18016-1-kai.heng.feng@canonical.com> <20200924164542.19906-1-kai.heng.feng@canonical.com> <20200924195719.GF3821492@lunn.ch> To: Andrew Lunn X-Mailer: Apple Mail (2.3608.120.23.2.1) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sep 25, 2020, at 03:57, Andrew Lunn wrote: > > On Fri, Sep 25, 2020 at 12:45:42AM +0800, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1000e 0000:00:1f.6 eno1: MDI Write did not complete >> [ 704.902817] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >> [ 704.903075] e1000e 0000:00:1f.6 eno1: reading PHY page 769 (or 0x6020 shifted) reg 0x17 >> [ 704.903281] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >> [ 704.903486] e1000e 0000:00:1f.6 eno1: writing PHY page 769 (or 0x6020 shifted) reg 0x17 >> [ 704.943155] e1000e 0000:00:1f.6 eno1: MDI Error >> ... >> [ 705.108161] e1000e 0000:00:1f.6 eno1: Hardware Error >> >> As Andrew Lunn pointed out, MDIO has nothing to do with phy, and indeed >> increase polling iteration can resolve the issue. >> >> The root cause is quite likely Intel ME, since it's a blackbox to the >> kernel so the only approach we can take is to be patient and wait >> longer. > > Please could you explain how you see Intel ME being responsible for > this. I'm not convinced. Some other occurrences: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d17c7868b2f8e329dcee4ecd2f5d16cfc9b26ac8 https://lore.kernel.org/netdev/20200323191639.48826-1-aaron.ma@canonical.com/ Of course we need an ACK from Intel this one is also related to ME. Kai-Heng > > Andrew