From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422856AbcFGSKW (ORCPT ); Tue, 7 Jun 2016 14:10:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:6498 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422842AbcFGSKQ convert rfc822-to-8bit (ORCPT ); Tue, 7 Jun 2016 14:10:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,434,1459839600"; d="scan'208";a="997146351" From: "Dey, Megha" To: Herbert Xu CC: "tim.c.chen@linux.intel.com" , "davem@davemloft.net" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Yu, Fenghua" , "Megha Dey" Subject: RE: [PATCH V2 2/2] crypto : async implementation for sha1-mb Thread-Topic: [PATCH V2 2/2] crypto : async implementation for sha1-mb Thread-Index: AQHRvUJ11/nd3/CJwkKlpFJCVHeT0J/eS2GAgAAJjoA= Date: Tue, 7 Jun 2016 18:10:14 +0000 Message-ID: References: <1464922430-26976-1-git-send-email-megha.dey@intel.com> <1464922430-26976-3-git-send-email-megha.dey@intel.com> <20160607103515.GB325@gondor.apana.org.au> In-Reply-To: <20160607103515.GB325@gondor.apana.org.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQzMDdmODAtMjRiNi00OTFhLWEzNjYtNDYzYzUwNTRkOGMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImthaXd2TFRBRjFOWnNKY1hCNXBUVXpsUk5VVDY2UzRnOStkUVE2UWIzamc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----Original Message----- From: Herbert Xu [mailto:herbert@gondor.apana.org.au] Sent: Tuesday, June 7, 2016 3:35 AM To: Dey, Megha Cc: tim.c.chen@linux.intel.com; davem@davemloft.net; linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Yu, Fenghua ; Megha Dey Subject: Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb On Thu, Jun 02, 2016 at 07:53:50PM -0700, Megha Dey wrote: > > + struct ahash_alg *shash = crypto_ahash_alg(tfm); > > /* alignment is to be done by multi-buffer crypto algorithm if > needed */ > > - return shash->finup(desc, NULL, 0, req->result); > + return shash->finup(desc); You're still poking in the guts of the API. Now that it's a real ahash you don't need to do that. Just do crypto_ahash_finup. That way you don't need to export crypto_ahsh_alg either. > I have made these changes and re-sent the patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt