From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: ming_qian@realsil.com.cn
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device
Date: Thu, 10 May 2018 23:05:54 +0800 [thread overview]
Message-ID: <C4B48A97-2942-4E37-A65C-DD0570FAA52C@canonical.com> (raw)
In-Reply-To: <1525831988-32017-1-git-send-email-ming_qian@realsil.com.cn>
at 10:13, ming_qian@realsil.com.cn wrote:
> From: ming_qian <ming_qian@realsil.com.cn>
>
> The length of UVC 1.5 video control is 48, and it id 34 for UVC 1.1.
> Change it to 48 for UVC 1.5 device,
> and the UVC 1.5 device can be recognized.
>
> More changes to the driver are needed for full UVC 1.5 compatibility.
> However, at least the UVC 1.5 Realtek RTS5847/RTS5852 cameras have
> been reported to work well.
I think this should also Cc: stable.
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> Signed-off-by: ming_qian <ming_qian@realsil.com.cn>
> ---
> drivers/media/usb/uvc/uvc_video.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c
> b/drivers/media/usb/uvc/uvc_video.c
> index aa0082f..32dfb32 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -171,6 +171,8 @@ static int uvc_get_video_ctrl(struct uvc_streaming
> *stream,
> int ret;
>
> size = stream->dev->uvc_version >= 0x0110 ? 34 : 26;
> + if (stream->dev->uvc_version >= 0x0150)
> + size = 48;
> if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) &&
> query == UVC_GET_DEF)
> return -EIO;
> @@ -259,6 +261,8 @@ static int uvc_set_video_ctrl(struct uvc_streaming
> *stream,
> int ret;
>
> size = stream->dev->uvc_version >= 0x0110 ? 34 : 26;
> + if (stream->dev->uvc_version >= 0x0150)
> + size = 48;
> data = kzalloc(size, GFP_KERNEL);
> if (data == NULL)
> return -ENOMEM;
> --
> 2.7.4
next prev parent reply other threads:[~2018-05-10 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 2:13 [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device ming_qian
2018-05-10 15:05 ` Kai-Heng Feng [this message]
2018-05-10 15:38 ` Hans de Goede
2018-05-14 17:28 ` Josef Šimánek
2018-05-14 17:38 ` Josef Šimánek
2018-05-18 14:04 ` Ana Guerrero Lopez
2018-05-25 1:05 ` Darren Hart
2018-05-22 20:32 ` [PATCH] " Laurent Pinchart
2018-05-23 5:42 ` Kai Heng Feng
2018-05-23 9:41 ` Ana Guerrero Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4B48A97-2942-4E37-A65C-DD0570FAA52C@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming_qian@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).