linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rose, Gregory V" <gregory.v.rose@intel.com>
To: David Ahern <daahern@cisco.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: RE: VFs go missing with latest kernel
Date: Tue, 31 Jan 2012 22:58:39 +0000	[thread overview]
Message-ID: <C5551D9AAB213A418B7FD5E4A6F30A0702F6489B@ORSMSX106.amr.corp.intel.com> (raw)
In-Reply-To: <4F287102.3060600@cisco.com>

> -----Original Message-----
> From: David Ahern [mailto:daahern@cisco.com]
> Sent: Tuesday, January 31, 2012 2:54 PM
> To: Rose, Gregory V
> Cc: LKML
> Subject: VFs go missing with latest kernel
> 
> Hi
> 
> I built the kernel.git tree (3.3-rc1) and noticed that even numbered VFs
> go missing for the last 2 ports of a quad nic card.
> 
> This is the relevant output from lspci for the stock Fedora 14 kernel
> (2.6.35.14-106):
> 
> 07:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network
> Connection (rev 01)
> 07:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network
> Connection (rev 01)
> 08:10.0 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.1 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.2 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.3 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.4 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.5 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.6 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.7 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.0 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.1 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.2 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.3 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.4 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.5 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 
> 
> For the 3.3.0-rc1 kernel I get:
> 
> 07:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network
> Connection (rev 01)
> 07:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network
> Connection (rev 01)
> 08:10.1 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.3 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.5 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:10.7 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.1 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.3 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 08:11.5 Ethernet controller: Intel Corporation 82576 Virtual Function
> (rev 01)
> 
> Note that all of the even numbered VFs have disappeared. Accordingly,
> trying to launch the VM to which the VFs are assigned fails. git bisect
> pointed to this commit:
> 
> 0224d663063d542b3d829706f3fcbd0f640f19b3 is the first bad commit
> commit 0224d663063d542b3d829706f3fcbd0f640f19b3
> Author: Greg Rose <gregory.v.rose@intel.com>
> Date:   Fri Oct 14 02:57:14 2011 +0000
> 
>     igb: Check if subordinate VFs are assigned to virtual machines
> 
>     Kvm and the Xen pci-back driver will set a flag in the virtual
> function
>     pci device dev_flags when the VF is assigned to a guest VM.  Before
>     destroying subordinate VFs check to see if the flag is set and if so
>     skip the call to pci_disable_sriov() to avoid system crashes.
> 
>     Copy the maintainer for the Xen pci-back driver.  Also CC'ing
>     maintainers of all drivers found to call pci_disable_sriov().
> 
> 
> Sure enough reverting the patch on 3.3.0-rc1 makes the VFs visible again.
> 
> I am hitting some other problem trying to use the VF on 3.3.0-rc1 -- KVM
> fails the KVM_CAP_IOMMU check though the server has one (works fine with
> the older kernel) and it is built into the kernel. Debugging that
> problem now.

I'll see if I can reproduce that.  Is this all after a fresh boot with no unloading/reloading of the PF driver?

- Greg

> 
> David

  reply	other threads:[~2012-01-31 22:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31 22:53 VFs go missing with latest kernel David Ahern
2012-01-31 22:58 ` Rose, Gregory V [this message]
2012-01-31 23:05   ` David Ahern
2012-01-31 23:07     ` Rose, Gregory V
2012-02-01  0:30   ` David Ahern
2012-02-01  0:43     ` Rose, Gregory V
2012-02-01  0:50       ` David Ahern
2012-02-01  1:03         ` Rose, Gregory V
2012-02-01 17:47           ` Rose, Gregory V
2012-02-01 17:57             ` David Ahern
2012-02-01 18:02               ` Rose, Gregory V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C5551D9AAB213A418B7FD5E4A6F30A0702F6489B@ORSMSX106.amr.corp.intel.com \
    --to=gregory.v.rose@intel.com \
    --cc=daahern@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).